| Message ID | 20241007070101.23263-1-jason-jh.lin@mediatek.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fix degradation problem of alpha blending series | expand |
On Mon, Oct 7, 2024 at 3:01 PM Jason-JH.Lin <jason-jh.lin@mediatek.com> wrote: > > Some SoCs do not support the ignore_pixl_alpha flag, which breaks the > XRGB8888 format. Some SoCs do not support pre-multiplied pixel formats > and extending configuration of OVL pre-multiplied color formats, > such as MT8173. > > Fix the SoC degradation problem by this sreies. The series fixes the display color issue on MT8173. Tested on Hana Chromebook (Telesu). Tested-by: Chen-Yu Tsai <wenst@chromium.org> > --- > Change in v9: > 1. Add the fix patch for the XRGB8888 downgrade issue of MT8173 > 2. Add the refine patch for ignore_pixel_alpha statement > > Change in v8: > Remove blend_modes for not supported pre-multiplied SoCs to fix the > return error from drm_plane_create_blend_mode_property(). > > Change in v7: > 1. Add the remove color format comment patch for OVL > 2. Fix warning: 'const' type qualifier on return type has no effect > > Chnage in v6: > 1. Use blend_modes instead of function pointer in OVL > 2. Use ethdr instead of mdp_rdma to get blend_modes > 3. Add 0 checking for adding blend_mode property for mtk_plane > > Change in v5: > Add fix patch for mtk_plane > > Change in v4: > Add lost cases of mtk_ovl_fmt_convert_with_blend > > Change in v3: > Change MACRO approach to function pointer in driver data > > Change in v2: > Fix build error and typo > > Change in v1: > Add fix patch for OVL unsupport color format settings by driver data > > --- > > Jason-JH.Lin (5): > drm/mediatek: ovl: Fix XRGB format breakage for blend_modes > unsupported SoCs > drm/mediatek: ovl: Refine ignore_pixel_alpha comment and placement > drm/mediatek: ovl: Remove the color format comment for > ovl_fmt_convert() > drm/mediatek: ovl: Add blend_modes to driver data > drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs > > drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + > drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 + > drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 10 +++ > drivers/gpu/drm/mediatek/mtk_disp_drv.h | 2 + > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 70 ++++++++++++++----- > .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 7 ++ > drivers/gpu/drm/mediatek/mtk_ethdr.c | 7 ++ > drivers/gpu/drm/mediatek/mtk_ethdr.h | 1 + > drivers/gpu/drm/mediatek/mtk_plane.c | 15 ++-- > drivers/gpu/drm/mediatek/mtk_plane.h | 4 +- > 10 files changed, 92 insertions(+), 27 deletions(-) > > -- > 2.43.0 >
On Tue, 2024-10-08 at 12:15 +0800, Chen-Yu Tsai wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Mon, Oct 7, 2024 at 3:01 PM Jason-JH.Lin < > jason-jh.lin@mediatek.com> wrote: > > > > Some SoCs do not support the ignore_pixl_alpha flag, which breaks > the > > XRGB8888 format. Some SoCs do not support pre-multiplied pixel > formats > > and extending configuration of OVL pre-multiplied color formats, > > such as MT8173. > > > > Fix the SoC degradation problem by this sreies. > > The series fixes the display color issue on MT8173. Tested on Hana > Chromebook (Telesu). > > Tested-by: Chen-Yu Tsai <wenst@chromium.org> > Hi Chen-Yu, Thanks for your verification :) Regards, Jason-JH.Lin
Some SoCs do not support the ignore_pixl_alpha flag, which breaks the XRGB8888 format. Some SoCs do not support pre-multiplied pixel formats and extending configuration of OVL pre-multiplied color formats, such as MT8173. Fix the SoC degradation problem by this sreies. --- Change in v9: 1. Add the fix patch for the XRGB8888 downgrade issue of MT8173 2. Add the refine patch for ignore_pixel_alpha statement Change in v8: Remove blend_modes for not supported pre-multiplied SoCs to fix the return error from drm_plane_create_blend_mode_property(). Change in v7: 1. Add the remove color format comment patch for OVL 2. Fix warning: 'const' type qualifier on return type has no effect Chnage in v6: 1. Use blend_modes instead of function pointer in OVL 2. Use ethdr instead of mdp_rdma to get blend_modes 3. Add 0 checking for adding blend_mode property for mtk_plane Change in v5: Add fix patch for mtk_plane Change in v4: Add lost cases of mtk_ovl_fmt_convert_with_blend Change in v3: Change MACRO approach to function pointer in driver data Change in v2: Fix build error and typo Change in v1: Add fix patch for OVL unsupport color format settings by driver data --- Jason-JH.Lin (5): drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs drm/mediatek: ovl: Refine ignore_pixel_alpha comment and placement drm/mediatek: ovl: Remove the color format comment for ovl_fmt_convert() drm/mediatek: ovl: Add blend_modes to driver data drm/mediatek: Add blend_modes to mtk_plane_init() for different SoCs drivers/gpu/drm/mediatek/mtk_crtc.c | 1 + drivers/gpu/drm/mediatek/mtk_ddp_comp.c | 2 + drivers/gpu/drm/mediatek/mtk_ddp_comp.h | 10 +++ drivers/gpu/drm/mediatek/mtk_disp_drv.h | 2 + drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 70 ++++++++++++++----- .../gpu/drm/mediatek/mtk_disp_ovl_adaptor.c | 7 ++ drivers/gpu/drm/mediatek/mtk_ethdr.c | 7 ++ drivers/gpu/drm/mediatek/mtk_ethdr.h | 1 + drivers/gpu/drm/mediatek/mtk_plane.c | 15 ++-- drivers/gpu/drm/mediatek/mtk_plane.h | 4 +- 10 files changed, 92 insertions(+), 27 deletions(-)