mbox series

[v2,0/4] arm64: dts: imx8mm-kontron: Add HDMI and LVDS display support

Message ID 20240828074753.25401-1-frieder@fris.de (mailing list archive)
Headers show
Series arm64: dts: imx8mm-kontron: Add HDMI and LVDS display support | expand

Message

Frieder Schrempf Aug. 28, 2024, 7:46 a.m. UTC 
From: Frieder Schrempf <frieder.schrempf@kontron.de>

This add support for the display bridges (DSI->LVDS and DSI->HDMI)
on the BL i.MX8MM and the 7" LVDS panel in a separate overlay.

Only one of the interfaces (HDMI or LVDS) is supported at the same
time. Enabling the LVDS overlay will disable the HDMI interface.

* Patch 1 and 2: Add the necessary binding changes
* Patch 3: Extend the BL devicetree
* Patch 4: Add the LVDS panel overlay

Changes for v2:
* Patch 1: Add link to commit message
* Patch 2: Add Conors A-b tag
* Patch 3: Remove blank lines from hdmi node
* Patch 3: Fix order of lvds and hdmi nodes within i2c
* Patch 3: Remove the unneeded deletion of samsung,pll-clock-frequency
* Patch 3: Use the existing MIPI DSI output port from imx8mm.dtsi
* Patch 4: Update copyright year
* Patch 4: Use exisitng MIPI DSI output port from imx8mm.dtsi
* Patch 4: Fix pinctrl for GPIO hogs
* Patch 4: Fix property order in i2c2 node
* Patch 4: Use generic node name for touchscreen

Frieder Schrempf (4):
  dt-bindings: vendor-prefixes: Add Jenson Display
  dt-bindings: display: panel-lvds: Add compatible for Jenson
    BL-JT60050-01A
  arm64: dts: imx8mm-kontron: Add support for display bridges on BL
    i.MX8MM
  arm64: dts: imx8mm-kontron: Add DL (Display-Line) overlay with LVDS
    support

 .../bindings/display/panel/panel-lvds.yaml    |   2 +
 .../devicetree/bindings/vendor-prefixes.yaml  |   2 +
 arch/arm64/boot/dts/freescale/Makefile        |   4 +
 .../boot/dts/freescale/imx8mm-kontron-bl.dts  | 131 ++++++++++++
 .../boot/dts/freescale/imx8mm-kontron-dl.dtso | 189 ++++++++++++++++++
 5 files changed, 328 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtso

Comments

Frieder Schrempf Oct. 8, 2024, 7:21 a.m. UTC | #1 
On 28.08.24 9:46 AM, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> This add support for the display bridges (DSI->LVDS and DSI->HDMI)
> on the BL i.MX8MM and the 7" LVDS panel in a separate overlay.
> 
> Only one of the interfaces (HDMI or LVDS) is supported at the same
> time. Enabling the LVDS overlay will disable the HDMI interface.
> 
> * Patch 1 and 2: Add the necessary binding changes
> * Patch 3: Extend the BL devicetree
> * Patch 4: Add the LVDS panel overlay
> 
> Changes for v2:
> * Patch 1: Add link to commit message
> * Patch 2: Add Conors A-b tag
> * Patch 3: Remove blank lines from hdmi node
> * Patch 3: Fix order of lvds and hdmi nodes within i2c
> * Patch 3: Remove the unneeded deletion of samsung,pll-clock-frequency
> * Patch 3: Use the existing MIPI DSI output port from imx8mm.dtsi
> * Patch 4: Update copyright year
> * Patch 4: Use exisitng MIPI DSI output port from imx8mm.dtsi
> * Patch 4: Fix pinctrl for GPIO hogs
> * Patch 4: Fix property order in i2c2 node
> * Patch 4: Use generic node name for touchscreen
> 
> Frieder Schrempf (4):
>   dt-bindings: vendor-prefixes: Add Jenson Display
>   dt-bindings: display: panel-lvds: Add compatible for Jenson
>     BL-JT60050-01A
>   arm64: dts: imx8mm-kontron: Add support for display bridges on BL
>     i.MX8MM
>   arm64: dts: imx8mm-kontron: Add DL (Display-Line) overlay with LVDS
>     support

Gentle ping for this series. Neil proposed to apply path 1 and 2 to
drm-misc-next. Shawn, can you review/apply patch 3 and 4, please?

Thanks
Frieder
Shawn Guo Oct. 8, 2024, 9:04 a.m. UTC | #2 
On Tue, Oct 08, 2024 at 09:21:05AM +0200, Frieder Schrempf wrote:
> On 28.08.24 9:46 AM, Frieder Schrempf wrote:
> > From: Frieder Schrempf <frieder.schrempf@kontron.de>
> > 
> > This add support for the display bridges (DSI->LVDS and DSI->HDMI)
> > on the BL i.MX8MM and the 7" LVDS panel in a separate overlay.
> > 
> > Only one of the interfaces (HDMI or LVDS) is supported at the same
> > time. Enabling the LVDS overlay will disable the HDMI interface.
> > 
> > * Patch 1 and 2: Add the necessary binding changes
> > * Patch 3: Extend the BL devicetree
> > * Patch 4: Add the LVDS panel overlay
> > 
> > Changes for v2:
> > * Patch 1: Add link to commit message
> > * Patch 2: Add Conors A-b tag
> > * Patch 3: Remove blank lines from hdmi node
> > * Patch 3: Fix order of lvds and hdmi nodes within i2c
> > * Patch 3: Remove the unneeded deletion of samsung,pll-clock-frequency
> > * Patch 3: Use the existing MIPI DSI output port from imx8mm.dtsi
> > * Patch 4: Update copyright year
> > * Patch 4: Use exisitng MIPI DSI output port from imx8mm.dtsi
> > * Patch 4: Fix pinctrl for GPIO hogs
> > * Patch 4: Fix property order in i2c2 node
> > * Patch 4: Use generic node name for touchscreen
> > 
> > Frieder Schrempf (4):
> >   dt-bindings: vendor-prefixes: Add Jenson Display
> >   dt-bindings: display: panel-lvds: Add compatible for Jenson
> >     BL-JT60050-01A
> >   arm64: dts: imx8mm-kontron: Add support for display bridges on BL
> >     i.MX8MM
> >   arm64: dts: imx8mm-kontron: Add DL (Display-Line) overlay with LVDS
> >     support
> 
> Gentle ping for this series. Neil proposed to apply path 1 and 2 to
> drm-misc-next. Shawn, can you review/apply patch 3 and 4, please?

I'm getting this:

  OVL     arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtb
Failed to apply 'arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtbo': FDT_ERR_NOTFOUND
make[4]: *** [../scripts/Makefile.dtbs:83: arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtb] Error 1

Shawn
Frieder Schrempf Oct. 8, 2024, 2:40 p.m. UTC | #3 
On 08.10.24 11:04 AM, Shawn Guo wrote:
> On Tue, Oct 08, 2024 at 09:21:05AM +0200, Frieder Schrempf wrote:
>> On 28.08.24 9:46 AM, Frieder Schrempf wrote:
>>> From: Frieder Schrempf <frieder.schrempf@kontron.de>
>>>
>>> This add support for the display bridges (DSI->LVDS and DSI->HDMI)
>>> on the BL i.MX8MM and the 7" LVDS panel in a separate overlay.
>>>
>>> Only one of the interfaces (HDMI or LVDS) is supported at the same
>>> time. Enabling the LVDS overlay will disable the HDMI interface.
>>>
>>> * Patch 1 and 2: Add the necessary binding changes
>>> * Patch 3: Extend the BL devicetree
>>> * Patch 4: Add the LVDS panel overlay
>>>
>>> Changes for v2:
>>> * Patch 1: Add link to commit message
>>> * Patch 2: Add Conors A-b tag
>>> * Patch 3: Remove blank lines from hdmi node
>>> * Patch 3: Fix order of lvds and hdmi nodes within i2c
>>> * Patch 3: Remove the unneeded deletion of samsung,pll-clock-frequency
>>> * Patch 3: Use the existing MIPI DSI output port from imx8mm.dtsi
>>> * Patch 4: Update copyright year
>>> * Patch 4: Use exisitng MIPI DSI output port from imx8mm.dtsi
>>> * Patch 4: Fix pinctrl for GPIO hogs
>>> * Patch 4: Fix property order in i2c2 node
>>> * Patch 4: Use generic node name for touchscreen
>>>
>>> Frieder Schrempf (4):
>>>   dt-bindings: vendor-prefixes: Add Jenson Display
>>>   dt-bindings: display: panel-lvds: Add compatible for Jenson
>>>     BL-JT60050-01A
>>>   arm64: dts: imx8mm-kontron: Add support for display bridges on BL
>>>     i.MX8MM
>>>   arm64: dts: imx8mm-kontron: Add DL (Display-Line) overlay with LVDS
>>>     support
>>
>> Gentle ping for this series. Neil proposed to apply path 1 and 2 to
>> drm-misc-next. Shawn, can you review/apply patch 3 and 4, please?
> 
> I'm getting this:
> 
>   OVL     arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtb
> Failed to apply 'arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtbo': FDT_ERR_NOTFOUND
> make[4]: *** [../scripts/Makefile.dtbs:83: arch/arm64/boot/dts/freescale/imx8mm-kontron-dl.dtb] Error 1

Thanks for noticing. It seems like I missed to commit something before
preparing the patches. I just sent out a v3 that is fixed.
Neil Armstrong Oct. 9, 2024, 7:55 a.m. UTC | #4 
Hi,

On Wed, 28 Aug 2024 09:46:52 +0200, Frieder Schrempf wrote:
> From: Frieder Schrempf <frieder.schrempf@kontron.de>
> 
> This add support for the display bridges (DSI->LVDS and DSI->HDMI)
> on the BL i.MX8MM and the 7" LVDS panel in a separate overlay.
> 
> Only one of the interfaces (HDMI or LVDS) is supported at the same
> time. Enabling the LVDS overlay will disable the HDMI interface.
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/4] dt-bindings: vendor-prefixes: Add Jenson Display
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/763dc2cdeb2ac5a5067972b614f9f0603f716f9b
[2/4] dt-bindings: display: panel-lvds: Add compatible for Jenson BL-JT60050-01A
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/15bda06bc93fca828e5f11ca6b773fed19e45b8e