mbox series

[net-next,0/7] ipv4: Convert __fib_validate_source() and its callers to dscp_t.

Message ID cover.1728302212.git.gnault@redhat.com (mailing list archive)
Headers show
Series ipv4: Convert __fib_validate_source() and its callers to dscp_t. | expand

Message

Guillaume Nault Oct. 7, 2024, 6:24 p.m. UTC
This patch series continues to prepare users of ->flowi4_tos to a
future conversion of this field (__u8 to dscp_t). This time, we convert
__fib_validate_source() and its call chain.

The objective is to eventually make all users of ->flowi4_tos use a
dscp_t value. Making ->flowi4_tos a dscp_t field will help avoiding
regressions where ECN bits are erroneously interpreted as DSCP bits.

Guillaume Nault (7):
  ipv4: Convert ip_route_use_hint() to dscp_t.
  ipv4: Convert ip_mkroute_input() to dscp_t.
  ipv4: Convert __mkroute_input() to dscp_t.
  ipv4: Convert ip_route_input_mc() to dscp_t.
  ipv4: Convert ip_mc_validate_source() to dscp_t.
  ipv4: Convert fib_validate_source() to dscp_t.
  ipv4: Convert __fib_validate_source() to dscp_t.

 include/net/ip_fib.h    |  3 ++-
 include/net/route.h     |  7 +++---
 net/ipv4/fib_frontend.c |  9 +++----
 net/ipv4/ip_input.c     |  4 ++--
 net/ipv4/route.c        | 52 ++++++++++++++++++-----------------------
 net/ipv4/udp.c          |  4 ++--
 6 files changed, 38 insertions(+), 41 deletions(-)

Comments

Ido Schimmel Oct. 8, 2024, 8:37 a.m. UTC | #1
On Mon, Oct 07, 2024 at 08:24:23PM +0200, Guillaume Nault wrote:
> This patch series continues to prepare users of ->flowi4_tos to a
> future conversion of this field (__u8 to dscp_t). This time, we convert
> __fib_validate_source() and its call chain.
> 
> The objective is to eventually make all users of ->flowi4_tos use a
> dscp_t value. Making ->flowi4_tos a dscp_t field will help avoiding
> regressions where ECN bits are erroneously interpreted as DSCP bits.

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Tested-by: Ido Schimmel <idosch@nvidia.com>
David Ahern Oct. 8, 2024, 2:50 p.m. UTC | #2
On 10/7/24 12:24 PM, Guillaume Nault wrote:
> This patch series continues to prepare users of ->flowi4_tos to a
> future conversion of this field (__u8 to dscp_t). This time, we convert
> __fib_validate_source() and its call chain.
> 
> The objective is to eventually make all users of ->flowi4_tos use a
> dscp_t value. Making ->flowi4_tos a dscp_t field will help avoiding
> regressions where ECN bits are erroneously interpreted as DSCP bits.
> 
> Guillaume Nault (7):
>   ipv4: Convert ip_route_use_hint() to dscp_t.
>   ipv4: Convert ip_mkroute_input() to dscp_t.
>   ipv4: Convert __mkroute_input() to dscp_t.
>   ipv4: Convert ip_route_input_mc() to dscp_t.
>   ipv4: Convert ip_mc_validate_source() to dscp_t.
>   ipv4: Convert fib_validate_source() to dscp_t.
>   ipv4: Convert __fib_validate_source() to dscp_t.
> 
>  include/net/ip_fib.h    |  3 ++-
>  include/net/route.h     |  7 +++---
>  net/ipv4/fib_frontend.c |  9 +++----
>  net/ipv4/ip_input.c     |  4 ++--
>  net/ipv4/route.c        | 52 ++++++++++++++++++-----------------------
>  net/ipv4/udp.c          |  4 ++--
>  6 files changed, 38 insertions(+), 41 deletions(-)
> 

Reviewed-by: David Ahern <dsahern@kernel.org>
patchwork-bot+netdevbpf@kernel.org Oct. 10, 2024, 12:40 a.m. UTC | #3
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 7 Oct 2024 20:24:23 +0200 you wrote:
> This patch series continues to prepare users of ->flowi4_tos to a
> future conversion of this field (__u8 to dscp_t). This time, we convert
> __fib_validate_source() and its call chain.
> 
> The objective is to eventually make all users of ->flowi4_tos use a
> dscp_t value. Making ->flowi4_tos a dscp_t field will help avoiding
> regressions where ECN bits are erroneously interpreted as DSCP bits.
> 
> [...]

Here is the summary with links:
  - [net-next,1/7] ipv4: Convert ip_route_use_hint() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/2b78d30620d7
  - [net-next,2/7] ipv4: Convert ip_mkroute_input() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/34f28ffd62c1
  - [net-next,3/7] ipv4: Convert __mkroute_input() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/0936c671911f
  - [net-next,4/7] ipv4: Convert ip_route_input_mc() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/1a7c292617e4
  - [net-next,5/7] ipv4: Convert ip_mc_validate_source() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/d32976408744
  - [net-next,6/7] ipv4: Convert fib_validate_source() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/d36236ab5275
  - [net-next,7/7] ipv4: Convert __fib_validate_source() to dscp_t.
    https://git.kernel.org/netdev/net-next/c/3768b402735e

You are awesome, thank you!