diff mbox series

[7/8] arm64: dts: rockchip: Remove undocumented emmc property from PX30-Ringneck

Message ID 20240930210112.1993625-8-heiko@sntech.de (mailing list archive)
State New
Headers show
Series Fixing some dtbscheck warnings | expand

Commit Message

Heiko Stübner Sept. 30, 2024, 9:01 p.m. UTC
supports-emmc is an undocumented property that slipped into the mainline
kernel devicetree for the board. Drop it.

Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
---
 arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Quentin Schulz Oct. 1, 2024, 10:04 a.m. UTC | #1
Hi Heiko,

On 9/30/24 11:01 PM, Heiko Stuebner wrote:
> supports-emmc is an undocumented property that slipped into the mainline
> kernel devicetree for the board. Drop it.
> 
> Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
> Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>

Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>

FYI:

$ git grep supports-emmc arch/arm64/boot/dts/rockchip
arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi:        supports-emmc;
arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts: 
supports-emmc;
arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts:        supports-emmc;
arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts:        supports-emmc;

So there's a few more to remove it seems :)

Thanks!
Quentin
Heiko Stübner Oct. 8, 2024, 8:29 p.m. UTC | #2
Am Dienstag, 1. Oktober 2024, 12:04:00 CEST schrieb Quentin Schulz:
> Hi Heiko,
> 
> On 9/30/24 11:01 PM, Heiko Stuebner wrote:
> > supports-emmc is an undocumented property that slipped into the mainline
> > kernel devicetree for the board. Drop it.
> > 
> > Fixes: c484cf93f61b ("arm64: dts: rockchip: add PX30-µQ7 (Ringneck) SoM with Haikou baseboard")
> > Cc: Quentin Schulz <quentin.schulz@theobroma-systems.com>
> > Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> 
> Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
> 
> FYI:
> 
> $ git grep supports-emmc arch/arm64/boot/dts/rockchip
> arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi:        supports-emmc;
> arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts: 
> supports-emmc;
> arch/arm64/boot/dts/rockchip/rk3566-lubancat-1.dts:        supports-emmc;
> arch/arm64/boot/dts/rockchip/rk3568-lubancat-2.dts:        supports-emmc;
> 
> So there's a few more to remove it seems :)

I've now amended the patch to remove all of them :-)
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
index bb1aea82e666..b7163ed74232 100644
--- a/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
+++ b/arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi
@@ -66,7 +66,6 @@  &emmc {
 	bus-width = <8>;
 	cap-mmc-highspeed;
 	mmc-hs200-1_8v;
-	supports-emmc;
 	mmc-pwrseq = <&emmc_pwrseq>;
 	non-removable;
 	vmmc-supply = <&vcc_3v3>;