| Message ID | 20241008203940.2573684-2-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fixing some dtbscheck warnings | expand |
Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > We want to control pins, not beer mugs, so rename pintctrl-names to the > expected inctrl-names. s/inctrl-names/pinctrl-names/ > This was not affecting functionality, because the i2c2 controller > already had a set of pinctrl properties. > > Fixes: 523adb553573 ("arm64: dts: rockchip: add Anbernic RG353P and > RG503") > Fixes: 1e141cf12726 ("arm64: dts: rockchip: add Anbernic RG353V and > RG353VS") > Cc: Chris Morgan <macromorgan@hotmail.com> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > Acked-by: Chris Morgan <macromorgan@hotmail.com> Looking good to me, thanks for the patch. It's obviously correct. Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +- > arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts > b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts > index a73cf30801ec..9816a4ed4599 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts > @@ -92,7 +92,7 @@ button-r2 { > }; > > &i2c2 { > - pintctrl-names = "default"; > + pinctrl-names = "default"; > pinctrl-0 = <&i2c2m1_xfer>; > status = "okay"; > > diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts > b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts > index e9954a33e8cd..a79a5614bcc8 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts > @@ -79,7 +79,7 @@ button-r2 { > }; > > &i2c2 { > - pintctrl-names = "default"; > + pinctrl-names = "default"; > pinctrl-0 = <&i2c2m1_xfer>; > status = "okay";
diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts index a73cf30801ec..9816a4ed4599 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts @@ -92,7 +92,7 @@ button-r2 { }; &i2c2 { - pintctrl-names = "default"; + pinctrl-names = "default"; pinctrl-0 = <&i2c2m1_xfer>; status = "okay"; diff --git a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts index e9954a33e8cd..a79a5614bcc8 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts @@ -79,7 +79,7 @@ button-r2 { }; &i2c2 { - pintctrl-names = "default"; + pinctrl-names = "default"; pinctrl-0 = <&i2c2m1_xfer>; status = "okay";
We want to control pins, not beer mugs, so rename pintctrl-names to the expected inctrl-names. This was not affecting functionality, because the i2c2 controller already had a set of pinctrl properties. Fixes: 523adb553573 ("arm64: dts: rockchip: add Anbernic RG353P and RG503") Fixes: 1e141cf12726 ("arm64: dts: rockchip: add Anbernic RG353V and RG353VS") Cc: Chris Morgan <macromorgan@hotmail.com> Signed-off-by: Heiko Stuebner <heiko@sntech.de> Acked-by: Chris Morgan <macromorgan@hotmail.com> --- arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353p.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3566-anbernic-rg353v.dts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)