| Message ID | 20241007235711.5714-1-rosenp@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 08c8acc9d8f3f70d62dd928571368d5018206490 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ibm: emac: mal: fix wrong goto | expand |
> dcr_map is called in the previous if and therefore needs to be unmapped.
How do you think about to choose an additional imperative wording
for an improved change description?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc2#n94
Regards,
Markus
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 7 Oct 2024 16:57:11 -0700 you wrote: > dcr_map is called in the previous if and therefore needs to be unmapped. > > Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling") > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > --- > drivers/net/ethernet/ibm/emac/mal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [net] net: ibm: emac: mal: fix wrong goto https://git.kernel.org/netdev/net/c/08c8acc9d8f3 You are awesome, thank you!
diff --git a/drivers/net/ethernet/ibm/emac/mal.c b/drivers/net/ethernet/ibm/emac/mal.c index d92dd9c83031..0c5e22d14372 100644 --- a/drivers/net/ethernet/ibm/emac/mal.c +++ b/drivers/net/ethernet/ibm/emac/mal.c @@ -578,7 +578,7 @@ static int mal_probe(struct platform_device *ofdev) printk(KERN_ERR "%pOF: Support for 405EZ not enabled!\n", ofdev->dev.of_node); err = -ENODEV; - goto fail; + goto fail_unmap; #endif }
dcr_map is called in the previous if and therefore needs to be unmapped. Fixes: 1ff0fcfcb1a6 ("ibm_newemac: Fix new MAL feature handling") Signed-off-by: Rosen Penev <rosenp@gmail.com> --- drivers/net/ethernet/ibm/emac/mal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)