| Message ID | 20241008203940.2573684-9-heiko@sntech.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Fixing some dtbscheck warnings | expand |
Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > num-slots was not part of the dw-mmc binding and the last slipage of > one of them seeping in from the vendor kernel was removed way back in > 2017. Somehow the nanopi-r2s-plus managed to smuggle another on in the > kernel, so remove that as well. > > Fixes: b8c028782922 ("arm64: dts: rockchip: Add DTS for FriendlyARM > NanoPi R2S Plus") > Cc: Sergey Bostandzhyan <jin@mediatomb.cc> > Signed-off-by: Heiko Stuebner <heiko@sntech.de> Looking good to me, thanks for the patch. The introduced change is obviously correct. Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > index 3093f607f282..4b9ced67742d 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > @@ -24,7 +24,6 @@ &emmc { > disable-wp; > mmc-hs200-1_8v; > non-removable; > - num-slots = <1>; > pinctrl-names = "default"; > pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>; > status = "okay";
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts index 3093f607f282..4b9ced67742d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts @@ -24,7 +24,6 @@ &emmc { disable-wp; mmc-hs200-1_8v; non-removable; - num-slots = <1>; pinctrl-names = "default"; pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>; status = "okay";
num-slots was not part of the dw-mmc binding and the last slipage of one of them seeping in from the vendor kernel was removed way back in 2017. Somehow the nanopi-r2s-plus managed to smuggle another on in the kernel, so remove that as well. Fixes: b8c028782922 ("arm64: dts: rockchip: Add DTS for FriendlyARM NanoPi R2S Plus") Cc: Sergey Bostandzhyan <jin@mediatomb.cc> Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts | 1 - 1 file changed, 1 deletion(-)