mbox series

[0/3] drm/vc4: 3 minor fixes from mismatched drm_dev_[enter|exit] calls

Message ID 20241008-drm-vc4-fixes-v1-0-9d0396ca9f42@raspberrypi.com (mailing list archive)
Headers show
Series drm/vc4: 3 minor fixes from mismatched drm_dev_[enter|exit] calls | expand

Message

Dave Stevenson Oct. 8, 2024, 4:44 p.m. UTC
These are 3 fixes noted from Marek's report that he was seeing lock
held issues.
The place he had noticed was actually triggered due to an incorrect
change to a conditional, but also a further place was noted where
it was possible to leave the function without calling drm_dev_exit.

Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
---
Dave Stevenson (3):
      drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_lut_load
      drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_atomic_flush
      drm/vc4: Correct generation check in vc4_hvs_lut_load

 drivers/gpu/drm/vc4/vc4_hvs.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
---
base-commit: 2c34a5464007c45142af009d13c668b0630ef9c0
change-id: 20241008-drm-vc4-fixes-4aceb259455c

Best regards,

Comments

Dave Stevenson Oct. 9, 2024, 12:15 p.m. UTC | #1
On Tue, 8 Oct 2024 at 17:44, Dave Stevenson
<dave.stevenson@raspberrypi.com> wrote:
>
> These are 3 fixes noted from Marek's report that he was seeing lock
> held issues.
> The place he had noticed was actually triggered due to an incorrect
> change to a conditional, but also a further place was noted where
> it was possible to leave the function without calling drm_dev_exit.
>
> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>

Applied to drm-misc-next.

> ---
> Dave Stevenson (3):
>       drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_lut_load
>       drm/vc4: Match drm_dev_enter and exit calls in vc4_hvs_atomic_flush
>       drm/vc4: Correct generation check in vc4_hvs_lut_load
>
>  drivers/gpu/drm/vc4/vc4_hvs.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> ---
> base-commit: 2c34a5464007c45142af009d13c668b0630ef9c0
> change-id: 20241008-drm-vc4-fixes-4aceb259455c
>
> Best regards,
> --
> Dave Stevenson <dave.stevenson@raspberrypi.com>
>