generic/746: install two necessary files

Commit Message

An Long Oct. 9, 2024, 8:45 a.m. UTC

parse-dev-tree.awk and parse-extent-tree.awk are used by generic/746.
We need to make sure them are installed, otherwise generic/746 will
have problems if fstests is installed via "make install".
---
 src/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 SUBDIRS = log-writes perf

Comments

Darrick J. Wong Oct. 9, 2024, 2:46 p.m. UTC | #1

On Wed, Oct 09, 2024 at 04:45:37PM +0800, An Long wrote:
> parse-dev-tree.awk and parse-extent-tree.awk are used by generic/746.
> We need to make sure them are installed, otherwise generic/746 will
> have problems if fstests is installed via "make install".
> ---
>  src/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/Makefile b/src/Makefile
> index 3097c29e..a0396332 100644
> --- a/src/Makefile
> +++ b/src/Makefile
> @@ -38,7 +38,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize
> preallo_rw_pattern_reader \
> 
>  EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \
>               btrfs_crc32c_forged_name.py popdir.pl popattr.py \
> -             soak_duration.awk
> +             soak_duration.awk parse-dev-tree.awk parse-extent-
> tree.awk

^^ I think this is a broken line wrapping here, but otherwise the change
seems sensible.

With that fixed,
Reviewed-by: Darrick J. Wong <[e-mail]>

--D

> 
>  SUBDIRS = log-writes perf
> 
> -- 
> 2.43.0
> 
>

An Long Oct. 9, 2024, 3:57 p.m. UTC | #2

On Wed, 2024-10-09 at 07:46 -0700, Darrick J. Wong wrote:
> On Wed, Oct 09, 2024 at 04:45:37PM +0800, An Long wrote:
> > parse-dev-tree.awk and parse-extent-tree.awk are used by
> > generic/746.
> > We need to make sure them are installed, otherwise generic/746 will
> > have problems if fstests is installed via "make install".
> > ---
> >  src/Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/Makefile b/src/Makefile
> > index 3097c29e..a0396332 100644
> > --- a/src/Makefile
> > +++ b/src/Makefile
> > @@ -38,7 +38,7 @@ LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize
> > preallo_rw_pattern_reader \
> > 
> >  EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh
> > \
> >               btrfs_crc32c_forged_name.py popdir.pl popattr.py \
> > -             soak_duration.awk
> > +             soak_duration.awk parse-dev-tree.awk parse-extent-
> > tree.awk
> 
> ^^ I think this is a broken line wrapping here, but otherwise the
> change
> seems sensible.
> 
> With that fixed,
> Reviewed-by: Darrick J. Wong <[e-mail]>
Thanks your comments! I've sent a v2 patch without wrapping.
> 
> --D
> 
> > 
> >  SUBDIRS = log-writes perf
> > 
> > -- 
> > 2.43.0
> > 
> >

Patch

diff --git a/src/Makefile b/src/Makefile
index 3097c29e..a0396332 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -38,7 +38,7 @@  LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize
preallo_rw_pattern_reader \

 EXTRA_EXECS = dmerror fill2attr fill2fs fill2fs_check scaleread.sh \
              btrfs_crc32c_forged_name.py popdir.pl popattr.py \
-             soak_duration.awk
+             soak_duration.awk parse-dev-tree.awk parse-extent-
tree.awk