| Message ID | 20241008220137.274660-1-alessandro.zanni87@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | selftests: drivers: net: fix name not defined | expand |
On Wed, 9 Oct 2024 00:01:33 +0200 Alessandro Zanni wrote: > This fix solves this error, when calling kselftest with targets "drivers/net": > > File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__ > if e.errno == errno.ENOSPC: > NameError: name 'errno' is not defined > > The module errno makes available standard error system symbols. Can you say more about how you hit this error? If it's just based on static analysis please mention that in the commit message, and also mention that the problem doesn't happen in practice. This will avoid the patch being backported unnecessarily. We run all the tests in our CI, and the problem is not hit. But I agree with you that the import is theoretically missing.
Alessandro Zanni <alessandro.zanni87@gmail.com> writes: > This fix solves this error, when calling kselftest with targets "drivers/net": > > File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__ > if e.errno == errno.ENOSPC: > NameError: name 'errno' is not defined > > The module errno makes available standard error system symbols. > > Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com> Reviewed-by: Petr Machata <petrm@nvidia.com> Insert a yo-dawg meme about testing the tests here.
On 24/10/09 07:32, Jakub Kicinski wrote: > On Wed, 9 Oct 2024 00:01:33 +0200 Alessandro Zanni wrote: > > This fix solves this error, when calling kselftest with targets "drivers/net": > > > > File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__ > > if e.errno == errno.ENOSPC: > > NameError: name 'errno' is not defined > > > > The module errno makes available standard error system symbols. > > Can you say more about how you hit this error? > > If it's just based on static analysis please mention that in the commit > message, and also mention that the problem doesn't happen in practice. > This will avoid the patch being backported unnecessarily. I didn't use static analysis tool. I've run the test manually. I got the error from executing: make --silent kselftest TARGETS="drivers/net" Thanks for pointing out, I'll prepare a v2 patch with the command used. > We run all the tests in our CI, and the problem is not hit. But I agree > with you that the import is theoretically missing. When I ran the test, the function ctrl_write() raised an OSError. So, in my case, it was also a practical error. > -- > pw-bot: cr
diff --git a/tools/testing/selftests/net/lib/py/nsim.py b/tools/testing/selftests/net/lib/py/nsim.py index f571a8b3139b..1a8cbe9acc48 100644 --- a/tools/testing/selftests/net/lib/py/nsim.py +++ b/tools/testing/selftests/net/lib/py/nsim.py @@ -1,5 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 +import errno import json import os import random
This fix solves this error, when calling kselftest with targets "drivers/net": File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__ if e.errno == errno.ENOSPC: NameError: name 'errno' is not defined The module errno makes available standard error system symbols. Signed-off-by: Alessandro Zanni <alessandro.zanni87@gmail.com> --- tools/testing/selftests/net/lib/py/nsim.py | 1 + 1 file changed, 1 insertion(+)