mbox series

[v3,0/9] ASoC: Some issues about loongson i2s

Message ID cover.1728459624.git.zhoubinbin@loongson.cn (mailing list archive)
Headers show
Series ASoC: Some issues about loongson i2s | expand

Message

周彬彬 Oct. 9, 2024, 7:51 a.m. UTC
Hi all:

This patch set is mainly about Loongson i2s related issues.

Please allow me to briefly explain this patch set:
Patch 1-2: Add ES8323 codec required on Loongson-2K2000
Patch 3-4: Add uda1342 codec required on Loongson-2K1000
Patch 5: Fix the problem of unable to detect codec under FDT system.
Patch 6-7: Add Loongson i2s platform device support
Patch 8-9: Related DTS support.

Thanks.

-------
V3:
patch (1/9)/(6/9):
 - Add Reviewed-by tag from Rob;

patch (2/9):
 - Use C++ style for the comment block at the head of file;
 - Add DAI format config accroding datasheet.

patch (4/9):
 - Use C++ style for the comment block at the head of file;
 - Drop some noisy log message(dev_info);
 - Drop unused variable reported by lkp.

patch (5/9):
 - Reuse snd_soc_of_get_dlc() helper function;
 - Set the value of snd_soc_dai_link.platforms to avoid check failed.

patch (7/9):
 - Use C++ style for the comment block at the head of file;
 - Rewrite the dependency between the card and the DAI driver, we will
   select from the card to the DAI driver;

Link to V2:
https://lore.kernel.org/all/cover.1727056789.git.zhoubinbin@loongson.cn/

V2:
- Spilt the improve code readability patch to a separate patch series.
  The link is:
  https://lore.kernel.org/all/cover.1725844530.git.zhoubinbin@loongson.cn/

patch (1/9):
 - Add es8323 compatible in everest,es8316.yaml instead of creating a
   new yaml file;

patch (2/9):
 - Use regmap_config.reg_defaults instead of snd_soc_component_driver.{read/write};
 - Use the more modern _CBC_CFC(SND_SOC_DAIFMT_BC_FC);
 - Rewrite suspend/resume function with regmap;
 - Drop i2c_check_functionality();
 - Use named variables for the enums rather than putting them into an array;

patch (3/9):
 - Add Reviewed-by tag from Krzysztof;

patch (4/9):
 - Drop unused param to avoid lkp warnning;
 - Drop some noisy log message(dev_info);
 - Use normal conditional statements to improve legibility;
 - Use provider/consumer instead of master/slave;
 - Use the more modern _CBC_CFC(SND_SOC_DAIFMT_BC_FC);
 - Drop uda1342_set_bias_level() for it does nothing;
 - Drop uda1342_mixer_enum[] for it is unused;
 - Point to controls/routes arrays from the component struct;
 - REGCACHE_MAP instead of REGCACHE_RBTREE.

patch (5/9):
 - Add of_node_put(args.np) after snd_soc_get_dai_name();
 - Use matching label name, such as codec_put instead of free_codec;
 - Rewrote the loongson_parse_cpu() and loongson_parse_codec() function
   interfaces to avoid dropping a reference from a pointer that is a
   random stack value

patch (6/9):
 - Rename file name as loongson,ls2k1000-i2s.yaml;
 - List and describe items for reg property;
 - 'unevaluatedProperties: false' instead of 'additionalProperties:
   false';

patch (7/9):
 - Fix lkp warnning;
 - Reorder Kconfig items, let
SND_SOC_LOONGSON_I2S_{PCI,PLATFORM} select SND_SOC_LOONGSON_CARD.

Link to v1:
https://lore.kernel.org/all/cover.1725518229.git.zhoubinbin@loongson.cn/

Binbin Zhou (9):
  ASoC: dt-bindings: Add Everest ES8323 Codec
  ASoC: codecs: Add support for ES8323
  ASoC: dt-bindings: Add NXP uda1342 Codec
  ASoC: codecs: Add uda1342 codec driver
  ASoC: loongson: Fix component check failed on FDT systems
  ASoC: dt-bindings: Add Loongson I2S controller
  ASoC: loongson: Add I2S controller driver as platform device
  LoongArch: dts: Add I2S support to Loongson-2K1000
  LoongArch: dts: Add I2S support to Loongson-2K2000

 .../bindings/sound/everest,es8316.yaml        |   4 +-
 .../bindings/sound/loongson,ls2k1000-i2s.yaml |  68 ++
 .../bindings/sound/nxp,uda1342.yaml           |  42 +
 arch/loongarch/boot/dts/loongson-2k1000.dtsi  |  17 +-
 arch/loongarch/boot/dts/loongson-2k2000.dtsi  |  22 +-
 sound/soc/codecs/Kconfig                      |  13 +
 sound/soc/codecs/Makefile                     |   4 +
 sound/soc/codecs/es8323.c                     | 792 ++++++++++++++++++
 sound/soc/codecs/es8323.h                     |  78 ++
 sound/soc/codecs/uda1342.c                    | 347 ++++++++
 sound/soc/codecs/uda1342.h                    |  78 ++
 sound/soc/loongson/Kconfig                    |  31 +-
 sound/soc/loongson/Makefile                   |   3 +
 sound/soc/loongson/loongson_card.c            |   1 +
 sound/soc/loongson/loongson_i2s_plat.c        | 185 ++++
 15 files changed, 1670 insertions(+), 15 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/sound/loongson,ls2k1000-i2s.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/nxp,uda1342.yaml
 create mode 100644 sound/soc/codecs/es8323.c
 create mode 100644 sound/soc/codecs/es8323.h
 create mode 100644 sound/soc/codecs/uda1342.c
 create mode 100644 sound/soc/codecs/uda1342.h
 create mode 100644 sound/soc/loongson/loongson_i2s_plat.c


base-commit: d19f6bf5f17d77fb645654237130c94571c68a3d

Comments

Mark Brown Oct. 10, 2024, 11:14 a.m. UTC | #1
On Wed, 09 Oct 2024 15:51:42 +0800, Binbin Zhou wrote:
> This patch set is mainly about Loongson i2s related issues.
> 
> Please allow me to briefly explain this patch set:
> Patch 1-2: Add ES8323 codec required on Loongson-2K2000
> Patch 3-4: Add uda1342 codec required on Loongson-2K1000
> Patch 5: Fix the problem of unable to detect codec under FDT system.
> Patch 6-7: Add Loongson i2s platform device support
> Patch 8-9: Related DTS support.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/9] ASoC: dt-bindings: Add Everest ES8323 Codec
      commit: 5bf2bea8a8b3d0255953868c7bf652235a17a65d
[2/9] ASoC: codecs: Add support for ES8323
      commit: b97391a604b9e259c6a983fc1b715d205d9da505
[3/9] ASoC: dt-bindings: Add NXP uda1342 Codec
      commit: de567431596a8163a9441407fdab315f12bc2769
[4/9] ASoC: codecs: Add uda1342 codec driver
      commit: de0fb25e37aae7aae133d6c3d0b0e1e31a79878d
[5/9] ASoC: loongson: Fix component check failed on FDT systems
      (no commit info)
[6/9] ASoC: dt-bindings: Add Loongson I2S controller
      commit: d4c2e9e33a0c903cc3a00114d6c02aa2cf403d33
[7/9] ASoC: loongson: Add I2S controller driver as platform device
      commit: ba4c5fad598c07492844e514add3ccda467063b2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Binbin Zhou Oct. 10, 2024, 12:15 p.m. UTC | #2
Hi Mark:

On Thu, Oct 10, 2024 at 5:14 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Wed, 09 Oct 2024 15:51:42 +0800, Binbin Zhou wrote:
> > This patch set is mainly about Loongson i2s related issues.
> >
> > Please allow me to briefly explain this patch set:
> > Patch 1-2: Add ES8323 codec required on Loongson-2K2000
> > Patch 3-4: Add uda1342 codec required on Loongson-2K1000
> > Patch 5: Fix the problem of unable to detect codec under FDT system.
> > Patch 6-7: Add Loongson i2s platform device support
> > Patch 8-9: Related DTS support.
> >
> > [...]
>
> Applied to
>
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>
> Thanks!
>
> [1/9] ASoC: dt-bindings: Add Everest ES8323 Codec
>       commit: 5bf2bea8a8b3d0255953868c7bf652235a17a65d
> [2/9] ASoC: codecs: Add support for ES8323
>       commit: b97391a604b9e259c6a983fc1b715d205d9da505
> [3/9] ASoC: dt-bindings: Add NXP uda1342 Codec
>       commit: de567431596a8163a9441407fdab315f12bc2769
> [4/9] ASoC: codecs: Add uda1342 codec driver
>       commit: de0fb25e37aae7aae133d6c3d0b0e1e31a79878d
> [5/9] ASoC: loongson: Fix component check failed on FDT systems
>       (no commit info)

Thanks for applying this patchset.

But I don't seem to see the 5th patch in the for-next branch, what
other questions do you have about that patch?
On FDT systems we need this patch, otherwise the component check will fail.

Thanks.
Binbin
> [6/9] ASoC: dt-bindings: Add Loongson I2S controller
>       commit: d4c2e9e33a0c903cc3a00114d6c02aa2cf403d33
> [7/9] ASoC: loongson: Add I2S controller driver as platform device
>       commit: ba4c5fad598c07492844e514add3ccda467063b2
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
Mark Brown Oct. 10, 2024, 2:03 p.m. UTC | #3
On Thu, Oct 10, 2024 at 06:15:22PM +0600, Binbin Zhou wrote:
> On Thu, Oct 10, 2024 at 5:14 PM Mark Brown <broonie@kernel.org> wrote:

> > [5/9] ASoC: loongson: Fix component check failed on FDT systems
> >       (no commit info)

> Thanks for applying this patchset.

> But I don't seem to see the 5th patch in the for-next branch, what
> other questions do you have about that patch?
> On FDT systems we need this patch, otherwise the component check will fail.

That's a bugfix so is going as such.