| Message ID | 20241010092643.1048116-1-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/bridge: ite-it66121: Drop hdmi_avi_infoframe_init() function call | expand |
On Thu, Oct 10, 2024 at 05:26:43PM GMT, Liu Ying wrote: > drm_hdmi_avi_infoframe_from_display_mode() called from > it66121_bridge_mode_set() already calls hdmi_avi_infoframe_init() to > initialize an HDMI AVI infoframe. So, drop the redundant > hdmi_avi_infoframe_init() function call from it66121_bridge_mode_set(). > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > drivers/gpu/drm/bridge/ite-it66121.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Hi, On Thu, 10 Oct 2024 17:26:43 +0800, Liu Ying wrote: > drm_hdmi_avi_infoframe_from_display_mode() called from > it66121_bridge_mode_set() already calls hdmi_avi_infoframe_init() to > initialize an HDMI AVI infoframe. So, drop the redundant > hdmi_avi_infoframe_init() function call from it66121_bridge_mode_set(). > > Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next) [1/1] drm/bridge: ite-it66121: Drop hdmi_avi_infoframe_init() function call https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/c7671949791fb1142d0ae37343759d608a21bf28
diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index 925e42f46cd8..35ae3f0e8f51 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -770,8 +770,6 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge, mutex_lock(&ctx->lock); - hdmi_avi_infoframe_init(&ctx->hdmi_avi_infoframe); - ret = drm_hdmi_avi_infoframe_from_display_mode(&ctx->hdmi_avi_infoframe, ctx->connector, adjusted_mode); if (ret) {
drm_hdmi_avi_infoframe_from_display_mode() called from it66121_bridge_mode_set() already calls hdmi_avi_infoframe_init() to initialize an HDMI AVI infoframe. So, drop the redundant hdmi_avi_infoframe_init() function call from it66121_bridge_mode_set(). Signed-off-by: Liu Ying <victor.liu@nxp.com> --- drivers/gpu/drm/bridge/ite-it66121.c | 2 -- 1 file changed, 2 deletions(-)