| Message ID | 20241011100119.111399-1-wahrenst@gmx.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | staging: vc04_services: TESTING: Adjust ping test | expand |
Hi Stefan, Thank you for the patch On 11/10/24 3:31 pm, Stefan Wahren wrote: > Recent tests on Raspberry Pi 3 B Plus have shown that one > iteration is not enough to discover issues reliable. So > switch back to the defaults (1000 iterations). > > Link: https://lore.kernel.org/linux-staging/c7e302b6-fc62-4754-ab1d-7c2771cccf60@gmx.net/ > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> I've been using this for all my testing for recent patches. Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> > --- > drivers/staging/vc04_services/interface/TESTING | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/TESTING b/drivers/staging/vc04_services/interface/TESTING > index 273952dc9d85..c98f688b07e0 100644 > --- a/drivers/staging/vc04_services/interface/TESTING > +++ b/drivers/staging/vc04_services/interface/TESTING > @@ -52,10 +52,10 @@ Here are the most common kernel configurations: > > * Ping test > > - Command: vchiq_test -p 1 > + Command: vchiq_test -p > > Expected output: > - Ping test - service:echo, iters:1, version 3 > + Ping test - service:echo, iters:1000, version 3 > vchi ping (size 0) -> 57.000000us > vchi ping (size 0, 0 async, 0 oneway) -> 122.000000us > vchi bulk (size 0, 0 async, 0 oneway) -> 546.000000us > -- > 2.34.1 >
Am 11.10.24 um 12:02 schrieb Umang Jain: > Hi Stefan, > > Thank you for the patch > > On 11/10/24 3:31 pm, Stefan Wahren wrote: >> Recent tests on Raspberry Pi 3 B Plus have shown that one >> iteration is not enough to discover issues reliable. So >> switch back to the defaults (1000 iterations). >> >> Link: >> https://lore.kernel.org/linux-staging/c7e302b6-fc62-4754-ab1d-7c2771cccf60@gmx.net/ >> Signed-off-by: Stefan Wahren <wahrenst@gmx.net> > > I've been using this for all my testing for recent patches. Thanks, I still have the hope we are not the only one working on this driver :-D > > Reviewed-by: Umang Jain <umang.jain@ideasonboard.com> >> --- >> drivers/staging/vc04_services/interface/TESTING | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/vc04_services/interface/TESTING >> b/drivers/staging/vc04_services/interface/TESTING >> index 273952dc9d85..c98f688b07e0 100644 >> --- a/drivers/staging/vc04_services/interface/TESTING >> +++ b/drivers/staging/vc04_services/interface/TESTING >> @@ -52,10 +52,10 @@ Here are the most common kernel configurations: >> >> * Ping test >> >> - Command: vchiq_test -p 1 >> + Command: vchiq_test -p >> >> Expected output: >> - Ping test - service:echo, iters:1, version 3 >> + Ping test - service:echo, iters:1000, version 3 >> vchi ping (size 0) -> 57.000000us >> vchi ping (size 0, 0 async, 0 oneway) -> 122.000000us >> vchi bulk (size 0, 0 async, 0 oneway) -> 546.000000us >> -- >> 2.34.1 >> > >
diff --git a/drivers/staging/vc04_services/interface/TESTING b/drivers/staging/vc04_services/interface/TESTING index 273952dc9d85..c98f688b07e0 100644 --- a/drivers/staging/vc04_services/interface/TESTING +++ b/drivers/staging/vc04_services/interface/TESTING @@ -52,10 +52,10 @@ Here are the most common kernel configurations: * Ping test - Command: vchiq_test -p 1 + Command: vchiq_test -p Expected output: - Ping test - service:echo, iters:1, version 3 + Ping test - service:echo, iters:1000, version 3 vchi ping (size 0) -> 57.000000us vchi ping (size 0, 0 async, 0 oneway) -> 122.000000us vchi bulk (size 0, 0 async, 0 oneway) -> 546.000000us
Recent tests on Raspberry Pi 3 B Plus have shown that one iteration is not enough to discover issues reliable. So switch back to the defaults (1000 iterations). Link: https://lore.kernel.org/linux-staging/c7e302b6-fc62-4754-ab1d-7c2771cccf60@gmx.net/ Signed-off-by: Stefan Wahren <wahrenst@gmx.net> --- drivers/staging/vc04_services/interface/TESTING | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.34.1