| Message ID | 20241010073547.3720-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] ASoC: mediatek: mt8188: Remove unnecessary variable assignments | expand |
On Thu, Oct 10, 2024 at 03:35:47PM +0800, Tang Bin wrote: > In the function mtk_dai_hdmitx_dptx_hw_params, the variable > 'ret' is redundant, thus remove it. Please don't send patch serieses without cover letters, having a cover letter makes it easier to tell why the series is a series and makes it easier for tooling to work with the series.
I am sorry, it's my mistake. I know the rule, just mistake. From: Mark Brown Date: 2024-10-10 17:49 To: Tang Bin CC: lgirdwood; perex; tiwai; matthias.bgg; angelogioacchino.delregno; linux-sound; linux-kernel; linux-arm-kernel; linux-mediatek Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8188: Remove unnecessary variable assignments On Thu, Oct 10, 2024 at 03:35:47PM +0800, Tang Bin wrote: > In the function mtk_dai_hdmitx_dptx_hw_params, the variable > 'ret' is redundant, thus remove it. Please don't send patch serieses without cover letters, having a cover letter makes it easier to tell why the series is a series and makes it easier for tooling to work with the series.
On 10/10/24 09:35, Tang Bin wrote: > In the function mtk_dai_hdmitx_dptx_hw_params, the variable > 'ret' is redundant, thus remove it. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> > --- > sound/soc/mediatek/mt8188/mt8188-dai-etdm.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c > index 2a48f5fd6..69a091dad 100644 > --- a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c > +++ b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c > @@ -2422,7 +2422,6 @@ static int mtk_dai_hdmitx_dptx_hw_params(struct snd_pcm_substream *substream, > unsigned int channels = params_channels(params); > snd_pcm_format_t format = params_format(params); > int width = snd_pcm_format_physical_width(format); > - int ret; > > if (!is_valid_etdm_dai(dai->id)) > return -EINVAL; > @@ -2450,9 +2449,7 @@ static int mtk_dai_hdmitx_dptx_hw_params(struct snd_pcm_substream *substream, > etdm_data->data_mode = MTK_DAI_ETDM_DATA_MULTI_PIN; > } > > - ret = mtk_dai_etdm_configure(afe, rate, channels, width, dai->id); > - > - return ret; > + return mtk_dai_etdm_configure(afe, rate, channels, width, dai->id); > } > > static int mtk_dai_hdmitx_dptx_set_sysclk(struct snd_soc_dai *dai,
On 10/10/24 11:55, 唐彬 wrote: > I am sorry, it's my mistake. I know the rule, just mistake. > Please don't top most email but write the answer below the line you want to respond to. This will help others to better understand the context. Best regards, Matthias > > > > > > > From: Mark Brown > > > > Date: 2024-10-10 17:49 > > > > To: Tang Bin > > > > CC: lgirdwood; perex; tiwai; matthias.bgg; angelogioacchino.delregno; linux-sound; linux-kernel; linux-arm-kernel; linux-mediatek > > > > Subject: Re: [PATCH 1/2] ASoC: mediatek: mt8188: Remove unnecessary variable assignments > > > > On Thu, Oct 10, 2024 at 03:35:47PM +0800, Tang Bin wrote: > > > >> In the function mtk_dai_hdmitx_dptx_hw_params, the variable > > > >> 'ret' is redundant, thus remove it. > > > > > > > > Please don't send patch serieses without cover letters, having a cover > > > > letter makes it easier to tell why the series is a series and makes it > > > > easier for tooling to work with the series. > > >
On Thu, Oct 10, 2024 at 05:55:09PM +0800, 唐彬 wrote:
> I am sorry, it's my mistake. I know the rule, just mistake.
That's fine, could you confirm what the situation is with the second
patch - is there a dependency between the two?
On Thu, 10 Oct 2024 15:35:47 +0800, Tang Bin wrote: > In the function mtk_dai_hdmitx_dptx_hw_params, the variable > 'ret' is redundant, thus remove it. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: mediatek: mt8188: Remove unnecessary variable assignments commit: f5a0ea8936a640d8229d5219515141fc496ec5d8 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c index 2a48f5fd6..69a091dad 100644 --- a/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c +++ b/sound/soc/mediatek/mt8188/mt8188-dai-etdm.c @@ -2422,7 +2422,6 @@ static int mtk_dai_hdmitx_dptx_hw_params(struct snd_pcm_substream *substream, unsigned int channels = params_channels(params); snd_pcm_format_t format = params_format(params); int width = snd_pcm_format_physical_width(format); - int ret; if (!is_valid_etdm_dai(dai->id)) return -EINVAL; @@ -2450,9 +2449,7 @@ static int mtk_dai_hdmitx_dptx_hw_params(struct snd_pcm_substream *substream, etdm_data->data_mode = MTK_DAI_ETDM_DATA_MULTI_PIN; } - ret = mtk_dai_etdm_configure(afe, rate, channels, width, dai->id); - - return ret; + return mtk_dai_etdm_configure(afe, rate, channels, width, dai->id); } static int mtk_dai_hdmitx_dptx_set_sysclk(struct snd_soc_dai *dai,
In the function mtk_dai_hdmitx_dptx_hw_params, the variable 'ret' is redundant, thus remove it. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- sound/soc/mediatek/mt8188/mt8188-dai-etdm.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)