diff mbox series

[v1,03/13] iio: chemical: bme680: fix startup time

Message ID 20241010210030.33309-4-vassilisamir@gmail.com (mailing list archive)
State Changes Requested
Headers show
Series : chemical: bme680: 2nd set of clean and add | expand

Commit Message

Vasileios Amoiridis Oct. 10, 2024, 9 p.m. UTC 
From: Vasileios Amoiridis <vassilisamir@gmail.com>

According to datasheet's Section 1.1, Table 1, the startup time for the
device is 2ms and not 5ms.

Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com>
---
 drivers/iio/chemical/bme680.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Andy Shevchenko Oct. 11, 2024, 10 a.m. UTC | #1 
On Thu, Oct 10, 2024 at 11:00:20PM +0200, vamoirid wrote:
> From: Vasileios Amoiridis <vassilisamir@gmail.com>
> 
> According to datasheet's Section 1.1, Table 1, the startup time for the
> device is 2ms and not 5ms.

Fixes tag?
Vasileios Amoiridis Oct. 11, 2024, 6:51 p.m. UTC | #2 
On Fri, Oct 11, 2024 at 01:00:55PM +0300, Andy Shevchenko wrote:
> On Thu, Oct 10, 2024 at 11:00:20PM +0200, vamoirid wrote:
> > From: Vasileios Amoiridis <vassilisamir@gmail.com>
> > 
> > According to datasheet's Section 1.1, Table 1, the startup time for the
> > device is 2ms and not 5ms.
> 
> Fixes tag?
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>

Hi Andy,

It is not affecting at all the operation of the driver so I was not sure
if it was worth it to be backported to the previous versions. This is
why I didn't put a fixes tag. You think for such a fix is necessary?

Cheers,
Vasilis
Jonathan Cameron Oct. 12, 2024, 11:45 a.m. UTC | #3 
On Fri, 11 Oct 2024 20:51:41 +0200
Vasileios Aoiridis <vassilisamir@gmail.com> wrote:

> On Fri, Oct 11, 2024 at 01:00:55PM +0300, Andy Shevchenko wrote:
> > On Thu, Oct 10, 2024 at 11:00:20PM +0200, vamoirid wrote:  
> > > From: Vasileios Amoiridis <vassilisamir@gmail.com>
> > > 
> > > According to datasheet's Section 1.1, Table 1, the startup time for the
> > > device is 2ms and not 5ms.  
> > 
> > Fixes tag?
> > 
> > -- 
> > With Best Regards,
> > Andy Shevchenko
> > 
> >  
> 
> Hi Andy,
> 
> It is not affecting at all the operation of the driver so I was not sure
> if it was worth it to be backported to the previous versions. This is
> why I didn't put a fixes tag. You think for such a fix is necessary?
> 
Not for a reduction in sleep and not a huge one at that.
It's an optimization, not a fix to my eyes!

> Cheers,
> Vasilis
Andy Shevchenko Oct. 12, 2024, 8:36 p.m. UTC | #4 
Fri, Oct 11, 2024 at 08:51:41PM +0200, Vasileios Aoiridis kirjoitti:
> On Fri, Oct 11, 2024 at 01:00:55PM +0300, Andy Shevchenko wrote:
> > On Thu, Oct 10, 2024 at 11:00:20PM +0200, vamoirid wrote:
> > > 
> > > According to datasheet's Section 1.1, Table 1, the startup time for the
> > > device is 2ms and not 5ms.
> > 
> > Fixes tag?
> 
> It is not affecting at all the operation of the driver so I was not sure
> if it was worth it to be backported to the previous versions. This is
> why I didn't put a fixes tag. You think for such a fix is necessary?

The commit message siggests that this is a fix. If you want to make it clear,
that it shouldn't be considered as a such, perhaps you need to rephrase it.
diff mbox series

Patch

diff --git a/drivers/iio/chemical/bme680.h b/drivers/iio/chemical/bme680.h
index b2c547ac8d34..e55a48982b3e 100644
--- a/drivers/iio/chemical/bme680.h
+++ b/drivers/iio/chemical/bme680.h
@@ -63,7 +63,7 @@ 
 
 #define BME680_MEAS_TRIM_MASK			GENMASK(24, 4)
 
-#define BME680_STARTUP_TIME_US			5000
+#define BME680_STARTUP_TIME_US			2000
 
 /* Calibration Parameters */
 #define BME680_T2_LSB_REG	0x8A