[v10,0/2] Add driver for Sharp Memory LCD

Message

Alex Lanzano Oct. 8, 2024, 3:03 a.m. UTC

This patch series add support for the monochrome Sharp Memory LCD
panels. This series is based off of the work done by Mehdi Djait.

References:
https://lore.kernel.org/dri-devel/71a[e-mail]/
https://www.sharpsde.com/fileadmin/products/Displays/2016_SDE_App_Note_for_Memory_LCD_programming_V1.3.pdf

Co-developed-by: Mehdi Djait <[e-mail]>
Signed-off-by: Mehdi Djait <[e-mail]>
Signed-off-by: Alex Lanzano <[e-mail]>
---
Changes in v10:
- Address comments from from Uwe
    - Replaced -EINVAL with PTR_ERR
    - Error check pwm_apply_might_sleep function
    - Remove redundant error message

Changes in v9:
- Move pwm and software VCOM generation to probe/remove functions instead of crtc enable/disable functions.
  pwd_disable will suffice on driver removal.
- Change comment format to match Linux Kernel style.

Changes in v8:
- Addressed review comments from Uwe
    - Replace pwm_get_state with pwm_init_state
    - Use pwm_set_relative_duty_cycle instead of manually setting period and duty cycle

Changes in v7:
- Add Reviewed-by tag back to dt-binding patch

Changes in v6:
- Rebase off latest drm-misc-next
- Replace pwm_apply_state with pwm_apply_might_sleep

Changes in v5:
- Address minor style issues in sharp-memory.c

Changes in v4:
- Remove redundant dev_err

Changes in v3:
- Fix file path in MAINTAINERS file
- Address review comments
- Simplify mode selection based on match data instead of model

Changes in v2:
- Credited Mehdi Djait in commit messages
- Renamed sharp,sharp-memory.yaml to sharp,ls010b7dh04.yaml
- Using strings instead of int for vcom-mode in dt-binding
- Fixed indentation of binding example
- Removed binding header
- Removed extra whitespace in sharp-memory.c
- Fixed error handling in sharp-memory.c
- Added match data to of_device_id table to be in-sync with spi_device_id table
- Replaced redundant function with spi_get_device_match_data
- Sorted header files in sharp-memory.c
---

Alex Lanzano (2):
  dt-bindings: display: Add Sharp Memory LCD bindings
  drm/tiny: Add driver for Sharp Memory LCD

 .../bindings/display/sharp,ls010b7dh04.yaml   |  92 +++
 MAINTAINERS                                   |   6 +
 drivers/gpu/drm/tiny/Kconfig                  |  20 +
 drivers/gpu/drm/tiny/Makefile                 |   1 +
 drivers/gpu/drm/tiny/sharp-memory.c           | 669 ++++++++++++++++++
 5 files changed, 788 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/sharp,ls010b7dh04.yaml
 create mode 100644 drivers/gpu/drm/tiny/sharp-memory.c

Comments

Markus Elfring Oct. 8, 2024, 9:04 a.m. UTC | #1

> This patch series add support for the monochrome Sharp Memory LCD panels.
…
> ---
> Changes in v10:
…

Is the support for the application of scope-based resource management
still ignored here?

Regards,
Markus

Dmitry Baryshkov Oct. 14, 2024, 7:35 a.m. UTC | #2

On Mon, Oct 07, 2024 at 11:03:09PM -0400, Alex Lanzano wrote:
> This patch series add support for the monochrome Sharp Memory LCD
> panels. This series is based off of the work done by Mehdi Djait.
> 
> References:
> https://lore.kernel.org/dri-devel/71a[e-mail]/
> https://www.sharpsde.com/fileadmin/products/Displays/2016_SDE_App_Note_for_Memory_LCD_programming_V1.3.pdf
> 
> Co-developed-by: Mehdi Djait <[e-mail]>
> Signed-off-by: Mehdi Djait <[e-mail]>
> Signed-off-by: Alex Lanzano <[e-mail]>
> ---
> Changes in v10:
> - Address comments from from Uwe
>     - Replaced -EINVAL with PTR_ERR
>     - Error check pwm_apply_might_sleep function
>     - Remove redundant error message

Let's wait for an Ack from Uwe's side. If there are no further issues,
the series seems to be ready.

Alex Lanzano Oct. 14, 2024, 8:15 p.m. UTC | #3

On Mon, Oct 14, 2024 at 10:35:03AM GMT, Dmitry Baryshkov wrote:
> On Mon, Oct 07, 2024 at 11:03:09PM -0400, Alex Lanzano wrote:
> > This patch series add support for the monochrome Sharp Memory LCD
> > panels. This series is based off of the work done by Mehdi Djait.
> > 
> > References:
> > https://lore.kernel.org/dri-devel/71a[e-mail]/
> > https://www.sharpsde.com/fileadmin/products/Displays/2016_SDE_App_Note_for_Memory_LCD_programming_V1.3.pdf
> > 
> > Co-developed-by: Mehdi Djait <[e-mail]>
> > Signed-off-by: Mehdi Djait <[e-mail]>
> > Signed-off-by: Alex Lanzano <[e-mail]>
> > ---
> > Changes in v10:
> > - Address comments from from Uwe
> >     - Replaced -EINVAL with PTR_ERR
> >     - Error check pwm_apply_might_sleep function
> >     - Remove redundant error message
> 
> Let's wait for an Ack from Uwe's side. If there are no further issues,
> the series seems to be ready.

Looks like I'll need to make one more version to accommodate the new
client setup by Thomas Zimmermann.

https://lore.kernel.org/all/[e-mail]/

Best regards,
Alex