diff mbox series

[04/17] ipv6: replace call_rcu by kfree_rcu for simple kmem_cache_free callback

Message ID 20241013201704.49576-5-Julia.Lawall@inria.fr (mailing list archive)
State Accepted
Commit 85e48bcf294caf2915c16d89dbfbf936653415a3
Delegated to: Netdev Maintainers
Headers show
Series replace call_rcu by kfree_rcu for simple kmem_cache_free callback | expand

Commit Message

Julia Lawall Oct. 13, 2024, 8:16 p.m. UTC 
Since SLOB was removed and since
commit 6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()"),
it is not necessary to use call_rcu when the callback only performs
kmem_cache_free. Use kfree_rcu() directly.

The changes were made using Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

---
 net/ipv6/ip6_fib.c |    9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

Comments

Eric Dumazet Oct. 14, 2024, 7:43 a.m. UTC | #1 
On Sun, Oct 13, 2024 at 10:18 PM Julia Lawall <Julia.Lawall@inria.fr> wrote:
>
> Since SLOB was removed and since
> commit 6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()"),
> it is not necessary to use call_rcu when the callback only performs
> kmem_cache_free. Use kfree_rcu() directly.
>
> The changes were made using Coccinelle.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>

Reviewed-by: Eric Dumazet <edumazet@google.com>
diff mbox series

Patch

diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c
index eb111d20615c..24c57c1a52dd 100644
--- a/net/ipv6/ip6_fib.c
+++ b/net/ipv6/ip6_fib.c
@@ -198,16 +198,9 @@  static void node_free_immediate(struct net *net, struct fib6_node *fn)
 	net->ipv6.rt6_stats->fib_nodes--;
 }
 
-static void node_free_rcu(struct rcu_head *head)
-{
-	struct fib6_node *fn = container_of(head, struct fib6_node, rcu);
-
-	kmem_cache_free(fib6_node_kmem, fn);
-}
-
 static void node_free(struct net *net, struct fib6_node *fn)
 {
-	call_rcu(&fn->rcu, node_free_rcu);
+	kfree_rcu(fn, rcu);
 	net->ipv6.rt6_stats->fib_nodes--;
 }