| Message ID | 20241012075312.16342-5-witcher@wiredspace.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/7] drm/panic: avoid reimplementing Iterator::find | expand |
On 12/10/2024 09:52, Thomas Böhler wrote: > It is common practice in Rust to indent the next line the same amount of > space as the previous one if both belong to the same list item. Clippy > checks for this with the lint `doc_lazy_continuation`. > > error: doc list item without indentation > --> drivers/gpu/drm/drm_panic_qr.rs:979:5 > | > 979 | /// conversion to numeric segments. > | ^ > | > = help: if this is supposed to be its own paragraph, add a blank line > = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation > = note: `-D clippy::doc-lazy-continuation` implied by `-D warnings` > = help: to override `-D warnings` add `#[allow(clippy::doc_lazy_continuation)]` > help: indent this line > | > 979 | /// conversion to numeric segments. > | ++ > > Indent the offending line by 2 more spaces to remove this Clippy error. Thanks, it looks good to me. Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com> > > Reported-by: Miguel Ojeda <ojeda@kernel.org> > Closes: https://github.com/Rust-for-Linux/linux/issues/1123 > Signed-off-by: Thomas Böhler <witcher@wiredspace.de> > --- > drivers/gpu/drm/drm_panic_qr.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs > index 5b2386a515fa..58c46f366f76 100644 > --- a/drivers/gpu/drm/drm_panic_qr.rs > +++ b/drivers/gpu/drm/drm_panic_qr.rs > @@ -976,7 +976,7 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) { > /// * `url_len`: Length of the URL. > /// > /// * If `url_len` > 0, remove the 2 segments header/length and also count the > -/// conversion to numeric segments. > +/// conversion to numeric segments. > /// * If `url_len` = 0, only removes 3 bytes for 1 binary segment. > #[no_mangle] > pub extern "C" fn drm_panic_qr_max_data_size(version: u8, url_len: usize) -> usize {
diff --git a/drivers/gpu/drm/drm_panic_qr.rs b/drivers/gpu/drm/drm_panic_qr.rs index 5b2386a515fa..58c46f366f76 100644 --- a/drivers/gpu/drm/drm_panic_qr.rs +++ b/drivers/gpu/drm/drm_panic_qr.rs @@ -976,7 +976,7 @@ fn draw_all(&mut self, data: impl Iterator<Item = u8>) { /// * `url_len`: Length of the URL. /// /// * If `url_len` > 0, remove the 2 segments header/length and also count the -/// conversion to numeric segments. +/// conversion to numeric segments. /// * If `url_len` = 0, only removes 3 bytes for 1 binary segment. #[no_mangle] pub extern "C" fn drm_panic_qr_max_data_size(version: u8, url_len: usize) -> usize {
It is common practice in Rust to indent the next line the same amount of space as the previous one if both belong to the same list item. Clippy checks for this with the lint `doc_lazy_continuation`. error: doc list item without indentation --> drivers/gpu/drm/drm_panic_qr.rs:979:5 | 979 | /// conversion to numeric segments. | ^ | = help: if this is supposed to be its own paragraph, add a blank line = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation = note: `-D clippy::doc-lazy-continuation` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::doc_lazy_continuation)]` help: indent this line | 979 | /// conversion to numeric segments. | ++ Indent the offending line by 2 more spaces to remove this Clippy error. Reported-by: Miguel Ojeda <ojeda@kernel.org> Closes: https://github.com/Rust-for-Linux/linux/issues/1123 Signed-off-by: Thomas Böhler <witcher@wiredspace.de> --- drivers/gpu/drm/drm_panic_qr.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)