| Message ID | 20241011-rng-mp25-v2-v2-1-76fd6170280c@foss.st.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Herbert Xu |
| Headers | show |
| Series | Add support for stm32mp25x RNG | expand |
On Fri, Oct 11, 2024 at 05:41:41PM +0200, Gatien Chevallier wrote: > clocks: > - maxItems: 1 > + minItems: 1 > + maxItems: 2 > + > + clock-names: > + minItems: 1 > + items: > + - const: core > + - const: bus > > resets: > maxItems: 1 > @@ -57,6 +65,26 @@ allOf: > properties: > st,rng-lock-conf: false > > + - if: > + properties: > + compatible: > + contains: > + enum: > + - st,stm32-rng > + - st,stm32mp13-rng > + then: > + properties: > + clocks: > + maxItems: 1 > + clock-names: false > + else: > + properties: > + clocks: > + minItems: 2 > + maxItems: 2 Missing clock-names constraint. They *always* go in sync with clocks. Best regards, Krzysztof
On 10/14/24 09:29, Krzysztof Kozlowski wrote: > On Fri, Oct 11, 2024 at 05:41:41PM +0200, Gatien Chevallier wrote: >> clocks: >> - maxItems: 1 >> + minItems: 1 >> + maxItems: 2 >> + >> + clock-names: >> + minItems: 1 >> + items: >> + - const: core >> + - const: bus >> >> resets: >> maxItems: 1 >> @@ -57,6 +65,26 @@ allOf: >> properties: >> st,rng-lock-conf: false >> >> + - if: >> + properties: >> + compatible: >> + contains: >> + enum: >> + - st,stm32-rng >> + - st,stm32mp13-rng >> + then: >> + properties: >> + clocks: >> + maxItems: 1 >> + clock-names: false >> + else: >> + properties: >> + clocks: >> + minItems: 2 >> + maxItems: 2 > > Missing clock-names constraint. They *always* go in sync with clocks. > > Best regards, > Krzysztof > Done for V3, Best regards, Gatien
diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml index 340d01d481d12ce8664a60db42182ddaf0d1385b..5d553f7f706f8d7c17aea07e4130a34af764a635 100644 --- a/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml +++ b/Documentation/devicetree/bindings/rng/st,stm32-rng.yaml @@ -18,12 +18,20 @@ properties: enum: - st,stm32-rng - st,stm32mp13-rng + - st,stm32mp25-rng reg: maxItems: 1 clocks: - maxItems: 1 + minItems: 1 + maxItems: 2 + + clock-names: + minItems: 1 + items: + - const: core + - const: bus resets: maxItems: 1 @@ -57,6 +65,26 @@ allOf: properties: st,rng-lock-conf: false + - if: + properties: + compatible: + contains: + enum: + - st,stm32-rng + - st,stm32mp13-rng + then: + properties: + clocks: + maxItems: 1 + clock-names: false + else: + properties: + clocks: + minItems: 2 + maxItems: 2 + required: + - clock-names + additionalProperties: false examples:
Add RNG STM32MP25x platforms compatible. Update the clock properties management to support all versions. Signed-off-by: Gatien Chevallier <gatien.chevallier@foss.st.com> --- Changes in V2 -Fix missing min/maxItems -Removed MP25 RNG example -Renamed RNG clocks for mp25 to "core" and "bus" --- .../devicetree/bindings/rng/st,stm32-rng.yaml | 30 +++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-)