diff mbox series

[v2,net-next] selftests: tc-testing: Fixed Typo error

Message ID Zw1LvrSdnl5bS-uS@Emma (mailing list archive)
State New
Headers show
Series [v2,net-next] selftests: tc-testing: Fixed Typo error | expand

Commit Message

Karan Sanghavi Oct. 14, 2024, 4:50 p.m. UTC
This commit combines two fixes for typographical errors
in the "name" fields of the JSON objects with IDs 
"4319" and "4341" in the tc-testing selftests.
For the files tc-tests/filters/cgroup.json and
/tc-tests/filters/flow.json.

v2:
- Combine two earlier patches into one
- Links to v1 of each patch
  [1] https://lore.kernel.org/all/Zqp9asVA-q_OzDP-@Emma/
  [2] https://lore.kernel.org/all/Zqp92oXa9joXk4T9@Emma/


Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
---
 tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 2 +-
 tools/testing/selftests/tc-testing/tc-tests/filters/flow.json   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Shuah Khan Oct. 14, 2024, 11:57 p.m. UTC | #1
On 10/14/24 10:50, Karan Sanghavi wrote:
> This commit combines two fixes for typographical errors
> in the "name" fields of the JSON objects with IDs
> "4319" and "4341" in the tc-testing selftests.
> For the files tc-tests/filters/cgroup.json and
> /tc-tests/filters/flow.json.
> 

This is not the correct way to write change logs. There is no
need to mention how two commits are combines.

State the problem and sya what this patch does e.g:
"Fix spelling errors in cgroup.json and flow.json"

> v2:
> - Combine two earlier patches into one
> - Links to v1 of each patch
>    [1] https://lore.kernel.org/all/Zqp9asVA-q_OzDP-@Emma/
>    [2] https://lore.kernel.org/all/Zqp92oXa9joXk4T9@Emma/
> 
> 
> Signed-off-by: Karan Sanghavi <karansanghvi98@gmail.com>
> ---
>   tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json | 2 +-
>   tools/testing/selftests/tc-testing/tc-tests/filters/flow.json   | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> index 03723cf84..6897ff5ad 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
> @@ -1189,7 +1189,7 @@
>       },
>       {
>           "id": "4319",
> -        "name": "Replace cgroup filter with diffferent match",
> +        "name": "Replace cgroup filter with different match",
>           "category": [
>               "filter",
>               "cgroup"
> diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> index 58189327f..996448afe 100644
> --- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
> @@ -507,7 +507,7 @@
>       },
>       {
>           "id": "4341",
> -        "name": "Add flow filter with muliple ops",
> +        "name": "Add flow filter with multiple ops",
>           "category": [
>               "filter",
>               "flow"

thanks,
-- Shuah
diff mbox series

Patch

diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
index 03723cf84..6897ff5ad 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/cgroup.json
@@ -1189,7 +1189,7 @@ 
     },
     {
         "id": "4319",
-        "name": "Replace cgroup filter with diffferent match",
+        "name": "Replace cgroup filter with different match",
         "category": [
             "filter",
             "cgroup"
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
index 58189327f..996448afe 100644
--- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
+++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json
@@ -507,7 +507,7 @@ 
     },
     {
         "id": "4341",
-        "name": "Add flow filter with muliple ops",
+        "name": "Add flow filter with multiple ops",
         "category": [
             "filter",
             "flow"