| Message ID | 20241010151223.311719-1-algonell@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
On Thu, Oct 10, 2024 at 06:11:18PM +0300, Andrew Kreimer wrote: > v2: > - Fix grammar. > > v1: > - https://lore.kernel.org/all/20241009114940.520486-1-algonell@gmail.com/ > > Interdiff against v1: > diff --git a/compat/regex/regexec.c b/compat/regex/regexec.c > index 15ab2d1d40..2eeec82f40 100644 > --- a/compat/regex/regexec.c > +++ b/compat/regex/regexec.c > @@ -292,7 +292,7 @@ compat_symbol (libc, __compat_regexec, regexec, GLIBC_2_0); > concerned. > > If REGS is not NULL, and BUFP->no_sub is not set, the offsets of the match > - and all groups is stored in REGS. (For the "_2" variants, the offsets are > + and all groups are stored in REGS. (For the "_2" variants, the offsets are > computed relative to the concatenation, not relative to the individual > strings.) Thanks, the diff compared to v1 looks as expected to me, so this version is good to go from my point of view. Patrick
On Mon, Oct 14, 2024 at 12:39:38PM +0200, Patrick Steinhardt wrote: > Thanks, the diff compared to v1 looks as expected to me, so this > version is good to go from my point of view. Thanks very much for reviewing. Thanks, Taylor
diff --git a/compat/regex/regexec.c b/compat/regex/regexec.c index 15ab2d1d40..2eeec82f40 100644 --- a/compat/regex/regexec.c +++ b/compat/regex/regexec.c @@ -292,7 +292,7 @@ compat_symbol (libc, __compat_regexec, regexec, GLIBC_2_0); concerned. If REGS is not NULL, and BUFP->no_sub is not set, the offsets of the match - and all groups is stored in REGS. (For the "_2" variants, the offsets are + and all groups are stored in REGS. (For the "_2" variants, the offsets are computed relative to the concatenation, not relative to the individual strings.)