| Message ID | 20241010-schema-v1-3-98b2d0a2f7a2@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add ethernet dts schema for qcs615/qcs8300 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote: > Add compatible for the MAC controller on qcs8300 platforms. > Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the > compatible. > > Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> > --- > Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > index 8cf29493b822..3ee5367bdde1 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > @@ -23,6 +23,10 @@ properties: > - enum: > - qcom,qcs615-ethqos > - const: qcom,sm8150-ethqos > + - items: > + - enum: > + - qcom,qcs8300-ethqos > + - const: qcom,sa8775p-ethqos This block should go before earlier qcs615, to keep order by fallback. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 2024-10-10 14:15, Krzysztof Kozlowski wrote: > On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote: >> Add compatible for the MAC controller on qcs8300 platforms. >> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the >> compatible. >> >> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> >> --- >> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> index 8cf29493b822..3ee5367bdde1 100644 >> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >> @@ -23,6 +23,10 @@ properties: >> - enum: >> - qcom,qcs615-ethqos >> - const: qcom,sm8150-ethqos >> + - items: >> + - enum: >> + - qcom,qcs8300-ethqos >> + - const: qcom,sa8775p-ethqos > > This block should go before earlier qcs615, to keep order by fallback. Why this block should positioned before qcs615, given that it comes later in alphabetical order? > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
On 15/10/2024 08:21, Yijie Yang wrote: > > > On 2024-10-10 14:15, Krzysztof Kozlowski wrote: >> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote: >>> Add compatible for the MAC controller on qcs8300 platforms. >>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the >>> compatible. >>> >>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> index 8cf29493b822..3ee5367bdde1 100644 >>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> @@ -23,6 +23,10 @@ properties: >>> - enum: >>> - qcom,qcs615-ethqos >>> - const: qcom,sm8150-ethqos >>> + - items: >>> + - enum: >>> + - qcom,qcs8300-ethqos >>> + - const: qcom,sa8775p-ethqos >> >> This block should go before earlier qcs615, to keep order by fallback. --------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^ Here > > Why this block should positioned before qcs615, given that it comes > later in alphabetical order? sa < sm Best regards, Krzysztof
On 2024-10-15 14:27, Krzysztof Kozlowski wrote: > On 15/10/2024 08:21, Yijie Yang wrote: >> >> >> On 2024-10-10 14:15, Krzysztof Kozlowski wrote: >>> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote: >>>> Add compatible for the MAC controller on qcs8300 platforms. >>>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the >>>> compatible. >>>> >>>> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>>> index 8cf29493b822..3ee5367bdde1 100644 >>>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>>> @@ -23,6 +23,10 @@ properties: >>>> - enum: >>>> - qcom,qcs615-ethqos >>>> - const: qcom,sm8150-ethqos >>>> + - items: >>>> + - enum: >>>> + - qcom,qcs8300-ethqos >>>> + - const: qcom,sa8775p-ethqos >>> >>> This block should go before earlier qcs615, to keep order by fallback. > > --------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^ > > Here > >> >> Why this block should positioned before qcs615, given that it comes >> later in alphabetical order? > > sa < sm Understood, thanks. > > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml index 8cf29493b822..3ee5367bdde1 100644 --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml @@ -23,6 +23,10 @@ properties: - enum: - qcom,qcs615-ethqos - const: qcom,sm8150-ethqos + - items: + - enum: + - qcom,qcs8300-ethqos + - const: qcom,sa8775p-ethqos - enum: - qcom,qcs404-ethqos - qcom,sa8775p-ethqos
Add compatible for the MAC controller on qcs8300 platforms. Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the compatible. Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> --- Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++ 1 file changed, 4 insertions(+)