| Message ID | 20241015193013.16790-1-everestkc@everestkc.com.np (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8f66f649846348871148413dcb6af69d9adf760a |
| Headers | show |
| Series | [V3,next] Bluetooth: btintel_pcie: Remove structually deadcode | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | success | CheckPatch PASS |
| tedd_an/GitLint | fail | WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search 13: B3 Line contains hard tab characters (\t): " - Removed the link to Coverity Scan report" 17: B2 Line has trailing whitespace: " " |
| tedd_an/SubjectPrefix | success | Gitlint PASS |
| tedd_an/BuildKernel | success | BuildKernel PASS |
| tedd_an/CheckAllWarning | success | CheckAllWarning PASS |
| tedd_an/CheckSparse | success | CheckSparse PASS |
On 10/15/24 13:30, Everest K.C. wrote: > The switch case statement has a default branch. Thus, the return > statement at the end of the function can never be reached. > Fix it by removing the return statement at the end of the > function. > > This issue was reported by Coverity Scan. You forgot to fix the typo Dan pointed out in the short log. Don't forget to include reviewers when you send new version based on their comments. + Adding Dan > > Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware") > Signed-off-by: Everest K.C. <everestkc@everestkc.com.np> > --- > V2 -> V3: - Removed that the change was successfully built > - Removed the link to Coverity Scan report > V1 -> V2: - Changed "Fixing" to "Fix" in the changelog > - Added that the change was successfully built > - Added kernel-janitors mailing list to CC > > drivers/bluetooth/btintel_pcie.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c > index e4ae8c898dfd..660496e55276 100644 > --- a/drivers/bluetooth/btintel_pcie.c > +++ b/drivers/bluetooth/btintel_pcie.c > @@ -391,7 +391,6 @@ static inline char *btintel_pcie_alivectxt_state2str(u32 alive_intr_ctxt) > default: > return "unknown"; > } > - return "null"; > } > > /* This function handles the MSI-X interrupt for gp0 cause (bit 0 in With the typo fixed: Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> thanks, -- Shuah
On Tue, Oct 15, 2024 at 4:27 PM Shuah Khan <skhan@linuxfoundation.org> wrote: > > On 10/15/24 13:30, Everest K.C. wrote: > > The switch case statement has a default branch. Thus, the return > > statement at the end of the function can never be reached. > > Fix it by removing the return statement at the end of the > > function. > > > > This issue was reported by Coverity Scan. > > You forgot to fix the typo Dan pointed out in the short log. > Don't forget to include reviewers when you send new version > based on their comments. I missed that feedback from Dan. Will include it in V4. Also, will include Dan in V4. > + Adding Dan > > > > Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware") > > Signed-off-by: Everest K.C. <everestkc@everestkc.com.np> > > --- > > V2 -> V3: - Removed that the change was successfully built > > - Removed the link to Coverity Scan report > > V1 -> V2: - Changed "Fixing" to "Fix" in the changelog > > - Added that the change was successfully built > > - Added kernel-janitors mailing list to CC > > > > drivers/bluetooth/btintel_pcie.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c > > index e4ae8c898dfd..660496e55276 100644 > > --- a/drivers/bluetooth/btintel_pcie.c > > +++ b/drivers/bluetooth/btintel_pcie.c > > @@ -391,7 +391,6 @@ static inline char *btintel_pcie_alivectxt_state2str(u32 alive_intr_ctxt) > > default: > > return "unknown"; > > } > > - return "null"; > > } > > > > /* This function handles the MSI-X interrupt for gp0 cause (bit 0 in > > With the typo fixed: > > Reviewed-by: Shuah Khan <skhan@linuxfoundation.org> > > thanks, > -- Shuah Thanks, Everest K.C.
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Tue, 15 Oct 2024 13:30:12 -0600 you wrote: > The switch case statement has a default branch. Thus, the return > statement at the end of the function can never be reached. > Fix it by removing the return statement at the end of the > function. > > This issue was reported by Coverity Scan. > > [...] Here is the summary with links: - [V3,next] Bluetooth: btintel_pcie: Remove structually deadcode https://git.kernel.org/bluetooth/bluetooth-next/c/8f66f6498463 You are awesome, thank you!
diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c index e4ae8c898dfd..660496e55276 100644 --- a/drivers/bluetooth/btintel_pcie.c +++ b/drivers/bluetooth/btintel_pcie.c @@ -391,7 +391,6 @@ static inline char *btintel_pcie_alivectxt_state2str(u32 alive_intr_ctxt) default: return "unknown"; } - return "null"; } /* This function handles the MSI-X interrupt for gp0 cause (bit 0 in
The switch case statement has a default branch. Thus, the return statement at the end of the function can never be reached. Fix it by removing the return statement at the end of the function. This issue was reported by Coverity Scan. Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware") Signed-off-by: Everest K.C. <everestkc@everestkc.com.np> --- V2 -> V3: - Removed that the change was successfully built - Removed the link to Coverity Scan report V1 -> V2: - Changed "Fixing" to "Fix" in the changelog - Added that the change was successfully built - Added kernel-janitors mailing list to CC drivers/bluetooth/btintel_pcie.c | 1 - 1 file changed, 1 deletion(-)