| Message ID | 20241015010817.453539-1-lizhijian@fujitsu.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] selftests: Add a few missing gitignore files | expand |
On 10/14/24 19:08, Li Zhijian wrote: > Binary files should be added to .gitignore > > 'git status' complains: > Untracked files: > (use "git add <file>..." to include in what will be committed) > alsa/global-timer > alsa/utimer-test > filesystems/statmount/statmount_test_ns > mm/hugetlb_dio > mm/pkey_sighandler_tests_32 > mm/pkey_sighandler_tests_64 > net/netfilter/conntrack_reverse_clash > > Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> > --- > tools/testing/selftests/alsa/.gitignore | 2 ++ > tools/testing/selftests/filesystems/statmount/.gitignore | 1 + > tools/testing/selftests/mm/.gitignore | 2 ++ > tools/testing/selftests/net/netfilter/.gitignore | 1 + You are sending 3 patches without a cover letter and you are missing key people who should review the patches. Combining several subsystem changes in one patch leads to merge conflicts. Run get_maintainers to see who all the patch should be sent. > 4 files changed, 6 insertions(+) > > diff --git a/tools/testing/selftests/alsa/.gitignore b/tools/testing/selftests/alsa/.gitignore > index 12dc3fcd3456..1407fd24a97b 100644 > --- a/tools/testing/selftests/alsa/.gitignore > +++ b/tools/testing/selftests/alsa/.gitignore > @@ -1,3 +1,5 @@ > mixer-test > pcm-test > test-pcmtest-driver > +global-timer > +utimer-test > diff --git a/tools/testing/selftests/filesystems/statmount/.gitignore b/tools/testing/selftests/filesystems/statmount/.gitignore > index 82a4846cbc4b..66a21f289453 100644 > --- a/tools/testing/selftests/filesystems/statmount/.gitignore > +++ b/tools/testing/selftests/filesystems/statmount/.gitignore > @@ -1,2 +1,3 @@ > # SPDX-License-Identifier: GPL-2.0-only > /*_test > +statmount_test_ns > diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore > index da030b43e43b..2ac11b7fcb26 100644 > --- a/tools/testing/selftests/mm/.gitignore > +++ b/tools/testing/selftests/mm/.gitignore > @@ -51,3 +51,5 @@ hugetlb_madv_vs_map > mseal_test > seal_elf > droppable > +hugetlb_dio > +pkey_sighandler_tests* > diff --git a/tools/testing/selftests/net/netfilter/.gitignore b/tools/testing/selftests/net/netfilter/.gitignore > index 0a64d6d0e29a..eef8d5784e94 100644 > --- a/tools/testing/selftests/net/netfilter/.gitignore > +++ b/tools/testing/selftests/net/netfilter/.gitignore > @@ -4,3 +4,4 @@ connect_close > conntrack_dump_flush > sctp_collision > nf_queue > +conntrack_reverse_clash thanks, -- Shuah
On 15/10/2024 23:38, Shuah Khan wrote: > On 10/14/24 19:08, Li Zhijian wrote: >> Binary files should be added to .gitignore >> >> 'git status' complains: >> Untracked files: >> (use "git add <file>..." to include in what will be committed) >> alsa/global-timer >> alsa/utimer-test >> filesystems/statmount/statmount_test_ns >> mm/hugetlb_dio >> mm/pkey_sighandler_tests_32 >> mm/pkey_sighandler_tests_64 >> net/netfilter/conntrack_reverse_clash >> >> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> >> --- >> tools/testing/selftests/alsa/.gitignore | 2 ++ >> tools/testing/selftests/filesystems/statmount/.gitignore | 1 + >> tools/testing/selftests/mm/.gitignore | 2 ++ >> tools/testing/selftests/net/netfilter/.gitignore | 1 + > > You are sending 3 patches without a cover letter and you are missing > key people who should review the patches. > > Combining several subsystem changes in one patch leads to merge > conflicts. > > Run get_maintainers to see who all the patch should be sent. Hey Shush, I see what you are concerning... I didn't do that because this patch set is simple, and not technical specific for their subsystems. I just to make the code obey the generic *RULE*. - binary files generated by kbuild should be in .gitignore - test result also should be in .gitignore and cleaned by make clean - temporary file should be cleaned after test finished. Anyway, I will separate them per their subsystems later as your suggestion. Thanks Zhijian > >> 4 files changed, 6 insertions(+) >> >> diff --git a/tools/testing/selftests/alsa/.gitignore b/tools/testing/selftests/alsa/.gitignore >> index 12dc3fcd3456..1407fd24a97b 100644 >> --- a/tools/testing/selftests/alsa/.gitignore >> +++ b/tools/testing/selftests/alsa/.gitignore >> @@ -1,3 +1,5 @@ >> mixer-test >> pcm-test >> test-pcmtest-driver >> +global-timer >> +utimer-test >> diff --git a/tools/testing/selftests/filesystems/statmount/.gitignore b/tools/testing/selftests/filesystems/statmount/.gitignore >> index 82a4846cbc4b..66a21f289453 100644 >> --- a/tools/testing/selftests/filesystems/statmount/.gitignore >> +++ b/tools/testing/selftests/filesystems/statmount/.gitignore >> @@ -1,2 +1,3 @@ >> # SPDX-License-Identifier: GPL-2.0-only >> /*_test >> +statmount_test_ns >> diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore >> index da030b43e43b..2ac11b7fcb26 100644 >> --- a/tools/testing/selftests/mm/.gitignore >> +++ b/tools/testing/selftests/mm/.gitignore >> @@ -51,3 +51,5 @@ hugetlb_madv_vs_map >> mseal_test >> seal_elf >> droppable >> +hugetlb_dio >> +pkey_sighandler_tests* >> diff --git a/tools/testing/selftests/net/netfilter/.gitignore b/tools/testing/selftests/net/netfilter/.gitignore >> index 0a64d6d0e29a..eef8d5784e94 100644 >> --- a/tools/testing/selftests/net/netfilter/.gitignore >> +++ b/tools/testing/selftests/net/netfilter/.gitignore >> @@ -4,3 +4,4 @@ connect_close >> conntrack_dump_flush >> sctp_collision >> nf_queue >> +conntrack_reverse_clash > > thanks, > -- Shuah
Hi Li,
kernel test robot noticed the following build warnings:
[auto build test WARNING on shuah-kselftest/next]
[also build test WARNING on shuah-kselftest/fixes rafael-pm/linux-next rafael-pm/bleeding-edge tiwai-sound/for-next tiwai-sound/for-linus netfilter-nf/main linus/master v6.12-rc3]
[cannot apply to akpm-mm/mm-everything nf-next/master next-20241017]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Li-Zhijian/selftests-net-Fix-ns-XXXXXX-not-cleanup/20241015-091039
base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
patch link: https://lore.kernel.org/r/20241015010817.453539-1-lizhijian%40fujitsu.com
patch subject: [PATCH 1/3] selftests: Add a few missing gitignore files
config: x86_64-kexec (https://download.01.org/0day-ci/archive/20241018/202410180306.uMloezUi-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241018/202410180306.uMloezUi-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410180306.uMloezUi-lkp@intel.com/
All warnings (new ones prefixed by >>):
tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files
tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files
tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files
>> tools/testing/selftests/mm/pkey_sighandler_tests.c: warning: ignored by one of the .gitignore files
diff --git a/tools/testing/selftests/alsa/.gitignore b/tools/testing/selftests/alsa/.gitignore index 12dc3fcd3456..1407fd24a97b 100644 --- a/tools/testing/selftests/alsa/.gitignore +++ b/tools/testing/selftests/alsa/.gitignore @@ -1,3 +1,5 @@ mixer-test pcm-test test-pcmtest-driver +global-timer +utimer-test diff --git a/tools/testing/selftests/filesystems/statmount/.gitignore b/tools/testing/selftests/filesystems/statmount/.gitignore index 82a4846cbc4b..66a21f289453 100644 --- a/tools/testing/selftests/filesystems/statmount/.gitignore +++ b/tools/testing/selftests/filesystems/statmount/.gitignore @@ -1,2 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-only /*_test +statmount_test_ns diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing/selftests/mm/.gitignore index da030b43e43b..2ac11b7fcb26 100644 --- a/tools/testing/selftests/mm/.gitignore +++ b/tools/testing/selftests/mm/.gitignore @@ -51,3 +51,5 @@ hugetlb_madv_vs_map mseal_test seal_elf droppable +hugetlb_dio +pkey_sighandler_tests* diff --git a/tools/testing/selftests/net/netfilter/.gitignore b/tools/testing/selftests/net/netfilter/.gitignore index 0a64d6d0e29a..eef8d5784e94 100644 --- a/tools/testing/selftests/net/netfilter/.gitignore +++ b/tools/testing/selftests/net/netfilter/.gitignore @@ -4,3 +4,4 @@ connect_close conntrack_dump_flush sctp_collision nf_queue +conntrack_reverse_clash
Binary files should be added to .gitignore 'git status' complains: Untracked files: (use "git add <file>..." to include in what will be committed) alsa/global-timer alsa/utimer-test filesystems/statmount/statmount_test_ns mm/hugetlb_dio mm/pkey_sighandler_tests_32 mm/pkey_sighandler_tests_64 net/netfilter/conntrack_reverse_clash Signed-off-by: Li Zhijian <lizhijian@fujitsu.com> --- tools/testing/selftests/alsa/.gitignore | 2 ++ tools/testing/selftests/filesystems/statmount/.gitignore | 1 + tools/testing/selftests/mm/.gitignore | 2 ++ tools/testing/selftests/net/netfilter/.gitignore | 1 + 4 files changed, 6 insertions(+)