mbox series

[net-next,v3,0/3] gve: adopt page pool

Message ID 20241014202108.1051963-1-pkaligineedi@google.com (mailing list archive)
Headers show
Series gve: adopt page pool | expand

Message

Praveen Kaligineedi Oct. 14, 2024, 8:21 p.m. UTC
From: Harshitha Ramamurthy <hramamurthy@google.com>

This patchset implements page pool support for gve.
The first patch deals with movement of code to make
page pool adoption easier in the next patch. The
second patch adopts the page pool API. The third patch
adds basic per queue stats which includes page pool
allocation failures as well.

Changes in v3:
-Add patch 3 for per queue stats to track page pool alloc
failures (Jakub Kicinski)
-Remove ethtool stat for page pool alloc failures in patch 2
(Jakub Kicinski)

Changes in v2:
-Set allow_direct parameter to true in napi context and false
in others (Shannon Nelson)
-Set the napi pointer in page pool params (Jakub Kicinski)
-Track page pool alloc failures per ring (Jakub Kicinski)
-Don't exceed 80 char limit (Jakub Kicinski)

Harshitha Ramamurthy (3):
  gve: move DQO rx buffer management related code to a new file
  gve: adopt page pool for DQ RDA mode
  gve: add support for basic queue stats

 drivers/net/ethernet/google/Kconfig           |   1 +
 drivers/net/ethernet/google/gve/Makefile      |   3 +-
 drivers/net/ethernet/google/gve/gve.h         |  36 ++
 .../ethernet/google/gve/gve_buffer_mgmt_dqo.c | 312 +++++++++++++++++
 drivers/net/ethernet/google/gve/gve_main.c    |  49 +++
 drivers/net/ethernet/google/gve/gve_rx_dqo.c  | 314 +++---------------
 6 files changed, 446 insertions(+), 269 deletions(-)
 create mode 100644 drivers/net/ethernet/google/gve/gve_buffer_mgmt_dqo.c

Comments

Jacob Keller Oct. 15, 2024, 7:26 p.m. UTC | #1
On 10/14/2024 1:21 PM, Praveen Kaligineedi wrote:
> From: Harshitha Ramamurthy <hramamurthy@google.com>
> 
> This patchset implements page pool support for gve.
> The first patch deals with movement of code to make
> page pool adoption easier in the next patch. The
> second patch adopts the page pool API. The third patch
> adds basic per queue stats which includes page pool
> allocation failures as well.
> 
> Changes in v3:
> -Add patch 3 for per queue stats to track page pool alloc
> failures (Jakub Kicinski)
> -Remove ethtool stat for page pool alloc failures in patch 2
> (Jakub Kicinski)
> 
> Changes in v2:
> -Set allow_direct parameter to true in napi context and false
> in others (Shannon Nelson)
> -Set the napi pointer in page pool params (Jakub Kicinski)
> -Track page pool alloc failures per ring (Jakub Kicinski)
> -Don't exceed 80 char limit (Jakub Kicinski)
> 

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
patchwork-bot+netdevbpf@kernel.org Oct. 16, 2024, 2:10 a.m. UTC | #2
Hello:

This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 14 Oct 2024 13:21:05 -0700 you wrote:
> From: Harshitha Ramamurthy <hramamurthy@google.com>
> 
> This patchset implements page pool support for gve.
> The first patch deals with movement of code to make
> page pool adoption easier in the next patch. The
> second patch adopts the page pool API. The third patch
> adds basic per queue stats which includes page pool
> allocation failures as well.
> 
> [...]

Here is the summary with links:
  - [net-next,v3,1/3] gve: move DQO rx buffer management related code to a new file
    https://git.kernel.org/netdev/net-next/c/93c68f1275f9
  - [net-next,v3,2/3] gve: adopt page pool for DQ RDA mode
    https://git.kernel.org/netdev/net-next/c/ebdfae0d377b
  - [net-next,v3,3/3] gve: add support for basic queue stats
    https://git.kernel.org/netdev/net-next/c/2e5e0932dff5

You are awesome, thank you!