mbox series

[0/4] phy: qcom: qmp-usb: fix NULL-deref on runtime suspend

Message ID 20240911115253.10920-1-johan+linaro@kernel.org
Headers show
Series phy: qcom: qmp-usb: fix NULL-deref on runtime suspend | expand

Message

Johan Hovold Sept. 11, 2024, 11:52 a.m. UTC 
When working on suspend support for Qualcomm platforms like x1e80100, I
ran into a NULL-pointer dereference in one of the QMP drivers. Turns out
this issue has since been reproduced in two more drivers.

Johan


Johan Hovold (4):
  phy: qcom: qmp-usb: fix NULL-deref on runtime suspend
  phy: qcom: qmp-usb-legacy: fix NULL-deref on runtime suspend
  phy: qcom: qmp-usbc: fix NULL-deref on runtime suspend
  phy: qcom: qmp-usb: move driver data initialisation earlier

 drivers/phy/qualcomm/phy-qcom-qmp-combo.c      | 3 +--
 drivers/phy/qualcomm/phy-qcom-qmp-usb-legacy.c | 1 +
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c        | 1 +
 drivers/phy/qualcomm/phy-qcom-qmp-usbc.c       | 1 +
 4 files changed, 4 insertions(+), 2 deletions(-)

Comments

Dmitry Baryshkov Sept. 11, 2024, 7:01 p.m. UTC | #1 
On Wed, Sep 11, 2024 at 01:52:49PM GMT, Johan Hovold wrote:
> When working on suspend support for Qualcomm platforms like x1e80100, I
> ran into a NULL-pointer dereference in one of the QMP drivers. Turns out
> this issue has since been reproduced in two more drivers.
> 
> Johan

For the series:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Johan Hovold Oct. 16, 2024, 7:43 a.m. UTC | #2 
Hi Vinod,

On Wed, Sep 11, 2024 at 01:52:49PM +0200, Johan Hovold wrote:
> When working on suspend support for Qualcomm platforms like x1e80100, I
> ran into a NULL-pointer dereference in one of the QMP drivers. Turns out
> this issue has since been reproduced in two more drivers.

> Johan Hovold (4):
>   phy: qcom: qmp-usb: fix NULL-deref on runtime suspend
>   phy: qcom: qmp-usb-legacy: fix NULL-deref on runtime suspend
>   phy: qcom: qmp-usbc: fix NULL-deref on runtime suspend
>   phy: qcom: qmp-usb: move driver data initialisation earlier

It's been a month (and a merge window) so sending a reminder.

Could you pick these up for 6.12-rc?

Johan
Vinod Koul Oct. 17, 2024, 3:31 p.m. UTC | #3 
On Wed, 11 Sep 2024 13:52:49 +0200, Johan Hovold wrote:
> When working on suspend support for Qualcomm platforms like x1e80100, I
> ran into a NULL-pointer dereference in one of the QMP drivers. Turns out
> this issue has since been reproduced in two more drivers.
> 
> Johan
> 
> 
> [...]

Applied, thanks!

[1/4] phy: qcom: qmp-usb: fix NULL-deref on runtime suspend
      commit: bd9e4d4a3b127686efc60096271b0a44c3100061
[2/4] phy: qcom: qmp-usb-legacy: fix NULL-deref on runtime suspend
      commit: 29240130ab77c80bea1464317ae2a5fd29c16a0c
[3/4] phy: qcom: qmp-usbc: fix NULL-deref on runtime suspend
      commit: 34c21f94fa1e147a19b54b6adf0c93a623b70dd8
[4/4] phy: qcom: qmp-usb: move driver data initialisation earlier
      commit: 1dd196f9004848d0318e8831f962cc76255431d8

Best regards,