| Message ID | 20241016042142.8088-1-surajsonawane0215@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear | expand |
On Wed, 16 Oct 2024 09:51:42 +0530, Suraj Sonawane wrote: > Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear > to resolve the following warning: > drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear() > error: uninitialized symbol 'ret'. > Initialize 'ret' to 0 to prevent undefined behavior from uninitialized > access. > > [...] Applied, thanks! [1/1] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear commit: 6cbf5c99541ac681cf5c6155b582dfbcd879eae3 -- Lee Jones [李琼斯]
On 16/10/24 13:23, Lee Jones wrote: > On Wed, 16 Oct 2024 09:51:42 +0530, Suraj Sonawane wrote: >> Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear >> to resolve the following warning: >> drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear() >> error: uninitialized symbol 'ret'. >> Initialize 'ret' to 0 to prevent undefined behavior from uninitialized >> access. >> >> [...] > > Applied, thanks! > > [1/1] leds: Fix uninitialized variable 'ret' in mt6370_mc_pattern_clear > commit: 6cbf5c99541ac681cf5c6155b582dfbcd879eae3 > > -- > Lee Jones [李琼斯] > Thanks a lot!
diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c index 10a0b5b45..87805c21e 100644 --- a/drivers/leds/rgb/leds-mt6370-rgb.c +++ b/drivers/leds/rgb/leds-mt6370-rgb.c @@ -587,7 +587,7 @@ static inline int mt6370_mc_pattern_clear(struct led_classdev *lcdev) struct mt6370_led *led = container_of(mccdev, struct mt6370_led, mc); struct mt6370_priv *priv = led->priv; struct mc_subled *subled; - int i, ret; + int i, ret = 0; mutex_lock(&led->priv->lock);
Fix the uninitialized symbol 'ret' in the function mt6370_mc_pattern_clear to resolve the following warning: drivers/leds/rgb/leds-mt6370-rgb.c:604 mt6370_mc_pattern_clear() error: uninitialized symbol 'ret'. Initialize 'ret' to 0 to prevent undefined behavior from uninitialized access. Signed-off-by: Suraj Sonawane <surajsonawane0215@gmail.com> --- V1 : https://lore.kernel.org/linux-arm-kernel/83572cde-19a1-4089-b02b-361a8ef40bee@gmail.com/T/ V2 : Updated .gitconfig to use the real name "Suraj Sonawane" as per the feedback. drivers/leds/rgb/leds-mt6370-rgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)