| Message ID | 20241014182438.732444-2-pengfei.li_1@nxp.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | Add iMX91 clock driver support | expand |
On 24-10-14 11:24:35, Pengfei Li wrote: > IMX93_CLK_END was previously defined in imx93-clock.h to indicate > the number of clocks. However, it is not part of the ABI. For starters > it does no really appear in DTS. But what's more important - new clocks > are described later, which contradicts this define in binding header. > So move this macro to clock driver. > > Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> > --- > drivers/clk/imx/clk-imx93.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index c6a9bc8ecc1f..c8b65146e76e 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -15,6 +15,8 @@ > > #include "clk.h" > > +#define IMX93_CLK_END 202 > + Sorry for this back and forth. I've been discussing this off-list with Krzysztof and others and now I think this is actually not wrong. So: Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > enum clk_sel { > LOW_SPEED_IO_SEL, > NON_IO_SEL, > -- > 2.34.1 >
diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c index c6a9bc8ecc1f..c8b65146e76e 100644 --- a/drivers/clk/imx/clk-imx93.c +++ b/drivers/clk/imx/clk-imx93.c @@ -15,6 +15,8 @@ #include "clk.h" +#define IMX93_CLK_END 202 + enum clk_sel { LOW_SPEED_IO_SEL, NON_IO_SEL,
IMX93_CLK_END was previously defined in imx93-clock.h to indicate the number of clocks. However, it is not part of the ABI. For starters it does no really appear in DTS. But what's more important - new clocks are described later, which contradicts this define in binding header. So move this macro to clock driver. Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com> --- drivers/clk/imx/clk-imx93.c | 2 ++ 1 file changed, 2 insertions(+)