| Message ID | 20241015211958.1465909-3-dan.scally@ideasonboard.com (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | Support OV5670 on IPU3 devices | expand |
On Tue, 15 Oct 2024, Daniel Scally wrote: > The Dell 7212 Rugged Extreme Tablet pairs an OV5670 sensor with the > Intel IPU3 ISP. The sensor is powered by a TPS68470 PMIC, and so we > need some board data to describe how to configure the GPIOs and > regulators to run the sensor. > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> > --- > .../x86/intel/int3472/tps68470_board_data.c | 128 ++++++++++++++++++ > 1 file changed, 128 insertions(+) > > diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > index 322237e056f3..d28053733bd2 100644 > --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c > +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > @@ -129,6 +129,109 @@ static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata = > }, > }; > > +/* Settings for Dell 7212 Tablet */ > + > +static struct regulator_consumer_supply int3479_vsio_consumer_supplies[] = { > + REGULATOR_SUPPLY("avdd", "i2c-INT3479:00"), > +}; > + > +static struct regulator_consumer_supply int3479_aux1_consumer_supplies[] = { > + REGULATOR_SUPPLY("dvdd", "i2c-INT3479:00"), > +}; > + > +static struct regulator_consumer_supply int3479_aux2_consumer_supplies[] = { > + REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), > +}; > + > +static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data = { > + .constraints = { > + .min_uV = 1200000, > + .max_uV = 1200000, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = 0, > + .consumer_supplies = NULL Add comma to any non-terminator entry. > +}; > + > +static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = { > + .constraints = { > + .min_uV = 2815200, > + .max_uV = 2815200, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = 0, > + .consumer_supplies = NULL > +}; > + > +static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = { > + .constraints = { > + .min_uV = 2815200, > + .max_uV = 2815200, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = 0, > + .consumer_supplies = NULL > +}; This looks exactly identical to dell_7212_tps68470_ana_reg_init_data. > +static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = 0, > + .consumer_supplies = NULL, > +}; > + > +static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int3479_vsio_consumer_supplies), > + .consumer_supplies = int3479_vsio_consumer_supplies, > +}; > + > +static const struct regulator_init_data dell_7212_tps68470_aux1_reg_init_data = { > + .constraints = { > + .min_uV = 1213200, > + .max_uV = 1213200, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int3479_aux1_consumer_supplies), > + .consumer_supplies = int3479_aux1_consumer_supplies, > +}; > + > +static const struct regulator_init_data dell_7212_tps68470_aux2_reg_init_data = { > + .constraints = { > + .min_uV = 1800600, > + .max_uV = 1800600, > + .apply_uV = 1, > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > + }, > + .num_consumer_supplies = ARRAY_SIZE(int3479_aux2_consumer_supplies), > + .consumer_supplies = int3479_aux2_consumer_supplies, > +}; > + > +static const struct tps68470_regulator_platform_data dell_7212_tps68470_pdata = { > + .reg_init_data = { > + [TPS68470_CORE] = &dell_7212_tps68470_core_reg_init_data, > + [TPS68470_ANA] = &dell_7212_tps68470_ana_reg_init_data, > + [TPS68470_VCM] = &dell_7212_tps68470_vcm_reg_init_data, > + [TPS68470_VIO] = &dell_7212_tps68470_vio_reg_init_data, Inconsistent spaces.
Afternoon - thanks for the review On 16/10/2024 12:58, Ilpo Järvinen wrote: > On Tue, 15 Oct 2024, Daniel Scally wrote: > >> The Dell 7212 Rugged Extreme Tablet pairs an OV5670 sensor with the >> Intel IPU3 ISP. The sensor is powered by a TPS68470 PMIC, and so we >> need some board data to describe how to configure the GPIOs and >> regulators to run the sensor. >> >> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> >> --- >> .../x86/intel/int3472/tps68470_board_data.c | 128 ++++++++++++++++++ >> 1 file changed, 128 insertions(+) >> >> diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c >> index 322237e056f3..d28053733bd2 100644 >> --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c >> +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c >> @@ -129,6 +129,109 @@ static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata = >> }, >> }; >> >> +/* Settings for Dell 7212 Tablet */ >> + >> +static struct regulator_consumer_supply int3479_vsio_consumer_supplies[] = { >> + REGULATOR_SUPPLY("avdd", "i2c-INT3479:00"), >> +}; >> + >> +static struct regulator_consumer_supply int3479_aux1_consumer_supplies[] = { >> + REGULATOR_SUPPLY("dvdd", "i2c-INT3479:00"), >> +}; >> + >> +static struct regulator_consumer_supply int3479_aux2_consumer_supplies[] = { >> + REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), >> +}; >> + >> +static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data = { >> + .constraints = { >> + .min_uV = 1200000, >> + .max_uV = 1200000, >> + .apply_uV = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + }, >> + .num_consumer_supplies = 0, >> + .consumer_supplies = NULL > Add comma to any non-terminator entry. Ack > >> +}; >> + >> +static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = { >> + .constraints = { >> + .min_uV = 2815200, >> + .max_uV = 2815200, >> + .apply_uV = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + }, >> + .num_consumer_supplies = 0, >> + .consumer_supplies = NULL >> +}; >> + >> +static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = { >> + .constraints = { >> + .min_uV = 2815200, >> + .max_uV = 2815200, >> + .apply_uV = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + }, >> + .num_consumer_supplies = 0, >> + .consumer_supplies = NULL >> +}; > This looks exactly identical to dell_7212_tps68470_ana_reg_init_data. It is the same currently, but only because I've not added the consumers yet - largely because the sensor/vcm combination that will consume these lines needs additional driver work anyway. When they're done I'd plan to add consumer definitions for these regulators too. Thanks Dan > >> +static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = { >> + .constraints = { >> + .min_uV = 1800600, >> + .max_uV = 1800600, >> + .apply_uV = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + }, >> + .num_consumer_supplies = 0, >> + .consumer_supplies = NULL, >> +}; >> + >> +static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = { >> + .constraints = { >> + .min_uV = 1800600, >> + .max_uV = 1800600, >> + .apply_uV = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + }, >> + .num_consumer_supplies = ARRAY_SIZE(int3479_vsio_consumer_supplies), >> + .consumer_supplies = int3479_vsio_consumer_supplies, >> +}; >> + >> +static const struct regulator_init_data dell_7212_tps68470_aux1_reg_init_data = { >> + .constraints = { >> + .min_uV = 1213200, >> + .max_uV = 1213200, >> + .apply_uV = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + }, >> + .num_consumer_supplies = ARRAY_SIZE(int3479_aux1_consumer_supplies), >> + .consumer_supplies = int3479_aux1_consumer_supplies, >> +}; >> + >> +static const struct regulator_init_data dell_7212_tps68470_aux2_reg_init_data = { >> + .constraints = { >> + .min_uV = 1800600, >> + .max_uV = 1800600, >> + .apply_uV = 1, >> + .valid_ops_mask = REGULATOR_CHANGE_STATUS, >> + }, >> + .num_consumer_supplies = ARRAY_SIZE(int3479_aux2_consumer_supplies), >> + .consumer_supplies = int3479_aux2_consumer_supplies, >> +}; >> + >> +static const struct tps68470_regulator_platform_data dell_7212_tps68470_pdata = { >> + .reg_init_data = { >> + [TPS68470_CORE] = &dell_7212_tps68470_core_reg_init_data, >> + [TPS68470_ANA] = &dell_7212_tps68470_ana_reg_init_data, >> + [TPS68470_VCM] = &dell_7212_tps68470_vcm_reg_init_data, >> + [TPS68470_VIO] = &dell_7212_tps68470_vio_reg_init_data, > Inconsistent spaces. >
On Wed, 16 Oct 2024, Dan Scally wrote: > Afternoon - thanks for the review > > On 16/10/2024 12:58, Ilpo Järvinen wrote: > > On Tue, 15 Oct 2024, Daniel Scally wrote: > > > > > The Dell 7212 Rugged Extreme Tablet pairs an OV5670 sensor with the > > > Intel IPU3 ISP. The sensor is powered by a TPS68470 PMIC, and so we > > > need some board data to describe how to configure the GPIOs and > > > regulators to run the sensor. > > > > > > Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> > > > --- > > > .../x86/intel/int3472/tps68470_board_data.c | 128 ++++++++++++++++++ > > > 1 file changed, 128 insertions(+) > > > > > > diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c > > > b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > > > index 322237e056f3..d28053733bd2 100644 > > > --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c > > > +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c > > > @@ -129,6 +129,109 @@ static const struct tps68470_regulator_platform_data > > > surface_go_tps68470_pdata = > > > }, > > > }; > > > +/* Settings for Dell 7212 Tablet */ > > > + > > > +static struct regulator_consumer_supply int3479_vsio_consumer_supplies[] > > > = { > > > + REGULATOR_SUPPLY("avdd", "i2c-INT3479:00"), > > > +}; > > > + > > > +static struct regulator_consumer_supply int3479_aux1_consumer_supplies[] > > > = { > > > + REGULATOR_SUPPLY("dvdd", "i2c-INT3479:00"), > > > +}; > > > + > > > +static struct regulator_consumer_supply int3479_aux2_consumer_supplies[] > > > = { > > > + REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), > > > +}; > > > + > > > +static const struct regulator_init_data > > > dell_7212_tps68470_core_reg_init_data = { > > > + .constraints = { > > > + .min_uV = 1200000, > > > + .max_uV = 1200000, > > > + .apply_uV = 1, > > > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > > > + }, > > > + .num_consumer_supplies = 0, > > > + .consumer_supplies = NULL > > Add comma to any non-terminator entry. > Ack > > > > > +}; > > > + > > > +static const struct regulator_init_data > > > dell_7212_tps68470_ana_reg_init_data = { > > > + .constraints = { > > > + .min_uV = 2815200, > > > + .max_uV = 2815200, > > > + .apply_uV = 1, > > > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > > > + }, > > > + .num_consumer_supplies = 0, > > > + .consumer_supplies = NULL > > > +}; > > > + > > > +static const struct regulator_init_data > > > dell_7212_tps68470_vcm_reg_init_data = { > > > + .constraints = { > > > + .min_uV = 2815200, > > > + .max_uV = 2815200, > > > + .apply_uV = 1, > > > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > > > + }, > > > + .num_consumer_supplies = 0, > > > + .consumer_supplies = NULL > > > +}; > > This looks exactly identical to dell_7212_tps68470_ana_reg_init_data. > > It is the same currently, but only because I've not added the consumers yet - > largely because the sensor/vcm combination that will consume these lines needs > additional driver work anyway. When they're done I'd plan to add consumer > definitions for these regulators too. Fair enough. Thanks. -- i. > Thanks > > Dan > > > > > > +static const struct regulator_init_data > > > dell_7212_tps68470_vio_reg_init_data = { > > > + .constraints = { > > > + .min_uV = 1800600, > > > + .max_uV = 1800600, > > > + .apply_uV = 1, > > > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > > > + }, > > > + .num_consumer_supplies = 0, > > > + .consumer_supplies = NULL, > > > +}; > > > + > > > +static const struct regulator_init_data > > > dell_7212_tps68470_vsio_reg_init_data = { > > > + .constraints = { > > > + .min_uV = 1800600, > > > + .max_uV = 1800600, > > > + .apply_uV = 1, > > > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > > > + }, > > > + .num_consumer_supplies = ARRAY_SIZE(int3479_vsio_consumer_supplies), > > > + .consumer_supplies = int3479_vsio_consumer_supplies, > > > +}; > > > + > > > +static const struct regulator_init_data > > > dell_7212_tps68470_aux1_reg_init_data = { > > > + .constraints = { > > > + .min_uV = 1213200, > > > + .max_uV = 1213200, > > > + .apply_uV = 1, > > > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > > > + }, > > > + .num_consumer_supplies = ARRAY_SIZE(int3479_aux1_consumer_supplies), > > > + .consumer_supplies = int3479_aux1_consumer_supplies, > > > +}; > > > + > > > +static const struct regulator_init_data > > > dell_7212_tps68470_aux2_reg_init_data = { > > > + .constraints = { > > > + .min_uV = 1800600, > > > + .max_uV = 1800600, > > > + .apply_uV = 1, > > > + .valid_ops_mask = REGULATOR_CHANGE_STATUS, > > > + }, > > > + .num_consumer_supplies = ARRAY_SIZE(int3479_aux2_consumer_supplies), > > > + .consumer_supplies = int3479_aux2_consumer_supplies, > > > +}; > > > + > > > +static const struct tps68470_regulator_platform_data > > > dell_7212_tps68470_pdata = { > > > + .reg_init_data = { > > > + [TPS68470_CORE] = &dell_7212_tps68470_core_reg_init_data, > > > + [TPS68470_ANA] = &dell_7212_tps68470_ana_reg_init_data, > > > + [TPS68470_VCM] = &dell_7212_tps68470_vcm_reg_init_data, > > > + [TPS68470_VIO] = &dell_7212_tps68470_vio_reg_init_data, > > Inconsistent spaces. > > >
diff --git a/drivers/platform/x86/intel/int3472/tps68470_board_data.c b/drivers/platform/x86/intel/int3472/tps68470_board_data.c index 322237e056f3..d28053733bd2 100644 --- a/drivers/platform/x86/intel/int3472/tps68470_board_data.c +++ b/drivers/platform/x86/intel/int3472/tps68470_board_data.c @@ -129,6 +129,109 @@ static const struct tps68470_regulator_platform_data surface_go_tps68470_pdata = }, }; +/* Settings for Dell 7212 Tablet */ + +static struct regulator_consumer_supply int3479_vsio_consumer_supplies[] = { + REGULATOR_SUPPLY("avdd", "i2c-INT3479:00"), +}; + +static struct regulator_consumer_supply int3479_aux1_consumer_supplies[] = { + REGULATOR_SUPPLY("dvdd", "i2c-INT3479:00"), +}; + +static struct regulator_consumer_supply int3479_aux2_consumer_supplies[] = { + REGULATOR_SUPPLY("dovdd", "i2c-INT3479:00"), +}; + +static const struct regulator_init_data dell_7212_tps68470_core_reg_init_data = { + .constraints = { + .min_uV = 1200000, + .max_uV = 1200000, + .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = 0, + .consumer_supplies = NULL +}; + +static const struct regulator_init_data dell_7212_tps68470_ana_reg_init_data = { + .constraints = { + .min_uV = 2815200, + .max_uV = 2815200, + .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = 0, + .consumer_supplies = NULL +}; + +static const struct regulator_init_data dell_7212_tps68470_vcm_reg_init_data = { + .constraints = { + .min_uV = 2815200, + .max_uV = 2815200, + .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = 0, + .consumer_supplies = NULL +}; + +static const struct regulator_init_data dell_7212_tps68470_vio_reg_init_data = { + .constraints = { + .min_uV = 1800600, + .max_uV = 1800600, + .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = 0, + .consumer_supplies = NULL, +}; + +static const struct regulator_init_data dell_7212_tps68470_vsio_reg_init_data = { + .constraints = { + .min_uV = 1800600, + .max_uV = 1800600, + .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = ARRAY_SIZE(int3479_vsio_consumer_supplies), + .consumer_supplies = int3479_vsio_consumer_supplies, +}; + +static const struct regulator_init_data dell_7212_tps68470_aux1_reg_init_data = { + .constraints = { + .min_uV = 1213200, + .max_uV = 1213200, + .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = ARRAY_SIZE(int3479_aux1_consumer_supplies), + .consumer_supplies = int3479_aux1_consumer_supplies, +}; + +static const struct regulator_init_data dell_7212_tps68470_aux2_reg_init_data = { + .constraints = { + .min_uV = 1800600, + .max_uV = 1800600, + .apply_uV = 1, + .valid_ops_mask = REGULATOR_CHANGE_STATUS, + }, + .num_consumer_supplies = ARRAY_SIZE(int3479_aux2_consumer_supplies), + .consumer_supplies = int3479_aux2_consumer_supplies, +}; + +static const struct tps68470_regulator_platform_data dell_7212_tps68470_pdata = { + .reg_init_data = { + [TPS68470_CORE] = &dell_7212_tps68470_core_reg_init_data, + [TPS68470_ANA] = &dell_7212_tps68470_ana_reg_init_data, + [TPS68470_VCM] = &dell_7212_tps68470_vcm_reg_init_data, + [TPS68470_VIO] = &dell_7212_tps68470_vio_reg_init_data, + [TPS68470_VSIO] = &dell_7212_tps68470_vsio_reg_init_data, + [TPS68470_AUX1] = &dell_7212_tps68470_aux1_reg_init_data, + [TPS68470_AUX2] = &dell_7212_tps68470_aux2_reg_init_data, + }, +}; + static struct gpiod_lookup_table surface_go_int347a_gpios = { .dev_id = "i2c-INT347A:00", .table = { @@ -146,6 +249,15 @@ static struct gpiod_lookup_table surface_go_int347e_gpios = { } }; +static struct gpiod_lookup_table dell_7212_int3479_gpios = { + .dev_id = "i2c-INT3479:00", + .table = { + GPIO_LOOKUP("tps68470-gpio", 3, "reset", GPIO_ACTIVE_LOW), + GPIO_LOOKUP("tps68470-gpio", 4, "powerdown", GPIO_ACTIVE_LOW), + { } + } +}; + static const struct int3472_tps68470_board_data surface_go_tps68470_board_data = { .dev_name = "i2c-INT3472:05", .tps68470_regulator_pdata = &surface_go_tps68470_pdata, @@ -166,6 +278,15 @@ static const struct int3472_tps68470_board_data surface_go3_tps68470_board_data }, }; +static const struct int3472_tps68470_board_data dell_7212_tps68470_board_data = { + .dev_name = "i2c-INT3472:05", + .tps68470_regulator_pdata = &dell_7212_tps68470_pdata, + .n_gpiod_lookups = 1, + .tps68470_gpio_lookup_tables = { + &dell_7212_int3479_gpios, + }, +}; + static const struct dmi_system_id int3472_tps68470_board_data_table[] = { { .matches = { @@ -188,6 +309,13 @@ static const struct dmi_system_id int3472_tps68470_board_data_table[] = { }, .driver_data = (void *)&surface_go3_tps68470_board_data, }, + { + .matches = { + DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Latitude 7212 Rugged Extreme Tablet"), + }, + .driver_data = (void *)&dell_7212_tps68470_board_data, + }, { } };
The Dell 7212 Rugged Extreme Tablet pairs an OV5670 sensor with the Intel IPU3 ISP. The sensor is powered by a TPS68470 PMIC, and so we need some board data to describe how to configure the GPIOs and regulators to run the sensor. Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com> --- .../x86/intel/int3472/tps68470_board_data.c | 128 ++++++++++++++++++ 1 file changed, 128 insertions(+)