mbox series

[v3,0/6] Add minimal Exynos990 SoC and SM-N981B support

Message ID 20241016154747.64343-1-igor.belwon@mentallysanemainliners.org (mailing list archive)
Headers show
Series Add minimal Exynos990 SoC and SM-N981B support | expand

Message

Igor Belwon Oct. 16, 2024, 3:47 p.m. UTC
Hi folks,

This series adds initial support for the Exynos 990 SoC and also
initial board support for the Samsung Galaxy Note20 5G (SM-N981B)
codenamed c1s.

The Exynos 990 SoC is also used in the S20 series, as well as in the
Note 20 Ultra phones. Currently the device trees added are for the
Exynos 990 SoC and c1s. The device tree has been tested with 
dtbs_check W=1 and results in no warnings.

This initial bringup consists of:
 * cpus
 * pinctrl
 * gpio-keys
 * simple-framebuffer
 
This is enough to reach a shell in an initramfs. More platform support
will be added in the future.

The preferred way to boot the upstream kernel is by using a shim
bootloader, called uniLoader [1], which works around some issues with
the stock, non-replacable Samsung S-LK bootloader. For example, the
stock bootloader leaves the decon trigger control unset, which causes
the framebuffer not to refresh.

Device functionality depends on the 2nd patch series:
"Add Exynos990 pinctrl and chipid drivers"

[1] https://github.com/ivoszbg/uniLoader

Changes in v3:
 - Move pinctrl DT nodes from the 2nd patch series
 - Resend patches to the correct lists.

Changes in v2:
 - Added acked-by tag by Rob Herring
 - Fixed two stray newlines in SoC and device DTs
 - Fixed commit message for the c1s device tree
 - Changed osc-clock to clock-osc and ordered nodes in SoC DT
 - Fixed ordering in the gic node in SoC DT
 - Fixed memory node unit address
 - Fixed memory node reg properties, to map all available RAM
 - Moved pinctrl binding commits to the 2nd patch series.

Kind regards,
Igor

Igor Belwon (6):
  dt-bindings: arm: cpus: Add Samsung Mongoose M5
  dt-bindings: hwinfo: exynos-chipid: Add compatible for Exynos 990
    chipid
  dt-bindings: arm: samsung: samsung-boards: Add bindings for Exynos 990
    boards
  soc: samsung: exynos-chipid: Add support for Exynos 990 chipid
  arm64: dts: exynos: Add initial support for the Exynos 990 SoC
  arm64: dts: exynos: Add initial support for Samsung Galaxy Note20 5G
    (c1s)

 .../devicetree/bindings/arm/cpus.yaml         |    1 +
 .../bindings/arm/samsung/samsung-boards.yaml  |    6 +
 .../hwinfo/samsung,exynos-chipid.yaml         |    1 +
 arch/arm64/boot/dts/exynos/Makefile           |    1 +
 arch/arm64/boot/dts/exynos/exynos990-c1s.dts  |  115 +
 .../boot/dts/exynos/exynos990-pinctrl.dtsi    | 2195 +++++++++++++++++
 arch/arm64/boot/dts/exynos/exynos990.dtsi     |  251 ++
 drivers/soc/samsung/exynos-chipid.c           |    1 +
 8 files changed, 2571 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-c1s.dts
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-pinctrl.dtsi
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990.dtsi

Comments

Krzysztof Kozlowski Oct. 17, 2024, 8:03 a.m. UTC | #1
On Wed, 16 Oct 2024 17:47:41 +0200, Igor Belwon wrote:
> This series adds initial support for the Exynos 990 SoC and also
> initial board support for the Samsung Galaxy Note20 5G (SM-N981B)
> codenamed c1s.
> 
> The Exynos 990 SoC is also used in the S20 series, as well as in the
> Note 20 Ultra phones. Currently the device trees added are for the
> Exynos 990 SoC and c1s. The device tree has been tested with
> dtbs_check W=1 and results in no warnings.
> 
> [...]

Applied, thanks!

[1/6] dt-bindings: arm: cpus: Add Samsung Mongoose M5
      https://git.kernel.org/krzk/linux/c/0d16910e899d0645e45128102c5113836eaf9bc1
[3/6] dt-bindings: arm: samsung: samsung-boards: Add bindings for Exynos 990 boards
      https://git.kernel.org/krzk/linux/c/f7aeff28f2768443a49600625b6f3d0aad1fdd52
[5/6] arm64: dts: exynos: Add initial support for the Exynos 990 SoC
      https://git.kernel.org/krzk/linux/c/1e5f14efd65caf1d173af8fb4eeb3e04b2625ad3
[6/6] arm64: dts: exynos: Add initial support for Samsung Galaxy Note20 5G (c1s)
      https://git.kernel.org/krzk/linux/c/8354f854a90bcecd32dc1dc9646e805d60e96f0a

Best regards,
Krzysztof Kozlowski Oct. 17, 2024, 8:04 a.m. UTC | #2
On 17/10/2024 10:03, Krzysztof Kozlowski wrote:
> 
> On Wed, 16 Oct 2024 17:47:41 +0200, Igor Belwon wrote:
>> This series adds initial support for the Exynos 990 SoC and also
>> initial board support for the Samsung Galaxy Note20 5G (SM-N981B)
>> codenamed c1s.
>>
>> The Exynos 990 SoC is also used in the S20 series, as well as in the
>> Note 20 Ultra phones. Currently the device trees added are for the
>> Exynos 990 SoC and c1s. The device tree has been tested with
>> dtbs_check W=1 and results in no warnings.
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/6] dt-bindings: arm: cpus: Add Samsung Mongoose M5
>       https://git.kernel.org/krzk/linux/c/0d16910e899d0645e45128102c5113836eaf9bc1
> [3/6] dt-bindings: arm: samsung: samsung-boards: Add bindings for Exynos 990 boards
>       https://git.kernel.org/krzk/linux/c/f7aeff28f2768443a49600625b6f3d0aad1fdd52
> [5/6] arm64: dts: exynos: Add initial support for the Exynos 990 SoC
>       https://git.kernel.org/krzk/linux/c/1e5f14efd65caf1d173af8fb4eeb3e04b2625ad3
> [6/6] arm64: dts: exynos: Add initial support for Samsung Galaxy Note20 5G (c1s)
>       https://git.kernel.org/krzk/linux/c/8354f854a90bcecd32dc1dc9646e805d60e96f0a

Not sure if all thank-you letters are correct, but to be clear:
I applied entire patchset. Thank you!

Best regards,
Krzysztof
Rob Herring Oct. 17, 2024, 4:26 p.m. UTC | #3
On Wed, 16 Oct 2024 17:47:41 +0200, Igor Belwon wrote:
> Hi folks,
> 
> This series adds initial support for the Exynos 990 SoC and also
> initial board support for the Samsung Galaxy Note20 5G (SM-N981B)
> codenamed c1s.
> 
> The Exynos 990 SoC is also used in the S20 series, as well as in the
> Note 20 Ultra phones. Currently the device trees added are for the
> Exynos 990 SoC and c1s. The device tree has been tested with
> dtbs_check W=1 and results in no warnings.
> 
> This initial bringup consists of:
>  * cpus
>  * pinctrl
>  * gpio-keys
>  * simple-framebuffer
> 
> This is enough to reach a shell in an initramfs. More platform support
> will be added in the future.
> 
> The preferred way to boot the upstream kernel is by using a shim
> bootloader, called uniLoader [1], which works around some issues with
> the stock, non-replacable Samsung S-LK bootloader. For example, the
> stock bootloader leaves the decon trigger control unset, which causes
> the framebuffer not to refresh.
> 
> Device functionality depends on the 2nd patch series:
> "Add Exynos990 pinctrl and chipid drivers"
> 
> [1] https://github.com/ivoszbg/uniLoader
> 
> Changes in v3:
>  - Move pinctrl DT nodes from the 2nd patch series
>  - Resend patches to the correct lists.
> 
> Changes in v2:
>  - Added acked-by tag by Rob Herring
>  - Fixed two stray newlines in SoC and device DTs
>  - Fixed commit message for the c1s device tree
>  - Changed osc-clock to clock-osc and ordered nodes in SoC DT
>  - Fixed ordering in the gic node in SoC DT
>  - Fixed memory node unit address
>  - Fixed memory node reg properties, to map all available RAM
>  - Moved pinctrl binding commits to the 2nd patch series.
> 
> Kind regards,
> Igor
> 
> Igor Belwon (6):
>   dt-bindings: arm: cpus: Add Samsung Mongoose M5
>   dt-bindings: hwinfo: exynos-chipid: Add compatible for Exynos 990
>     chipid
>   dt-bindings: arm: samsung: samsung-boards: Add bindings for Exynos 990
>     boards
>   soc: samsung: exynos-chipid: Add support for Exynos 990 chipid
>   arm64: dts: exynos: Add initial support for the Exynos 990 SoC
>   arm64: dts: exynos: Add initial support for Samsung Galaxy Note20 5G
>     (c1s)
> 
>  .../devicetree/bindings/arm/cpus.yaml         |    1 +
>  .../bindings/arm/samsung/samsung-boards.yaml  |    6 +
>  .../hwinfo/samsung,exynos-chipid.yaml         |    1 +
>  arch/arm64/boot/dts/exynos/Makefile           |    1 +
>  arch/arm64/boot/dts/exynos/exynos990-c1s.dts  |  115 +
>  .../boot/dts/exynos/exynos990-pinctrl.dtsi    | 2195 +++++++++++++++++
>  arch/arm64/boot/dts/exynos/exynos990.dtsi     |  251 ++
>  drivers/soc/samsung/exynos-chipid.c           |    1 +
>  8 files changed, 2571 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-c1s.dts
>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-pinctrl.dtsi
>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990.dtsi
> 
> --
> 2.45.2
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y exynos/exynos990-c1s.dtb' for 20241016154747.64343-1-igor.belwon@mentallysanemainliners.org:

arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@10430000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@10730000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@13040000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@13c30000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@15580000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@15850000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: wakeup-interrupt-controller: compatible: 'oneOf' conditional failed, one must be fixed:
	['samsung,exynos990-wakeup-eint', 'samsung,exynos850-wakeup-eint', 'samsung,exynos7-wakeup-eint'] is too long
	'samsung,exynos990-wakeup-eint' is not one of ['samsung,s3c2410-wakeup-eint', 'samsung,s3c2412-wakeup-eint', 'samsung,s3c64xx-wakeup-eint', 'samsung,s5pv210-wakeup-eint', 'samsung,exynos4210-wakeup-eint', 'samsung,exynos7-wakeup-eint', 'samsung,exynosautov920-wakeup-eint']
	'samsung,exynos990-wakeup-eint' is not one of ['samsung,exynos5433-wakeup-eint', 'samsung,exynos7885-wakeup-eint', 'samsung,exynos850-wakeup-eint', 'samsung,exynos8895-wakeup-eint']
	'samsung,exynos990-wakeup-eint' is not one of ['google,gs101-wakeup-eint', 'samsung,exynosautov9-wakeup-eint']
	'samsung,exynos7-wakeup-eint' was expected
	from schema $id: http://devicetree.org/schemas/pinctrl/samsung,pinctrl-wakeup-interrupt.yaml#
arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@15850000/wakeup-interrupt-controller: failed to match any schema with compatible: ['samsung,exynos990-wakeup-eint', 'samsung,exynos850-wakeup-eint', 'samsung,exynos7-wakeup-eint']
arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@15c30000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
Krzysztof Kozlowski Oct. 17, 2024, 4:37 p.m. UTC | #4
On 17/10/2024 18:26, Rob Herring (Arm) wrote:
> 
> On Wed, 16 Oct 2024 17:47:41 +0200, Igor Belwon wrote:
>> Hi folks,
>>
>> This series adds initial support for the Exynos 990 SoC and also
>> initial board support for the Samsung Galaxy Note20 5G (SM-N981B)
>> codenamed c1s.
>>
>> The Exynos 990 SoC is also used in the S20 series, as well as in the
>> Note 20 Ultra phones. Currently the device trees added are for the
>> Exynos 990 SoC and c1s. The device tree has been tested with
>> dtbs_check W=1 and results in no warnings.
>>
>> This initial bringup consists of:
>>  * cpus
>>  * pinctrl
>>  * gpio-keys
>>  * simple-framebuffer
>>
>> This is enough to reach a shell in an initramfs. More platform support
>> will be added in the future.
>>
>> The preferred way to boot the upstream kernel is by using a shim
>> bootloader, called uniLoader [1], which works around some issues with
>> the stock, non-replacable Samsung S-LK bootloader. For example, the
>> stock bootloader leaves the decon trigger control unset, which causes
>> the framebuffer not to refresh.
>>
>> Device functionality depends on the 2nd patch series:
>> "Add Exynos990 pinctrl and chipid drivers"
>>
>> [1] https://github.com/ivoszbg/uniLoader
>>
>> Changes in v3:
>>  - Move pinctrl DT nodes from the 2nd patch series
>>  - Resend patches to the correct lists.
>>
>> Changes in v2:
>>  - Added acked-by tag by Rob Herring
>>  - Fixed two stray newlines in SoC and device DTs
>>  - Fixed commit message for the c1s device tree
>>  - Changed osc-clock to clock-osc and ordered nodes in SoC DT
>>  - Fixed ordering in the gic node in SoC DT
>>  - Fixed memory node unit address
>>  - Fixed memory node reg properties, to map all available RAM
>>  - Moved pinctrl binding commits to the 2nd patch series.
>>
>> Kind regards,
>> Igor
>>
>> Igor Belwon (6):
>>   dt-bindings: arm: cpus: Add Samsung Mongoose M5
>>   dt-bindings: hwinfo: exynos-chipid: Add compatible for Exynos 990
>>     chipid
>>   dt-bindings: arm: samsung: samsung-boards: Add bindings for Exynos 990
>>     boards
>>   soc: samsung: exynos-chipid: Add support for Exynos 990 chipid
>>   arm64: dts: exynos: Add initial support for the Exynos 990 SoC
>>   arm64: dts: exynos: Add initial support for Samsung Galaxy Note20 5G
>>     (c1s)
>>
>>  .../devicetree/bindings/arm/cpus.yaml         |    1 +
>>  .../bindings/arm/samsung/samsung-boards.yaml  |    6 +
>>  .../hwinfo/samsung,exynos-chipid.yaml         |    1 +
>>  arch/arm64/boot/dts/exynos/Makefile           |    1 +
>>  arch/arm64/boot/dts/exynos/exynos990-c1s.dts  |  115 +
>>  .../boot/dts/exynos/exynos990-pinctrl.dtsi    | 2195 +++++++++++++++++
>>  arch/arm64/boot/dts/exynos/exynos990.dtsi     |  251 ++
>>  drivers/soc/samsung/exynos-chipid.c           |    1 +
>>  8 files changed, 2571 insertions(+)
>>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-c1s.dts
>>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990-pinctrl.dtsi
>>  create mode 100644 arch/arm64/boot/dts/exynos/exynos990.dtsi
>>
>> --
>> 2.45.2
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>   pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y exynos/exynos990-c1s.dtb' for 20241016154747.64343-1-igor.belwon@mentallysanemainliners.org:
> 
> arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@10430000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
> arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@10730000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
> arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@13040000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']
> arch/arm64/boot/dts/exynos/exynos990-c1s.dtb: /soc@0/pinctrl@13c30000: failed to match any schema with compatible: ['samsung,exynos990-pinctrl']

These are expected, coming via different tree.

Best regards,
Krzysztof