| Message ID | cover.1729162349.git.tanggeliang@kylinos.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | fixes for "add mptcp_subflow bpf_iter" v10 | expand |
Hi Geliang,
Thank you for your modifications, that's great!
Our CI did some validations and here is its report:
- KVM Validation: normal: Success! ✅
- KVM Validation: debug: Success! ✅
- KVM Validation: btf-normal (only bpftest_all): Success! ✅
- Task: https://github.com/multipath-tcp/mptcp_net-next/actions/runs/11383799550
Initiator: Patchew Applier
Commits: https://github.com/multipath-tcp/mptcp_net-next/commits/5f1cca141423
Patchwork: https://patchwork.kernel.org/project/mptcp/list/?series=900187
If there are some issues, you can reproduce them using the same environment as
the one used by the CI thanks to a docker image, e.g.:
$ cd [kernel source code]
$ docker run -v "${PWD}:${PWD}:rw" -w "${PWD}" --privileged --rm -it \
--pull always mptcp/mptcp-upstream-virtme-docker:latest \
auto-normal
For more details:
https://github.com/multipath-tcp/mptcp-upstream-virtme-docker
Please note that despite all the efforts that have been already done to have a
stable tests suite when executed on a public CI like here, it is possible some
reported issues are not due to your modifications. Still, do not hesitate to
help us improve that ;-)
Cheers,
MPTCP GH Action bot
Bot operated by Matthieu Baerts (NGI0 Core)
From: Geliang Tang <tanggeliang@kylinos.cn> v2: - drop unused variable 'err'. There are two building errors in v10: progs/mptcp_bpf_iters.c:24:8: error: call to undeclared function 'bpf_mptcp_sk'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 24 | msk = bpf_mptcp_sk((struct sock *)sk); | ^ progs/mptcp_bpf_iters.c:24:6: error: incompatible integer to pointer conversion assigning to 'struct mptcp_sock *' from 'int' [-Wint-conversion] 24 | msk = bpf_mptcp_sk((struct sock *)sk); tools/testing/selftests/bpf/prog_tests/mptcp.c: In function 'test_iters_subflow': tools/testing/selftests/bpf/prog_tests/mptcp.c:546:13: error: unused variable 'err' [-Werror=unused-variable] 546 | int err; | ^~~ TEST-OBJ [test_progs] pe_preserve_elems.test.o bpf_mptcp_sk() definition is missing. It will be used in patch 4. An unused variable 'err' needs to be dropped. Depends on: - "add mptcp_subflow bpf_iter" v10 Based-on: <cover.1729063444.git.tanggeliang@kylinos.cn> Geliang Tang (3): Squash to "bpf: Register mptcp common kfunc set" Squash to "selftests/bpf: Add mptcp_subflow bpf_iter test prog" Squash to "selftests/bpf: Add mptcp_subflow bpf_iter subtest" net/mptcp/bpf.c | 6 ++++++ tools/testing/selftests/bpf/prog_tests/mptcp.c | 1 - tools/testing/selftests/bpf/progs/mptcp_bpf.h | 1 + 3 files changed, 7 insertions(+), 1 deletion(-)