| Message ID | 20241004103046.22209-1-quic_mukhopad@quicinc.com |
|---|---|
| Headers | show |
| Series | Add support for DisplayPort on SA8775P platform | expand |
On Fri, 4 Oct 2024 at 12:30, Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> wrote: > > This series adds support for the DisplayPort controller > and eDP PHY v5 found on the Qualcomm SA8775P platform. > > --- > v2: Fixed review comments from Dmitry and Bjorn > - Made aux_cfg array as const. > - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. > > v3: Fixed review comments from Dmitry, Konrad and Bjorn > - Used a for loop to write the dp_phy_aux_cfg registers. > - Pre-defined the aux_cfg size to prevent any magic numbers. > - Added all the necessary DPTX controllers for this platform. > > v4: Fixed review comments from Dmitry and Krzysztof > - Updated commit message. For which patches? How? > > --- > > Soutrik Mukhopadhyay (5): > dt-bindings: phy: Add eDP PHY compatible for sa8775p > phy: qcom: edp: Introduce aux_cfg array for version specific aux > settings > phy: qcom: edp: Add support for eDP PHY on SA8775P > dt-bindings: display: msm: dp-controller: document SA8775P compatible > drm/msm/dp: Add DisplayPort controller for SA8775P > > .../bindings/display/msm/dp-controller.yaml | 1 + > .../devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + > drivers/gpu/drm/msm/dp/dp_display.c | 9 +++ > drivers/phy/qualcomm/phy-qcom-edp.c | 74 +++++++++++++------ > 4 files changed, 61 insertions(+), 24 deletions(-) > > -- > 2.17.1 >
On 10/6/2024 8:30 PM, Dmitry Baryshkov wrote: > On Fri, 4 Oct 2024 at 12:30, Soutrik Mukhopadhyay > <quic_mukhopad@quicinc.com> wrote: >> This series adds support for the DisplayPort controller >> and eDP PHY v5 found on the Qualcomm SA8775P platform. >> >> --- >> v2: Fixed review comments from Dmitry and Bjorn >> - Made aux_cfg array as const. >> - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. >> >> v3: Fixed review comments from Dmitry, Konrad and Bjorn >> - Used a for loop to write the dp_phy_aux_cfg registers. >> - Pre-defined the aux_cfg size to prevent any magic numbers. >> - Added all the necessary DPTX controllers for this platform. >> >> v4: Fixed review comments from Dmitry and Krzysztof >> - Updated commit message. > For which patches? How? We have removed the "reviewed by" and kept only the "acked by" for patch 1. We have updated the commit message of patch 5 , to mention specifically about the validation of 'only' MDSS0 DPTX0 and DPTX1. > >> --- >> >> Soutrik Mukhopadhyay (5): >> dt-bindings: phy: Add eDP PHY compatible for sa8775p >> phy: qcom: edp: Introduce aux_cfg array for version specific aux >> settings >> phy: qcom: edp: Add support for eDP PHY on SA8775P >> dt-bindings: display: msm: dp-controller: document SA8775P compatible >> drm/msm/dp: Add DisplayPort controller for SA8775P >> >> .../bindings/display/msm/dp-controller.yaml | 1 + >> .../devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + >> drivers/gpu/drm/msm/dp/dp_display.c | 9 +++ >> drivers/phy/qualcomm/phy-qcom-edp.c | 74 +++++++++++++------ >> 4 files changed, 61 insertions(+), 24 deletions(-) >> >> -- >> 2.17.1 >> >
On Tue, 15 Oct 2024 at 10:02, Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> wrote: > > > On 10/6/2024 8:30 PM, Dmitry Baryshkov wrote: > > On Fri, 4 Oct 2024 at 12:30, Soutrik Mukhopadhyay > > <quic_mukhopad@quicinc.com> wrote: > >> This series adds support for the DisplayPort controller > >> and eDP PHY v5 found on the Qualcomm SA8775P platform. > >> > >> --- > >> v2: Fixed review comments from Dmitry and Bjorn > >> - Made aux_cfg array as const. > >> - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. > >> > >> v3: Fixed review comments from Dmitry, Konrad and Bjorn > >> - Used a for loop to write the dp_phy_aux_cfg registers. > >> - Pre-defined the aux_cfg size to prevent any magic numbers. > >> - Added all the necessary DPTX controllers for this platform. > >> > >> v4: Fixed review comments from Dmitry and Krzysztof > >> - Updated commit message. > > For which patches? How? > > > We have removed the "reviewed by" and kept only the "acked by" for patch > 1. We have updated > > the commit message of patch 5 , to mention specifically about the > validation of 'only' MDSS0 DPTX0 and > > DPTX1. All of this must be a part of the changelog. It's not enough to say "updated messages" or "fixed comments". At least please let the reviewers know which patches have changed and which didn't. > > > > > >> --- > >> > >> Soutrik Mukhopadhyay (5): > >> dt-bindings: phy: Add eDP PHY compatible for sa8775p > >> phy: qcom: edp: Introduce aux_cfg array for version specific aux > >> settings > >> phy: qcom: edp: Add support for eDP PHY on SA8775P > >> dt-bindings: display: msm: dp-controller: document SA8775P compatible > >> drm/msm/dp: Add DisplayPort controller for SA8775P > >> > >> .../bindings/display/msm/dp-controller.yaml | 1 + > >> .../devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + > >> drivers/gpu/drm/msm/dp/dp_display.c | 9 +++ > >> drivers/phy/qualcomm/phy-qcom-edp.c | 74 +++++++++++++------ > >> 4 files changed, 61 insertions(+), 24 deletions(-) > >> > >> -- > >> 2.17.1 > >> > >
On Fri, 04 Oct 2024 16:00:41 +0530, Soutrik Mukhopadhyay wrote: > This series adds support for the DisplayPort controller > and eDP PHY v5 found on the Qualcomm SA8775P platform. > Applied, thanks! [1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p commit: 7adb3d221a4d6a4f5e0793c3bd35f1168934035c [2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings commit: 913463587d528d766a8e12c7790995e273ec84fb [3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P commit: 3f12bf16213c30d8e645027efd94a19c13ee0253 Best regards,
This series adds support for the DisplayPort controller and eDP PHY v5 found on the Qualcomm SA8775P platform. --- v2: Fixed review comments from Dmitry and Bjorn - Made aux_cfg array as const. - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. v3: Fixed review comments from Dmitry, Konrad and Bjorn - Used a for loop to write the dp_phy_aux_cfg registers. - Pre-defined the aux_cfg size to prevent any magic numbers. - Added all the necessary DPTX controllers for this platform. v4: Fixed review comments from Dmitry and Krzysztof - Updated commit message. --- Soutrik Mukhopadhyay (5): dt-bindings: phy: Add eDP PHY compatible for sa8775p phy: qcom: edp: Introduce aux_cfg array for version specific aux settings phy: qcom: edp: Add support for eDP PHY on SA8775P dt-bindings: display: msm: dp-controller: document SA8775P compatible drm/msm/dp: Add DisplayPort controller for SA8775P .../bindings/display/msm/dp-controller.yaml | 1 + .../devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + drivers/gpu/drm/msm/dp/dp_display.c | 9 +++ drivers/phy/qualcomm/phy-qcom-edp.c | 74 +++++++++++++------ 4 files changed, 61 insertions(+), 24 deletions(-)