| Message ID | 20241018072217.97909-1-zenghongling@kylinos.cn (mailing list archive) |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [PATH] platform/x86: classmate-laptop: Replace snprintf in show functions with sysfs_emit | expand |
On Fri, 18 Oct 2024, zenghongling wrote: > show() must not use snprintf() when formatting the value to be Extra spaces. > returned to user space. > > Signed-off-by: zenghongling <zenghongling@kylinos.cn> Could you please add spaces and the usual capitalization to your name (both into the Signed-off-by and From). It is possible to use git config to set up your user.name to get the name formatting to stick. -- i. > --- > drivers/platform/x86/classmate-laptop.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c > index cb6fce6..14c238f 100644 > --- a/drivers/platform/x86/classmate-laptop.c > +++ b/drivers/platform/x86/classmate-laptop.c > @@ -208,7 +208,7 @@ static ssize_t cmpc_accel_sensitivity_show_v4(struct device *dev, > inputdev = dev_get_drvdata(&acpi->dev); > accel = dev_get_drvdata(&inputdev->dev); > > - return sprintf(buf, "%d\n", accel->sensitivity); > + return sysfs_emit(buf, "%d\n", accel->sensitivity); > } > > static ssize_t cmpc_accel_sensitivity_store_v4(struct device *dev, > @@ -257,7 +257,7 @@ static ssize_t cmpc_accel_g_select_show_v4(struct device *dev, > inputdev = dev_get_drvdata(&acpi->dev); > accel = dev_get_drvdata(&inputdev->dev); > > - return sprintf(buf, "%d\n", accel->g_select); > + return sysfs_emit(buf, "%d\n", accel->g_select); > } > > static ssize_t cmpc_accel_g_select_store_v4(struct device *dev, > @@ -550,7 +550,7 @@ static ssize_t cmpc_accel_sensitivity_show(struct device *dev, > inputdev = dev_get_drvdata(&acpi->dev); > accel = dev_get_drvdata(&inputdev->dev); > > - return sprintf(buf, "%d\n", accel->sensitivity); > + return sysfs_emit(buf, "%d\n", accel->sensitivity); > } > > static ssize_t cmpc_accel_sensitivity_store(struct device *dev, >
diff --git a/drivers/platform/x86/classmate-laptop.c b/drivers/platform/x86/classmate-laptop.c index cb6fce6..14c238f 100644 --- a/drivers/platform/x86/classmate-laptop.c +++ b/drivers/platform/x86/classmate-laptop.c @@ -208,7 +208,7 @@ static ssize_t cmpc_accel_sensitivity_show_v4(struct device *dev, inputdev = dev_get_drvdata(&acpi->dev); accel = dev_get_drvdata(&inputdev->dev); - return sprintf(buf, "%d\n", accel->sensitivity); + return sysfs_emit(buf, "%d\n", accel->sensitivity); } static ssize_t cmpc_accel_sensitivity_store_v4(struct device *dev, @@ -257,7 +257,7 @@ static ssize_t cmpc_accel_g_select_show_v4(struct device *dev, inputdev = dev_get_drvdata(&acpi->dev); accel = dev_get_drvdata(&inputdev->dev); - return sprintf(buf, "%d\n", accel->g_select); + return sysfs_emit(buf, "%d\n", accel->g_select); } static ssize_t cmpc_accel_g_select_store_v4(struct device *dev, @@ -550,7 +550,7 @@ static ssize_t cmpc_accel_sensitivity_show(struct device *dev, inputdev = dev_get_drvdata(&acpi->dev); accel = dev_get_drvdata(&inputdev->dev); - return sprintf(buf, "%d\n", accel->sensitivity); + return sysfs_emit(buf, "%d\n", accel->sensitivity); } static ssize_t cmpc_accel_sensitivity_store(struct device *dev,
show() must not use snprintf() when formatting the value to be returned to user space. Signed-off-by: zenghongling <zenghongling@kylinos.cn> --- drivers/platform/x86/classmate-laptop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)