| Message ID | 20241018105911.165415-1-quic_bpothuno@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2] remoteproc: qcom_q6v5_pas: disable auto boot for wpss | expand |
On Fri, Oct 18, 2024 at 04:29:11PM +0530, Balaji Pothunoori wrote: > Currently, the rproc "atomic_t power" variable is incremented during: > a. WPSS rproc auto boot. > b. AHB power on for ath11k. > > During AHB power off (rmmod ath11k_ahb.ko), rproc_shutdown fails > to unload the WPSS firmware because the rproc->power value is '2', > causing the atomic_dec_and_test(&rproc->power) condition to fail. > > Consequently, during AHB power on (insmod ath11k_ahb.ko), > QMI_WLANFW_HOST_CAP_REQ_V01 fails due to the host and firmware QMI > states being out of sync. > > Fixes: 300ed425dfa9 ("remoteproc: qcom_q6v5_pas: Add SC7280 ADSP, CDSP & WPSS") > Cc: stable@vger.kernel.org > Signed-off-by: Balaji Pothunoori <quic_bpothuno@quicinc.com> > --- > v2: updated commit text. > added Fixes/cc:stable tags. > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index ef82835e98a4..05963d7924df 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -1344,7 +1344,7 @@ static const struct adsp_data sc7280_wpss_resource = { .crash_reason_smem = 626, .firmware_name = "wpss.mdt", .pas_id = 6, - .auto_boot = true, + .auto_boot = false, .proxy_pd_names = (char*[]){ "cx", "mx",
Currently, the rproc "atomic_t power" variable is incremented during: a. WPSS rproc auto boot. b. AHB power on for ath11k. During AHB power off (rmmod ath11k_ahb.ko), rproc_shutdown fails to unload the WPSS firmware because the rproc->power value is '2', causing the atomic_dec_and_test(&rproc->power) condition to fail. Consequently, during AHB power on (insmod ath11k_ahb.ko), QMI_WLANFW_HOST_CAP_REQ_V01 fails due to the host and firmware QMI states being out of sync. Fixes: 300ed425dfa9 ("remoteproc: qcom_q6v5_pas: Add SC7280 ADSP, CDSP & WPSS") Cc: stable@vger.kernel.org Signed-off-by: Balaji Pothunoori <quic_bpothuno@quicinc.com> --- v2: updated commit text. added Fixes/cc:stable tags. drivers/remoteproc/qcom_q6v5_pas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)