| Message ID | 20241014031234.7659-1-xuanzhuo@linux.alibaba.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | virtio_net: enable premapped mode by default | expand |
On Mon, Oct 14, 2024 at 11:12:29AM +0800, Xuan Zhuo wrote: > In the last linux version, we disabled this feature to fix the > regress[1]. > > The patch set is try to fix the problem and re-enable it. > > More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com > > Thanks. > > [1]: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com Darren, you previously reported crashes with a patch very similar to 1/5. Can you please test this patchset and report whether they are still observed? If yes, any data on how to reproduce would be very benefitial for Xuan Zhuo. > Xuan Zhuo (5): > virtio-net: fix overflow inside virtnet_rq_alloc > virtio_net: introduce vi->mode > virtio_net: big mode skip the unmap check > virtio_net: enable premapped mode for merge and small by default > virtio_net: rx remove premapped failover code > > drivers/net/virtio_net.c | 168 ++++++++++++++++++++++++--------------- > 1 file changed, 105 insertions(+), 63 deletions(-) > > -- > 2.32.0.3.g01195cf9f
Hi Michael, On Monday, 2024-10-14 at 00:57:41 -04, Michael S. Tsirkin wrote: > On Mon, Oct 14, 2024 at 11:12:29AM +0800, Xuan Zhuo wrote: >> In the last linux version, we disabled this feature to fix the >> regress[1]. >> >> The patch set is try to fix the problem and re-enable it. >> >> More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com >> >> Thanks. >> >> [1]: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com > > Darren, you previously reported crashes with a patch very similar to 1/5. > Can you please test this patchset and report whether they > are still observed? > If yes, any data on how to reproduce would be very benefitial for Xuan > Zhuo. > I aim to get to this in the next week, but I don't currently have access to a system to test it, it will take a few days at least before I can get one. Thanks, Darren. > >> Xuan Zhuo (5): >> virtio-net: fix overflow inside virtnet_rq_alloc >> virtio_net: introduce vi->mode >> virtio_net: big mode skip the unmap check >> virtio_net: enable premapped mode for merge and small by default >> virtio_net: rx remove premapped failover code >> >> drivers/net/virtio_net.c | 168 ++++++++++++++++++++++++--------------- >> 1 file changed, 105 insertions(+), 63 deletions(-) >> >> -- >> 2.32.0.3.g01195cf9f
Hi Michael / Xuan Zhuo, On Wednesday, 2024-10-16 at 08:55:21 +01, Darren Kenny wrote: > Hi Michael, > > On Monday, 2024-10-14 at 00:57:41 -04, Michael S. Tsirkin wrote: >> On Mon, Oct 14, 2024 at 11:12:29AM +0800, Xuan Zhuo wrote: >>> In the last linux version, we disabled this feature to fix the >>> regress[1]. >>> >>> The patch set is try to fix the problem and re-enable it. >>> >>> More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com >>> >>> Thanks. >>> >>> [1]: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com >> >> Darren, you previously reported crashes with a patch very similar to 1/5. >> Can you please test this patchset and report whether they >> are still observed? >> If yes, any data on how to reproduce would be very benefitial for Xuan >> Zhuo. >> > > I aim to get to this in the next week, but I don't currently have > access to a system to test it, it will take a few days at least before I > can get one. I finally a managed to get access to a system to test this on, and it looks like things are working with this patch-set. So... Tested-by: Darren Kenny <darren.kenny@oracle.com> Thanks, Darren.
On Fri, Oct 18, 2024 at 03:59:14PM +0100, Darren Kenny wrote: > Hi Michael / Xuan Zhuo, > > On Wednesday, 2024-10-16 at 08:55:21 +01, Darren Kenny wrote: > > Hi Michael, > > > > On Monday, 2024-10-14 at 00:57:41 -04, Michael S. Tsirkin wrote: > >> On Mon, Oct 14, 2024 at 11:12:29AM +0800, Xuan Zhuo wrote: > >>> In the last linux version, we disabled this feature to fix the > >>> regress[1]. > >>> > >>> The patch set is try to fix the problem and re-enable it. > >>> > >>> More info: http://lore.kernel.org/all/20240820071913.68004-1-xuanzhuo@linux.alibaba.com > >>> > >>> Thanks. > >>> > >>> [1]: http://lore.kernel.org/all/8b20cc28-45a9-4643-8e87-ba164a540c0a@oracle.com > >> > >> Darren, you previously reported crashes with a patch very similar to 1/5. > >> Can you please test this patchset and report whether they > >> are still observed? > >> If yes, any data on how to reproduce would be very benefitial for Xuan > >> Zhuo. > >> > > > > I aim to get to this in the next week, but I don't currently have > > access to a system to test it, it will take a few days at least before I > > can get one. > > I finally a managed to get access to a system to test this on, and it > looks like things are working with this patch-set. So... > > Tested-by: Darren Kenny <darren.kenny@oracle.com> > > Thanks, > > Darren. Thanks a lot Darren!