diff mbox series

selftests/net: Add missing va_end in test_snprintf

Message ID 20241017075251.127762-1-liujing@cmss.chinamobile.com (mailing list archive)
State Not Applicable
Delegated to: Netdev Maintainers
Headers show
Series selftests/net: Add missing va_end in test_snprintf | expand

Checks

Context Check Description
netdev/tree_selection success Guessing tree name failed - patch did not apply

Commit Message

liujing Oct. 17, 2024, 7:52 a.m. UTC 
There is no va_end after va_copy, just add it.

Signed-off-by: Liu Jing <liujing_yewu@cmss.chinamobile.com>
Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com>
---
 tools/testing/selftests/net/tcp_ao/lib/aolib.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Horman Oct. 19, 2024, 7:57 a.m. UTC | #1 
On Thu, Oct 17, 2024 at 03:52:51PM +0800, Liu Jing wrote:
> There is no va_end after va_copy, just add it.
> 
> Signed-off-by: Liu Jing <liujing_yewu@cmss.chinamobile.com>
> Signed-off-by: Liu Jing <liujing@cmss.chinamobile.com>

Thanks,

This is correct. However, it was fixed recently in the same way
by the following commit authored by one of your colleagues, Zhang Jiao:

- 7c2f1c2690a5 ("selftests/net: Add missing va_end.")
  https://git.kernel.org/netdev/net-next/c/7c2f1c2690a5
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/tcp_ao/lib/aolib.h b/tools/testing/selftests/net/tcp_ao/lib/aolib.h
index db44e77428dd..5db2f65cddc4 100644
--- a/tools/testing/selftests/net/tcp_ao/lib/aolib.h
+++ b/tools/testing/selftests/net/tcp_ao/lib/aolib.h
@@ -46,6 +46,7 @@  static inline char *test_snprintf(const char *fmt, va_list vargs)
 
 	va_copy(tmp, vargs);
 	n = vsnprintf(ret, size, fmt, tmp);
+	va_end(tmp);
 	if (n < 0)
 		return NULL;