diff mbox series

eth: fbnic: add CONFIG_PTP_1588_CLOCK_OPTIONAL dependency

Message ID 20241016062303.2551686-1-arnd@kernel.org (mailing list archive)
State Accepted
Commit d3296a9d0bc2576a8e3dee7925d6f47e1f225fc2
Delegated to: Netdev Maintainers
Headers show
Series eth: fbnic: add CONFIG_PTP_1588_CLOCK_OPTIONAL dependency | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 8 of 8 maintainers
netdev/build_clang success Errors and warnings before: 4 this patch: 4
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-19--00-00 (tests: 777)

Commit Message

Arnd Bergmann Oct. 16, 2024, 6:22 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

fbnic fails to link as built-in when PTP support is in a loadable
module:

aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_ethtool.o: in function `fbnic_get_ts_info':
fbnic_ethtool.c:(.text+0x428): undefined reference to `ptp_clock_index'
aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_time_start':
fbnic_time.c:(.text+0x820): undefined reference to `ptp_schedule_worker'
aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_ptp_setup':
fbnic_time.c:(.text+0xa68): undefined reference to `ptp_clock_register'

Add the appropriate dependency to enforce this.

Fixes: 6a2b3ede9543 ("eth: fbnic: add RX packets timestamping support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/net/ethernet/meta/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Vadim Fedorenko Oct. 16, 2024, 7:46 a.m. UTC | #1 
On 16/10/2024 07:22, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> fbnic fails to link as built-in when PTP support is in a loadable
> module:
> 
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_ethtool.o: in function `fbnic_get_ts_info':
> fbnic_ethtool.c:(.text+0x428): undefined reference to `ptp_clock_index'
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_time_start':
> fbnic_time.c:(.text+0x820): undefined reference to `ptp_schedule_worker'
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_ptp_setup':
> fbnic_time.c:(.text+0xa68): undefined reference to `ptp_clock_register'
> 
> Add the appropriate dependency to enforce this.
> 
> Fixes: 6a2b3ede9543 ("eth: fbnic: add RX packets timestamping support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks!
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
patchwork-bot+netdevbpf@kernel.org Oct. 20, 2024, 4:10 p.m. UTC | #2 
Hello:

This patch was applied to netdev/net-next.git (main)
by Andrew Lunn <andrew@lunn.ch>:

On Wed, 16 Oct 2024 06:22:58 +0000 you wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> fbnic fails to link as built-in when PTP support is in a loadable
> module:
> 
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_ethtool.o: in function `fbnic_get_ts_info':
> fbnic_ethtool.c:(.text+0x428): undefined reference to `ptp_clock_index'
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_time_start':
> fbnic_time.c:(.text+0x820): undefined reference to `ptp_schedule_worker'
> aarch64-linux-ld: drivers/net/ethernet/meta/fbnic/fbnic_time.o: in function `fbnic_ptp_setup':
> fbnic_time.c:(.text+0xa68): undefined reference to `ptp_clock_register'
> 
> [...]

Here is the summary with links:
  - eth: fbnic: add CONFIG_PTP_1588_CLOCK_OPTIONAL dependency
    https://git.kernel.org/netdev/net-next/c/d3296a9d0bc2

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/meta/Kconfig b/drivers/net/ethernet/meta/Kconfig
index 85519690b837..831921b9d4d5 100644
--- a/drivers/net/ethernet/meta/Kconfig
+++ b/drivers/net/ethernet/meta/Kconfig
@@ -23,6 +23,7 @@  config FBNIC
 	depends on !S390
 	depends on MAX_SKB_FRAGS < 22
 	depends on PCI_MSI
+	depends on PTP_1588_CLOCK_OPTIONAL
 	select NET_DEVLINK
 	select PAGE_POOL
 	select PHYLINK