[v2,0/7] Cleanup Clippy issues in drm_panic_qr.rs

Message

Thomas Böhler Oct. 19, 2024, 8:22 a.m. UTC

The file drivers/gpu/drm/drm_panic_qr.rs has some lints that Clippy
complains about. This series cleans them up by either allowing what is
written or conforming to what Clippy expects where it makes sense.

All explicitly allowed lints are marked with `#[expect(...)]`.

v1 -> v2:
- Add "Fixes" trailers and rename "Closes" to "Link" trailers as
  the patches all fix part of the issue.
- Replace `#[allow(...)]` with `#[expect(...)]`. Support for `expect` is
  already in rust-next, which is where this series will be merged into.

Thomas Böhler (7):
  drm/panic: avoid reimplementing Iterator::find
  drm/panic: remove unnecessary borrow in alignment_pattern
  drm/panic: prefer eliding lifetimes
  drm/panic: remove redundant field when assigning value
  drm/panic: correctly indent continuation of line in list item
  drm/panic: allow verbose boolean for clarity
  drm/panic: allow verbose version check

 drivers/gpu/drm/drm_panic_qr.rs | 23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)

Comments

Miguel Ojeda Oct. 20, 2024, 9:04 p.m. UTC | #1

On Sat, Oct 19, 2024 at 10:41 AM Thomas Böhler <[e-mail]> wrote:
>
> The file drivers/gpu/drm/drm_panic_qr.rs has some lints that Clippy
> complains about. This series cleans them up by either allowing what is
> written or conforming to what Clippy expects where it makes sense.

Applied to `rust-next` -- thanks everyone!

    [ Reworded to indent Clippy's message. - Miguel ]

    [ Reworded to add Clippy warning like it is done in the rest of the
      series. - Miguel ]

    [ Reworded to mention the redundant closure cleanup too. - Miguel ]

Cheers,
Miguel