| Message ID | 20241019-bridge-yuv420-v1-0-d74efac9e4e6@linaro.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/bridge: add ycbcr_420_allowed support | expand |
On Sat, 19 Oct 2024 00:49:11 +0300, Dmitry Baryshkov wrote: > One of the features that drm_bridge_connector can't handle currently is > setting of the ycbcr_420_allowed flag on the connector. Add the flag to > the drm_bridge struct and propagate it to the drm_connector as AND of > all flags in the bridge chain. > > > [ ... ] Reviewed-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
Hi, On 18/10/2024 23:49, Dmitry Baryshkov wrote: > One of the features that drm_bridge_connector can't handle currently is > setting of the ycbcr_420_allowed flag on the connector. Add the flag to > the drm_bridge struct and propagate it to the drm_connector as AND of > all flags in the bridge chain. > > As an example of the conversion, enable the flag on the DW HDMI bridge, > MSM DP bridge, display connector drivers (for DisplayPort and HDMI > outputs) and AUX bridges. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > Dmitry Baryshkov (6): > drm/display: bridge_connector: handle ycbcr_420_allowed > drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump > drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP > drm/bridge: aux: allow interlaced and YCbCr 420 output > drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge How do you plan to merge this serie ? > drm/bridge: dw-hdmi: set bridge's ycbcr_420_allowed flag > > drivers/gpu/drm/bridge/aux-bridge.c | 4 ++++ > drivers/gpu/drm/bridge/aux-hpd-bridge.c | 4 ++++ > drivers/gpu/drm/bridge/display-connector.c | 4 ++++ > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++ > drivers/gpu/drm/display/drm_bridge_connector.c | 6 ++++-- > drivers/gpu/drm/drm_atomic.c | 2 ++ > drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- > drivers/gpu/drm/msm/dp/dp_drm.c | 10 ++++------ > drivers/gpu/drm/msm/dp/dp_drm.h | 7 ++++--- > include/drm/drm_bridge.h | 5 +++++ > 10 files changed, 36 insertions(+), 13 deletions(-) > --- > base-commit: 7f796de9da37b78e05edde94ebc7e3f9ee53b3b4 > change-id: 20241018-bridge-yuv420-aab94d4575de > > Best regards, Neil
On Mon, 21 Oct 2024 at 15:32, Neil Armstrong <neil.armstrong@linaro.org> wrote: > > Hi, > > On 18/10/2024 23:49, Dmitry Baryshkov wrote: > > One of the features that drm_bridge_connector can't handle currently is > > setting of the ycbcr_420_allowed flag on the connector. Add the flag to > > the drm_bridge struct and propagate it to the drm_connector as AND of > > all flags in the bridge chain. > > > > As an example of the conversion, enable the flag on the DW HDMI bridge, > > MSM DP bridge, display connector drivers (for DisplayPort and HDMI > > outputs) and AUX bridges. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > --- > > Dmitry Baryshkov (6): > > drm/display: bridge_connector: handle ycbcr_420_allowed > > drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump > > drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP > > drm/bridge: aux: allow interlaced and YCbCr 420 output > > drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge > > How do you plan to merge this serie ? Once Abhinav ack's the msm/dp change, I'd like to land it through drm-misc. I think it's the most logical way to go.
On 21/10/2024 20:22, Dmitry Baryshkov wrote: > On Mon, 21 Oct 2024 at 15:32, Neil Armstrong <neil.armstrong@linaro.org> wrote: >> >> Hi, >> >> On 18/10/2024 23:49, Dmitry Baryshkov wrote: >>> One of the features that drm_bridge_connector can't handle currently is >>> setting of the ycbcr_420_allowed flag on the connector. Add the flag to >>> the drm_bridge struct and propagate it to the drm_connector as AND of >>> all flags in the bridge chain. >>> >>> As an example of the conversion, enable the flag on the DW HDMI bridge, >>> MSM DP bridge, display connector drivers (for DisplayPort and HDMI >>> outputs) and AUX bridges. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>> --- >>> Dmitry Baryshkov (6): >>> drm/display: bridge_connector: handle ycbcr_420_allowed >>> drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump >>> drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP >>> drm/bridge: aux: allow interlaced and YCbCr 420 output >>> drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge >> >> How do you plan to merge this serie ? > > Once Abhinav ack's the msm/dp change, I'd like to land it through > drm-misc. I think it's the most logical way to go. Yup, Abhinav acked it, LGTM Neil > >
One of the features that drm_bridge_connector can't handle currently is setting of the ycbcr_420_allowed flag on the connector. Add the flag to the drm_bridge struct and propagate it to the drm_connector as AND of all flags in the bridge chain. As an example of the conversion, enable the flag on the DW HDMI bridge, MSM DP bridge, display connector drivers (for DisplayPort and HDMI outputs) and AUX bridges. Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> --- Dmitry Baryshkov (6): drm/display: bridge_connector: handle ycbcr_420_allowed drm/atomic: add interlaced and ycbcr_420 flags to connector's state dump drm/bridge: display-connector: allow YCbCr 420 for HDMI and DP drm/bridge: aux: allow interlaced and YCbCr 420 output drm/msm/dp: migrate the ycbcr_420_allowed to drm_bridge drm/bridge: dw-hdmi: set bridge's ycbcr_420_allowed flag drivers/gpu/drm/bridge/aux-bridge.c | 4 ++++ drivers/gpu/drm/bridge/aux-hpd-bridge.c | 4 ++++ drivers/gpu/drm/bridge/display-connector.c | 4 ++++ drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 3 +++ drivers/gpu/drm/display/drm_bridge_connector.c | 6 ++++-- drivers/gpu/drm/drm_atomic.c | 2 ++ drivers/gpu/drm/msm/dp/dp_display.c | 4 ++-- drivers/gpu/drm/msm/dp/dp_drm.c | 10 ++++------ drivers/gpu/drm/msm/dp/dp_drm.h | 7 ++++--- include/drm/drm_bridge.h | 5 +++++ 10 files changed, 36 insertions(+), 13 deletions(-) --- base-commit: 7f796de9da37b78e05edde94ebc7e3f9ee53b3b4 change-id: 20241018-bridge-yuv420-aab94d4575de Best regards,