| Message ID | 20241021064446.263619-10-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add ITE IT6263 LVDS to HDMI converter support | expand |
On Mon, Oct 21, 2024 at 02:44:40PM +0800, Liu Ying wrote: > This schema documents LVDS panels with dual links. lvds-dual-ports.yaml > documents dual-link LVDS display common properties. Reference the ports > property defined in lvds-dual-ports.yaml to save lines. > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > v3: > * New patch. (Dmitry) > > .../panel/panel-simple-lvds-dual-ports.yaml | 20 +------------------ > 1 file changed, 1 insertion(+), 19 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > index 10ed4b57232b..e80fc7006984 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > @@ -22,6 +22,7 @@ description: | > If the panel is more advanced a dedicated binding file is required. > > allOf: > + - $ref: /schemas/display/lvds-dual-ports.yaml# > - $ref: panel-common.yaml# So dual link panels common binding does not fit here? sorry, this is just introducing mess and confusion. Best regards, Krzysztof
On 10/21/2024, Krzysztof Kozlowski wrote: > On Mon, Oct 21, 2024 at 02:44:40PM +0800, Liu Ying wrote: >> This schema documents LVDS panels with dual links. lvds-dual-ports.yaml >> documents dual-link LVDS display common properties. Reference the ports >> property defined in lvds-dual-ports.yaml to save lines. >> >> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Signed-off-by: Liu Ying <victor.liu@nxp.com> >> --- >> v3: >> * New patch. (Dmitry) >> >> .../panel/panel-simple-lvds-dual-ports.yaml | 20 +------------------ >> 1 file changed, 1 insertion(+), 19 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml >> index 10ed4b57232b..e80fc7006984 100644 >> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml >> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml >> @@ -22,6 +22,7 @@ description: | >> If the panel is more advanced a dedicated binding file is required. >> >> allOf: >> + - $ref: /schemas/display/lvds-dual-ports.yaml# >> - $ref: panel-common.yaml# > > So dual link panels common binding does not fit here? sorry, this is > just introducing mess and confusion. That should also fit here, but lvds-dual-ports.yaml fits better, because it references lvds.yaml, which means data-mapping and data-mirror are allowed. > > Best regards, > Krzysztof >
On Mon, Oct 21, 2024 at 09:43:30AM +0200, Krzysztof Kozlowski wrote: > On Mon, Oct 21, 2024 at 02:44:40PM +0800, Liu Ying wrote: > > This schema documents LVDS panels with dual links. lvds-dual-ports.yaml > > documents dual-link LVDS display common properties. Reference the ports > > property defined in lvds-dual-ports.yaml to save lines. > > > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > > --- > > v3: > > * New patch. (Dmitry) > > > > .../panel/panel-simple-lvds-dual-ports.yaml | 20 +------------------ > > 1 file changed, 1 insertion(+), 19 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > > index 10ed4b57232b..e80fc7006984 100644 > > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > > @@ -22,6 +22,7 @@ description: | > > If the panel is more advanced a dedicated binding file is required. > > > > allOf: > > + - $ref: /schemas/display/lvds-dual-ports.yaml# > > - $ref: panel-common.yaml# > > So dual link panels common binding does not fit here? sorry, this is > just introducing mess and confusion. Why? It's allOf, so it is panel-common.yaml AND lvds-dual-ports.yaml. Where does the confusion come from?
On Mon, Oct 21, 2024 at 02:44:40PM +0800, Liu Ying wrote: > This schema documents LVDS panels with dual links. lvds-dual-ports.yaml > documents dual-link LVDS display common properties. Reference the ports > property defined in lvds-dual-ports.yaml to save lines. > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > v3: > * New patch. (Dmitry) > > .../panel/panel-simple-lvds-dual-ports.yaml | 20 +------------------ > 1 file changed, 1 insertion(+), 19 deletions(-) Squash this with patch 8 then it doesn't look like you are duplicating things. Rob
On Mon, Oct 21, 2024 at 09:43:30AM +0200, Krzysztof Kozlowski wrote: > On Mon, Oct 21, 2024 at 02:44:40PM +0800, Liu Ying wrote: > > This schema documents LVDS panels with dual links. lvds-dual-ports.yaml > > documents dual-link LVDS display common properties. Reference the ports > > property defined in lvds-dual-ports.yaml to save lines. > > > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > > --- > > v3: > > * New patch. (Dmitry) > > > > .../panel/panel-simple-lvds-dual-ports.yaml | 20 +------------------ > > 1 file changed, 1 insertion(+), 19 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > > index 10ed4b57232b..e80fc7006984 100644 > > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > > @@ -22,6 +22,7 @@ description: | > > If the panel is more advanced a dedicated binding file is required. > > > > allOf: > > + - $ref: /schemas/display/lvds-dual-ports.yaml# > > - $ref: panel-common.yaml# > > So dual link panels common binding does not fit here? sorry, this is > just introducing mess and confusion. Unfortunately, we put 'lvds' in the name of the properties and panel-common-dual.yaml is used by non-LVDS devices. Rob
On 10/22/2024, Rob Herring wrote: > On Mon, Oct 21, 2024 at 02:44:40PM +0800, Liu Ying wrote: >> This schema documents LVDS panels with dual links. lvds-dual-ports.yaml >> documents dual-link LVDS display common properties. Reference the ports >> property defined in lvds-dual-ports.yaml to save lines. >> >> Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Signed-off-by: Liu Ying <victor.liu@nxp.com> >> --- >> v3: >> * New patch. (Dmitry) >> >> .../panel/panel-simple-lvds-dual-ports.yaml | 20 +------------------ >> 1 file changed, 1 insertion(+), 19 deletions(-) > > Squash this with patch 8 then it doesn't look like you are duplicating > things. Will squash this and patch 10 with patch 8. Thanks. > > Rob
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml index 10ed4b57232b..e80fc7006984 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml @@ -22,6 +22,7 @@ description: | If the panel is more advanced a dedicated binding file is required. allOf: + - $ref: /schemas/display/lvds-dual-ports.yaml# - $ref: panel-common.yaml# properties: @@ -55,28 +56,10 @@ properties: properties: port@0: - $ref: /schemas/graph.yaml#/$defs/port-base - unevaluatedProperties: false - description: The first sink port. - - properties: - dual-lvds-odd-pixels: - type: boolean - description: The first sink port for odd pixels. - required: - dual-lvds-odd-pixels port@1: - $ref: /schemas/graph.yaml#/$defs/port-base - unevaluatedProperties: false - description: The second sink port. - - properties: - dual-lvds-even-pixels: - type: boolean - description: The second sink port for even pixels. - required: - dual-lvds-even-pixels @@ -88,7 +71,6 @@ unevaluatedProperties: false required: - compatible - - ports - power-supply examples:
This schema documents LVDS panels with dual links. lvds-dual-ports.yaml documents dual-link LVDS display common properties. Reference the ports property defined in lvds-dual-ports.yaml to save lines. Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Signed-off-by: Liu Ying <victor.liu@nxp.com> --- v3: * New patch. (Dmitry) .../panel/panel-simple-lvds-dual-ports.yaml | 20 +------------------ 1 file changed, 1 insertion(+), 19 deletions(-)