| Message ID | 20241021091116.14368-1-pstanner@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | drm/lsdc: Request PCI BAR | expand |
Hi, thanks On 2024/10/21 17:11, Philipp Stanner wrote: > lsdc currently just ioremaps its PCI BAR with pcim_iomap(). Performing > a region regquest additionally can make the driver more robust. > > Replace pcim_iomap() with the managed function pcim_iomap_region() which > performs the request and ioremaps the BAR. > > Signed-off-by: Philipp Stanner <pstanner@redhat.com> Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev> > --- > drivers/gpu/drm/loongson/lsdc_drv.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/loongson/lsdc_drv.c b/drivers/gpu/drm/loongson/lsdc_drv.c > index adc7344d2f80..592d01b6767e 100644 > --- a/drivers/gpu/drm/loongson/lsdc_drv.c > +++ b/drivers/gpu/drm/loongson/lsdc_drv.c > @@ -230,9 +230,9 @@ lsdc_create_device(struct pci_dev *pdev, > lsdc_gem_init(ddev); > > /* Bar 0 of the DC device contains the MMIO register's base address */ > - ldev->reg_base = pcim_iomap(pdev, 0, 0); > - if (!ldev->reg_base) > - return ERR_PTR(-ENODEV); > + ldev->reg_base = pcim_iomap_region(pdev, 0, "lsdc"); > + if (IS_ERR(ldev->reg_base)) > + return ldev->reg_base; > > spin_lock_init(&ldev->reglock); >
diff --git a/drivers/gpu/drm/loongson/lsdc_drv.c b/drivers/gpu/drm/loongson/lsdc_drv.c index adc7344d2f80..592d01b6767e 100644 --- a/drivers/gpu/drm/loongson/lsdc_drv.c +++ b/drivers/gpu/drm/loongson/lsdc_drv.c @@ -230,9 +230,9 @@ lsdc_create_device(struct pci_dev *pdev, lsdc_gem_init(ddev); /* Bar 0 of the DC device contains the MMIO register's base address */ - ldev->reg_base = pcim_iomap(pdev, 0, 0); - if (!ldev->reg_base) - return ERR_PTR(-ENODEV); + ldev->reg_base = pcim_iomap_region(pdev, 0, "lsdc"); + if (IS_ERR(ldev->reg_base)) + return ldev->reg_base; spin_lock_init(&ldev->reglock);
lsdc currently just ioremaps its PCI BAR with pcim_iomap(). Performing a region regquest additionally can make the driver more robust. Replace pcim_iomap() with the managed function pcim_iomap_region() which performs the request and ioremaps the BAR. Signed-off-by: Philipp Stanner <pstanner@redhat.com> --- drivers/gpu/drm/loongson/lsdc_drv.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)