diff mbox series

[net-next] net: amd8111e: Remove duplicate definition of PCI_VENDOR_ID_AMD

Message ID 20241021153825.2536819-1-yazen.ghannam@amd.com (mailing list archive)
State New
Delegated to: Netdev Maintainers
Headers show
Series [net-next] net: amd8111e: Remove duplicate definition of PCI_VENDOR_ID_AMD | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 2 maintainers not CCed: bhelgaas@google.com horms@kernel.org
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 4 this patch: 4
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 7 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-10-22--00-00 (tests: 765)

Commit Message

Yazen Ghannam Oct. 21, 2024, 3:38 p.m. UTC 
The AMD PCI vendor ID is already defined in <linux/pci_ids.h>.

Remove this local definition as it is not needed.

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
---
 drivers/net/ethernet/amd/amd8111e.h | 1 -
 1 file changed, 1 deletion(-)

Comments

Kalesh Anakkur Purayil Oct. 21, 2024, 3:47 p.m. UTC | #1 
On Mon, Oct 21, 2024 at 9:08 PM Yazen Ghannam <yazen.ghannam@amd.com> wrote:
>
> The AMD PCI vendor ID is already defined in <linux/pci_ids.h>.
>
> Remove this local definition as it is not needed.
>
> Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>

LGTM
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/amd/amd8111e.h b/drivers/net/ethernet/amd/amd8111e.h
index 305232f5476d..e4ee4c28800c 100644
--- a/drivers/net/ethernet/amd/amd8111e.h
+++ b/drivers/net/ethernet/amd/amd8111e.h
@@ -550,7 +550,6 @@  typedef enum {
 
 /* Driver definitions */
 
-#define	 PCI_VENDOR_ID_AMD		0x1022
 #define  PCI_DEVICE_ID_AMD8111E_7462	0x7462
 
 #define MAX_UNITS			8 /* Maximum number of devices possible */