| Message ID | 20241021144103.928386-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [next] Input: serio_raw: Fix uninitialized variable 'written' | expand |
Hi Colin, On Mon, Oct 21, 2024 at 03:41:03PM +0100, Colin Ian King wrote: > The variable written is not initialized and subsequent increments of the > variable are using an uninitialized value. Fix this by initializating it > at the start of the function. Thank you for the patch but I already have one fixing this up queued. > > Fixes: 5b53a9d40c4f ("Input: serio_raw - use guard notation for locks and other resources") > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/input/serio/serio_raw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c > index e058fef07f57..4d6395088986 100644 > --- a/drivers/input/serio/serio_raw.c > +++ b/drivers/input/serio/serio_raw.c > @@ -185,7 +185,7 @@ static ssize_t serio_raw_write(struct file *file, const char __user *buffer, > { > struct serio_raw_client *client = file->private_data; > struct serio_raw *serio_raw = client->serio_raw; > - int written; > + int written = 0; > unsigned char c; > > scoped_guard(mutex_intr, &serio_raw_mutex) { > -- > 2.39.5 >
diff --git a/drivers/input/serio/serio_raw.c b/drivers/input/serio/serio_raw.c index e058fef07f57..4d6395088986 100644 --- a/drivers/input/serio/serio_raw.c +++ b/drivers/input/serio/serio_raw.c @@ -185,7 +185,7 @@ static ssize_t serio_raw_write(struct file *file, const char __user *buffer, { struct serio_raw_client *client = file->private_data; struct serio_raw *serio_raw = client->serio_raw; - int written; + int written = 0; unsigned char c; scoped_guard(mutex_intr, &serio_raw_mutex) {
The variable written is not initialized and subsequent increments of the variable are using an uninitialized value. Fix this by initializating it at the start of the function. Fixes: 5b53a9d40c4f ("Input: serio_raw - use guard notation for locks and other resources") Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/input/serio/serio_raw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)