diff mbox series

[v2] platform/x86: dell-dcdbase: Replace snprintf in show functions with sysfs_emit

Message ID 20241022030500.9986-1-zenghongling@kylinos.cn (mailing list archive)
State Accepted, archived
Headers show
Series [v2] platform/x86: dell-dcdbase: Replace snprintf in show functions with sysfs_emit | expand

Commit Message

Hongling Zeng Oct. 22, 2024, 3:05 a.m. UTC 
show() must not use snprintf() when formatting the value to be
returned to user space.

Signed-off-by: Hongling Zeng <zenghongling@kylinos.cn>
---
 drivers/platform/x86/dell/dcdbas.c | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

Comments

Ilpo Järvinen Oct. 22, 2024, 8:57 a.m. UTC | #1 
On Tue, 22 Oct 2024 11:05:00 +0800, Hongling Zeng wrote:

> show() must not use snprintf() when formatting the value to be
> returned to user space.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo branch. Note it will show up in the public
platform-drivers-x86/review-ilpo branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/1] platform/x86: dell-dcdbase: Replace snprintf in show functions with sysfs_emit
      commit: 81e2cc3688cb0002d22207a0a5b11be230d4ecc4

--
 i.
diff mbox series

Patch

diff --git a/drivers/platform/x86/dell/dcdbas.c b/drivers/platform/x86/dell/dcdbas.c
index a60e350..c2fef23 100644
--- a/drivers/platform/x86/dell/dcdbas.c
+++ b/drivers/platform/x86/dell/dcdbas.c
@@ -31,6 +31,7 @@ 
 #include <linux/string.h>
 #include <linux/types.h>
 #include <linux/mutex.h>
+#include <linux/sysfs.h>
 
 #include "dcdbas.h"
 
@@ -132,14 +133,14 @@  static ssize_t smi_data_buf_phys_addr_show(struct device *dev,
 					   struct device_attribute *attr,
 					   char *buf)
 {
-	return sprintf(buf, "%x\n", (u32)smi_buf.dma);
+	return sysfs_emit(buf, "%x\n", (u32)smi_buf.dma);
 }
 
 static ssize_t smi_data_buf_size_show(struct device *dev,
 				      struct device_attribute *attr,
 				      char *buf)
 {
-	return sprintf(buf, "%lu\n", smi_buf.size);
+	return sysfs_emit(buf, "%lu\n", smi_buf.size);
 }
 
 static ssize_t smi_data_buf_size_store(struct device *dev,
@@ -200,7 +201,7 @@  static ssize_t host_control_action_show(struct device *dev,
 					struct device_attribute *attr,
 					char *buf)
 {
-	return sprintf(buf, "%u\n", host_control_action);
+	return sysfs_emit(buf, "%u\n", host_control_action);
 }
 
 static ssize_t host_control_action_store(struct device *dev,
@@ -224,7 +225,7 @@  static ssize_t host_control_smi_type_show(struct device *dev,
 					  struct device_attribute *attr,
 					  char *buf)
 {
-	return sprintf(buf, "%u\n", host_control_smi_type);
+	return sysfs_emit(buf, "%u\n", host_control_smi_type);
 }
 
 static ssize_t host_control_smi_type_store(struct device *dev,
@@ -239,7 +240,7 @@  static ssize_t host_control_on_shutdown_show(struct device *dev,
 					     struct device_attribute *attr,
 					     char *buf)
 {
-	return sprintf(buf, "%u\n", host_control_on_shutdown);
+	return sysfs_emit(buf, "%u\n", host_control_on_shutdown);
 }
 
 static ssize_t host_control_on_shutdown_store(struct device *dev,