| Message ID | 20241021130308.3616451-1-ryan.roberts@arm.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 5337ff41d37d4171868bb7b34dade68e269743f0 |
| Headers | show |
| Series | [v2] ASoC: soc-utils: Remove PAGE_SIZE compile-time constant assumption | expand |
On Mon, 21 Oct 2024 14:03:07 +0100, Ryan Roberts wrote: > In pursuit of the goal of supporting boot-time page size selection, > remove use of PAGE_SIZE from the dummy_dma_hardware struct definition, > since the value is not known at compile-time for this config. > > Given the previous parameters were "essentially random", let's just > hardcode them as 4K and 4K*2 to sidestep the need to boot-time patch the > structure with the selected PAGE_SIZE. > > [...] Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: soc-utils: Remove PAGE_SIZE compile-time constant assumption commit: 5337ff41d37d4171868bb7b34dade68e269743f0 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/soc-utils.c b/sound/soc/soc-utils.c index 303823dc45d7..aa93e77ac937 100644 --- a/sound/soc/soc-utils.c +++ b/sound/soc/soc-utils.c @@ -103,8 +103,8 @@ static const struct snd_pcm_hardware dummy_dma_hardware = { .info = SNDRV_PCM_INFO_INTERLEAVED | SNDRV_PCM_INFO_BLOCK_TRANSFER, .buffer_bytes_max = 128*1024, - .period_bytes_min = PAGE_SIZE, - .period_bytes_max = PAGE_SIZE*2, + .period_bytes_min = 4096, + .period_bytes_max = 4096*2, .periods_min = 2, .periods_max = 128, };
In pursuit of the goal of supporting boot-time page size selection, remove use of PAGE_SIZE from the dummy_dma_hardware struct definition, since the value is not known at compile-time for this config. Given the previous parameters were "essentially random", let's just hardcode them as 4K and 4K*2 to sidestep the need to boot-time patch the structure with the selected PAGE_SIZE. Signed-off-by: Ryan Roberts <ryan.roberts@arm.com> --- sound/soc/soc-utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.43.0