diff mbox series

ASoC: dt-bindings: everest,es8328: Document audio graph port

Message ID 20241019-es8328-doc-port-v1-1-25c1d1b5c65c@collabora.com (mailing list archive)
State Accepted
Commit e6d20a9b0f376fda3e3c3709a59cefa6c0021784
Headers show
Series ASoC: dt-bindings: everest,es8328: Document audio graph port | expand

Commit Message

Cristian Ciocaltea Oct. 19, 2024, 12:43 a.m. UTC
The ES8328/ES8388 audio codec is currently used in conjunction with
audio-graph-card to provide an endpoint for binding with the other side
of the audio link.

This is achieved via the 'port' property, which is not supported by the
binding:

  rk3588s-indiedroid-nova.dtb: audio-codec@11: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
    from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml#

Document the missing property.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
---
 Documentation/devicetree/bindings/sound/everest,es8328.yaml | 4 ++++
 1 file changed, 4 insertions(+)


---
base-commit: f2493655d2d3d5c6958ed996b043c821c23ae8d3
change-id: 20241019-es8328-doc-port-1065f8397e29

Comments

Rob Herring Oct. 21, 2024, 7:07 p.m. UTC | #1
On Sat, 19 Oct 2024 03:43:14 +0300, Cristian Ciocaltea wrote:
> The ES8328/ES8388 audio codec is currently used in conjunction with
> audio-graph-card to provide an endpoint for binding with the other side
> of the audio link.
> 
> This is achieved via the 'port' property, which is not supported by the
> binding:
> 
>   rk3588s-indiedroid-nova.dtb: audio-codec@11: 'port' does not match any of the regexes: 'pinctrl-[0-9]+'
>     from schema $id: http://devicetree.org/schemas/sound/everest,es8328.yaml#
> 
> Document the missing property.
> 
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
>  Documentation/devicetree/bindings/sound/everest,es8328.yaml | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>
Mark Brown Oct. 22, 2024, 2:07 p.m. UTC | #2
On Sat, 19 Oct 2024 03:43:14 +0300, Cristian Ciocaltea wrote:
> The ES8328/ES8388 audio codec is currently used in conjunction with
> audio-graph-card to provide an endpoint for binding with the other side
> of the audio link.
> 
> This is achieved via the 'port' property, which is not supported by the
> binding:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: everest,es8328: Document audio graph port
      commit: e6d20a9b0f376fda3e3c3709a59cefa6c0021784

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/sound/everest,es8328.yaml b/Documentation/devicetree/bindings/sound/everest,es8328.yaml
index a0f4670fa38c8435b63566f7383c940b4950caa4..ed18e40dcaacf7eed39fa659795efb1518678379 100644
--- a/Documentation/devicetree/bindings/sound/everest,es8328.yaml
+++ b/Documentation/devicetree/bindings/sound/everest,es8328.yaml
@@ -50,6 +50,10 @@  properties:
   HPVDD-supply:
     description: Regulator providing analog output voltage 3.3V
 
+  port:
+    $ref: audio-graph-port.yaml#
+    unevaluatedProperties: false
+
 required:
   - compatible
   - clocks