diff mbox series

tests: hsr: Increase timeout to 10 minutes

Message ID 20241022080223.718547-1-jiangyunshui@kylinos.cn (mailing list archive)
State New
Delegated to: Netdev Maintainers
Headers show
Series tests: hsr: Increase timeout to 10 minutes | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5 this patch: 5
netdev/build_tools success Errors and warnings before: 157 (+1) this patch: 157 (+1)
netdev/cc_maintainers warning 3 maintainers not CCed: linux-kselftest@vger.kernel.org shuah@kernel.org horms@kernel.org
netdev/build_clang success Errors and warnings before: 4 this patch: 4
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 8 this patch: 8
netdev/checkpatch warning WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest warning net-next-2024-10-22--15-00 (tests: 766)

Commit Message

Yunshui Jiang Oct. 22, 2024, 8:02 a.m. UTC 
The time-consuming HSR test, hsr_ping.sh, actually needs 7 min to run.
Around 375s to be exact, and even more on a debug kernel or kernel with
other network security limits. The timeout setting for the kselftest is
currently 45 seconds, which is way too short to integrate hsr tests to
run_kselftest infrastructure. So, HSR test needs an explicit setting.
And to leave us some slack, use 10 min as default timeout.

Signed-off-by: Yunshui Jiang <jiangyunshui@kylinos.cn>
---
 tools/testing/selftests/net/hsr/settings | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 tools/testing/selftests/net/hsr/settings

Comments

Simon Horman Oct. 22, 2024, 3:46 p.m. UTC | #1 
On Tue, Oct 22, 2024 at 04:02:23PM +0800, Yunshui Jiang wrote:
> The time-consuming HSR test, hsr_ping.sh, actually needs 7 min to run.
> Around 375s to be exact, and even more on a debug kernel or kernel with
> other network security limits. The timeout setting for the kselftest is
> currently 45 seconds, which is way too short to integrate hsr tests to
> run_kselftest infrastructure. So, HSR test needs an explicit setting.
> And to leave us some slack, use 10 min as default timeout.
> 
> Signed-off-by: Yunshui Jiang <jiangyunshui@kylinos.cn>

Reviewed-by: Simon Horman <horms@kernel.org>
Andrew Lunn Oct. 22, 2024, 4:12 p.m. UTC | #2 
On Tue, Oct 22, 2024 at 04:02:23PM +0800, Yunshui Jiang wrote:
> The time-consuming HSR test, hsr_ping.sh, actually needs 7 min to run.
> Around 375s to be exact

That is quite a long time, if it is being used in a CI/CD environment.

If it possible to make the test faster? What takes all the time?

	Andrew
diff mbox series

Patch

diff --git a/tools/testing/selftests/net/hsr/settings b/tools/testing/selftests/net/hsr/settings
new file mode 100644
index 000000000000..a62d2fa1275c
--- /dev/null
+++ b/tools/testing/selftests/net/hsr/settings
@@ -0,0 +1 @@ 
+timeout=600