| Message ID | 20241022021230.2322132-1-jasonhell19@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Meta(Facebook) Ventura BMC(AST2600) | expand |
On Tue, 2024-10-22 at 10:12 +0800, Jason-Hsu wrote: > Add Linux device tree entry related to Meta(Facebook) Ventura specific > devices connected to BMC(AST2600) SoC. > > Signed-off-by: Jason-Hsu <jasonhell19@gmail.com> What commands are you running to generate and send your patch series? The patches must be threaded properly. `git send-email` or `b4` both do what is expected without any effort required. Please consider using them, particularly b4, if you're not already. Andrew
Andrew Jeffery <andrew@codeconstruct.com.au> 於 2024年10月23日 週三 下午2:15寫道： > > On Tue, 2024-10-22 at 10:12 +0800, Jason-Hsu wrote: > > Add Linux device tree entry related to Meta(Facebook) Ventura specific > > devices connected to BMC(AST2600) SoC. > > > > Signed-off-by: Jason-Hsu <jasonhell19@gmail.com> > > What commands are you running to generate and send your patch series? > > The patches must be threaded properly. > > `git send-email` or `b4` both do what is expected without any effort > required. Please consider using them, particularly b4, if you're not > already. > > Andrew We use `git format-patch` and `git send-email` command to generate and send patch series as below, could you help to check? Thank you. git format-patch -2 --cover-letter git send-email --smtp-debug --to=robh@kernel.org --to=krzk+dt@kernel.org --to=conor+dt@kernel.org --to=joel@jms.id.au --to=andrew@codeconstruct.com.au --to=patrick@stwcx.xyz --to=devicetree@vger.kernel.org --to=linux-arm-kernel@lists.infradead.org --to=linux-aspeed@lists.ozlabs.org --to=linux-kernel@vger.kernel.org --cc=yang.chen@quantatw.com --cc=jerry.lin@quantatw.com *.patch Jason
On Wed, 2024-10-23 at 16:32 +0800, 徐傑生 wrote: > Andrew Jeffery <andrew@codeconstruct.com.au> 於 2024年10月23日 週三 下午2:15寫道： > > > > On Tue, 2024-10-22 at 10:12 +0800, Jason-Hsu wrote: > > > Add Linux device tree entry related to Meta(Facebook) Ventura specific > > > devices connected to BMC(AST2600) SoC. > > > > > > Signed-off-by: Jason-Hsu <jasonhell19@gmail.com> > > > > What commands are you running to generate and send your patch series? > > > > The patches must be threaded properly. > > > > `git send-email` or `b4` both do what is expected without any effort > > required. Please consider using them, particularly b4, if you're not > > already. > > > > Andrew > > We use `git format-patch` and `git send-email` command to generate and > send patch series as below, could you help to check? Thank you. > > git format-patch -2 --cover-letter > > git send-email --smtp-debug --to=robh@kernel.org > --to=krzk+dt@kernel.org --to=conor+dt@kernel.org --to=joel@jms.id.au > --to=andrew@codeconstruct.com.au --to=patrick@stwcx.xyz > --to=devicetree@vger.kernel.org > --to=linux-arm-kernel@lists.infradead.org > --to=linux-aspeed@lists.ozlabs.org --to=linux-kernel@vger.kernel.org > --cc=yang.chen@quantatw.com --cc=jerry.lin@quantatw.com *.patch > So from the details in the cover letter I'm guessing that you're using Ubuntu 22.04 LTS (Jammy). At least, Jammy ships git-2.34.1, which is what is mentioned in the cover letter. The --thread option in the man-page for git-format-patch[1] says: The default is --no-thread, unless the format.thread configuration is set. If --thread is specified without a style, it defaults to the style specified by format.thread if any, or else shallow. Beware that the default for git send-email is to thread emails itself. If you want git format-patch to take care of threading, you will want to ensure that threading is disabled for git send-email. [1]: https://manpages.ubuntu.com/manpages/jammy/en/man1/git-format-patch.1.html The --thread option in the man-page for git-send-email[2] says: If disabled with "--no-thread", those headers will not be added (unless specified with --in-reply-to). Default is the value of the sendemail.thread configuration value; if that is unspecified, default to --thread. [2]: https://manpages.ubuntu.com/manpages/jammy/en/man1/git-send-email.1.html Since you're not supplying any thread-related arguments in either case, I wonder if you have thread values set in your git config. What's the output of the following two commands for you? $ git config --show-scope --get format.thread $ git config --show-scope --get sendemail.thread Regardless, you may want to try passing `--thread` in your `git send- email` invocation. Finally, please pass `-v $X` to `git format-patch` to version your series (the value for X is how many times you've sent revisions of the series). Currently I count 3 distinct attempts, so next time you send out the patches you should pass `-v 4`. However, the b4 tool is helpful here, as it largely automates the process for you. Andrew
Add Linux device tree entry related to Meta(Facebook) Ventura specific devices connected to BMC(AST2600) SoC. Signed-off-by: Jason-Hsu <jasonhell19@gmail.com> --- v1: 1. Create ventura dts file. 2. Add commit msg. 3. Use format-patch to generate patch. 4. Add subject prefixes matching the subsystem. --- Jason-Hsu (2): dt-bindings: arm: aspeed: add Meta Ventura board ARM: dts: aspeed: ventura: add Meta Ventura BMC .../bindings/arm/aspeed/aspeed.yaml | 1 + arch/arm/boot/dts/aspeed/Makefile | 1 + .../aspeed/aspeed-bmc-facebook-ventura.dts | 884 ++++++++++++++++++ 3 files changed, 886 insertions(+) create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-ventura.dts