mbox series

[0/4] cpufreq/amd-pstate:Cleanups

Message ID 20241023102108.5980-1-Dhananjay.Ugwekar@amd.com (mailing list archive)
Headers show
Series cpufreq/amd-pstate:Cleanups | expand

Message

Dhananjay Ugwekar Oct. 23, 2024, 10:21 a.m. UTC 
Explicitly rename functions that enable CPPC as *_cppc_*. 

Do not clear MSR_AMD_CPPC_ENABLE as it is a set-once register, i.e. it 
cannot be cleared. 

Propagate the epp value to shared mem in the reenable function.

Replicate the offline flow of MSR based systems in shared mem systems.

Dhananjay Ugwekar (4):
  cpufreq/amd-pstate: Rename functions that enable CPPC
  cpufreq/amd-pstate: Do not attempt to clear MSR_AMD_CPPC_ENABLE
  cpufreq/amd-pstate: Call cppc_set_epp_perf in the reenable function
  cpufreq/amd-pstate: Align offline flow of shared memory and MSR based
    systems

 drivers/cpufreq/amd-pstate.c | 39 ++++++++++++++++++++++--------------
 1 file changed, 24 insertions(+), 15 deletions(-)

Comments

Mario Limonciello Oct. 23, 2024, 1:15 p.m. UTC | #1 
On 10/23/2024 05:21, Dhananjay Ugwekar wrote:
> Explicitly rename functions that enable CPPC as *_cppc_*.
> 
> Do not clear MSR_AMD_CPPC_ENABLE as it is a set-once register, i.e. it
> cannot be cleared.
> 
> Propagate the epp value to shared mem in the reenable function.
> 
> Replicate the offline flow of MSR based systems in shared mem systems.
> 
> Dhananjay Ugwekar (4):
>    cpufreq/amd-pstate: Rename functions that enable CPPC
>    cpufreq/amd-pstate: Do not attempt to clear MSR_AMD_CPPC_ENABLE
>    cpufreq/amd-pstate: Call cppc_set_epp_perf in the reenable function
>    cpufreq/amd-pstate: Align offline flow of shared memory and MSR based
>      systems
> 
>   drivers/cpufreq/amd-pstate.c | 39 ++++++++++++++++++++++--------------
>   1 file changed, 24 insertions(+), 15 deletions(-)
> 

Thanks!

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>