diff mbox series

NFS: Fix attribute delegation behaviour on exclusive create

Message ID ec430d0f67478233dba5625b3c1e8eca4c91626f.1729690156.git.trond.myklebust@hammerspace.com (mailing list archive)
State New
Headers show
Series NFS: Fix attribute delegation behaviour on exclusive create | expand

Commit Message

Trond Myklebust Oct. 23, 2024, 1:35 p.m. UTC 
From: Trond Myklebust <trond.myklebust@hammerspace.com>

When the client does an exclusive create and the server decides to store
the verifier in the timestamps, a SETATTR is subsequently sent to fix up
those timestamps. When that is the case, suppress the exceptions for
attribute delegations in nfs4_bitmap_copy_adjust().

Fixes: 32215c1f893a ("NFSv4: Don't request atime/mtime/size if they are delegated to us")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---
 fs/nfs/nfs4proc.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Jeff Layton Oct. 23, 2024, 2:45 p.m. UTC | #1 
On Wed, 2024-10-23 at 09:35 -0400, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> When the client does an exclusive create and the server decides to store
> the verifier in the timestamps, a SETATTR is subsequently sent to fix up
> those timestamps. When that is the case, suppress the exceptions for
> attribute delegations in nfs4_bitmap_copy_adjust().
> 
> Fixes: 32215c1f893a ("NFSv4: Don't request atime/mtime/size if they are delegated to us")
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
>  fs/nfs/nfs4proc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index cd2fbde2e6d7..9d40319e063d 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -3452,6 +3452,10 @@ static int nfs4_do_setattr(struct inode *inode, const struct cred *cred,
>  		adjust_flags |= NFS_INO_INVALID_MODE;
>  	if (sattr->ia_valid & (ATTR_UID | ATTR_GID))
>  		adjust_flags |= NFS_INO_INVALID_OTHER;
> +	if (sattr->ia_valid & ATTR_ATIME)
> +		adjust_flags |= NFS_INO_INVALID_ATIME;
> +	if (sattr->ia_valid & ATTR_MTIME)
> +		adjust_flags |= NFS_INO_INVALID_MTIME;
>  
>  	do {
>  		nfs4_bitmap_copy_adjust(bitmask, nfs4_bitmask(server, fattr->label),

Reviewed-by: Jeff Layton <jlayton@kernel.org>
diff mbox series

Patch

diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index cd2fbde2e6d7..9d40319e063d 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -3452,6 +3452,10 @@  static int nfs4_do_setattr(struct inode *inode, const struct cred *cred,
 		adjust_flags |= NFS_INO_INVALID_MODE;
 	if (sattr->ia_valid & (ATTR_UID | ATTR_GID))
 		adjust_flags |= NFS_INO_INVALID_OTHER;
+	if (sattr->ia_valid & ATTR_ATIME)
+		adjust_flags |= NFS_INO_INVALID_ATIME;
+	if (sattr->ia_valid & ATTR_MTIME)
+		adjust_flags |= NFS_INO_INVALID_MTIME;
 
 	do {
 		nfs4_bitmap_copy_adjust(bitmask, nfs4_bitmask(server, fattr->label),